From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8A3F43095; Fri, 18 Aug 2023 11:22:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5071440ED9; Fri, 18 Aug 2023 11:22:10 +0200 (CEST) Received: from mail-vk1-f181.google.com (mail-vk1-f181.google.com [209.85.221.181]) by mails.dpdk.org (Postfix) with ESMTP id 3B5BF40395 for ; Fri, 18 Aug 2023 11:22:09 +0200 (CEST) Received: by mail-vk1-f181.google.com with SMTP id 71dfb90a1353d-48ae4823077so203504e0c.2 for ; Fri, 18 Aug 2023 02:22:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692350528; x=1692955328; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=wvBvIrJC+kaHEYhvIWyqLEp/UKOgtY4o8EA/CWmkG0w=; b=pjf4+iWXzLOjnViZK75SJWsZt9IGeddgVaS5hVjludC9qTppbbbzauc34OkyGnD5Ww kQNTnwFyM0YNkFOR1VClzpnaghpIApL7Plq/7E891WXpDtwPagoE++qK+yh2pYoKU9jn b8XjqsmF+EDYaRPQyDbNGxeAdrQeed7zbzshHlwaQ9S53ZxapT0Q20jMqmIPCwCJTWAV qLc5mmNmjDbP1NrOfjlOtyrU1uyX+oMzybpUC8enDHQXnT97sTX15ZOLQnPu0Y+Wjpvw XKcdyDkRMX+5pVS4SD7gI+iVEhEf56PJiUKdAF6YkRFoo8oALD6ubcJKSmaGQ0un9TiD 6Q/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692350528; x=1692955328; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wvBvIrJC+kaHEYhvIWyqLEp/UKOgtY4o8EA/CWmkG0w=; b=O0MWywODRua+6btRw+MvGhKrr61VWXHgbU7/SsOZ2P5xG/aXvIlXhk+Pi5c2LN2OV0 TvZDSJgNXC4IweMFufk9M4g1yOd5gLzQ+jSD+/cjhcv8lH8hgZahqK8YxGnNdMsSURjb VNjwozV+cazhWXDZSYZyezigDBZSQW8INPLd6YcHS71UExgtLD7nhgR0hkZQdMp7/QKB /D2kDIIE0na+y5ntYpMvEZFRgLsrayhfgaBhreewL4FzUz4QqBYACCheKB3o/hOliYsI VZHFlXdQSzpkqMUBnzUTa3GOIaA7R5rgqa83pU8wx5FIRKNkIHTsZZgSdgdMMvKCrPe0 XR7Q== X-Gm-Message-State: AOJu0YwcWFJoikijTzwycbFOksERlZZlpk5xvmHtOrFoPlDcVk1ixGZf 8fvDGOCzeO5Jksi189zrpn+K+KbVAwJbNoEapdI= X-Google-Smtp-Source: AGHT+IGImNQrBT1z6eJy6yb6baiNi9qNdmcJa/nsMPmQqfvGTFEpgY+lSL1Wgzl/8BBtCk+xvFDMcGygtkKtdllqOpQ= X-Received: by 2002:a05:6102:3665:b0:446:e878:f24 with SMTP id bg5-20020a056102366500b00446e8780f24mr2046863vsb.14.1692350528303; Fri, 18 Aug 2023 02:22:08 -0700 (PDT) MIME-Version: 1.0 References: <20230731055514.1708500-1-asekhar@marvell.com> <20230731055514.1708500-2-asekhar@marvell.com> In-Reply-To: <20230731055514.1708500-2-asekhar@marvell.com> From: Jerin Jacob Date: Fri, 18 Aug 2023 14:51:42 +0530 Message-ID: Subject: Re: [PATCH 2/2] mempool/cnxk: fix alloc from non-EAL pthreads To: Ashwin Sekhar T K Cc: dev@dpdk.org, Pavan Nikhilesh , jerinj@marvell.com, skori@marvell.com, skoteshwar@marvell.com, kirankumark@marvell.com, psatheesh@marvell.com, anoobj@marvell.com, gakhil@marvell.com, hkalra@marvell.com, ndabilpuram@marvell.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jul 31, 2023 at 11:25=E2=80=AFAM Ashwin Sekhar T K wrote: > > For non-EAL pthreads, rte_lcore_id() will not be valid. > So, batch allocation cannot be used as we won't have a > dedicated alloc buffer for the thread. So, fallback to > bulk alloc in such cases. > > Fixes: 91531e63f43b ("mempool/cnxk: add cn10k batch dequeue") > > Signed-off-by: Ashwin Sekhar T K > --- > drivers/mempool/cnxk/cn10k_mempool_ops.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/mempool/cnxk/cn10k_mempool_ops.c b/drivers/mempool/c= nxk/cn10k_mempool_ops.c > index 41b755b52b..9594370ecd 100644 > --- a/drivers/mempool/cnxk/cn10k_mempool_ops.c > +++ b/drivers/mempool/cnxk/cn10k_mempool_ops.c > @@ -326,6 +326,12 @@ cn10k_mempool_deq(struct rte_mempool *mp, void **obj= _table, unsigned int n) Looks like same problem on enq() as well, if so, please fix the same. > struct batch_op_data *op_data; > unsigned int count =3D 0; > > + /* For non-EAL threads, rte_lcore_id() will not be valid. Hence > + * fallback to bulk alloc > + */ > + if (unlikely(rte_lcore_id() =3D=3D LCORE_ID_ANY)) > + return cnxk_mempool_deq(mp, obj_table, n); > + > op_data =3D batch_op_data_get(mp->pool_id); > if (op_data->max_async_batch) > count =3D mempool_deq_batch_async(mp, obj_table, n); > -- > 2.25.1 >