From: Jerin Jacob <jerinjacobk@gmail.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com,
Jerin Jacob <jerinj@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
Ciara Power <ciara.power@intel.com>
Subject: Re: [PATCH] trace: take live traces via telemetry
Date: Thu, 13 Oct 2022 19:39:07 +0530 [thread overview]
Message-ID: <CALBAE1NWw1G8uzV8LPSBFfJTR_TGPhDMjzpOtBp3izGivS3bpQ@mail.gmail.com> (raw)
In-Reply-To: <20221013074928.3062458-1-david.marchand@redhat.com>
On Thu, Oct 13, 2022 at 1:20 PM David Marchand
<david.marchand@redhat.com> wrote:
>
I would suggest to change the subject as "trace: enable trace
operations via telemetry" or so
> Register telemetry commands to list and configure trace points and later
> save traces for a running DPDK application.
>
> Note: trace point names contain a '.', so the list of valid characters
> used in telemetry commands and dictionary keys has been extended.
>
> Example with testpmd running with two net/null ports (startup command
> from devtools/test-null.sh):
>
> --> /trace/disable,*
> {"/trace/disable": {"Count": 2}}
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> +}
> +
> +static int
> +trace_telemetry_list(const char *cmd __rte_unused,
> + const char *params, struct rte_tel_data *d)
> +{
> + struct trace_point *tp;
> +
> + rte_tel_data_start_dict(d);
> + STAILQ_FOREACH(tp, &tp_list, next) {
> + if (params != NULL && fnmatch(params, tp->name, 0) != 0)
> + continue;
> +
> + rte_tel_data_add_dict_string(d, tp->name,
> + rte_trace_point_is_enabled(tp->handle) ? "Enabled" : "Disabled");
Could be changed to "Ena" and "Dis" or similar to reduce traffic on wire.
Also, it may be good to add a few text in
doc/guides/prog_guide/trace_lib.rst to tell this feature.
Acked-by: Jerin Jacob <jerinj@marvell.com>
next prev parent reply other threads:[~2022-10-13 14:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 7:49 David Marchand
2022-10-13 14:09 ` Jerin Jacob [this message]
2022-10-18 13:14 ` Bruce Richardson
2022-10-19 10:53 ` Bruce Richardson
2022-10-19 13:46 ` David Marchand
2022-10-18 14:33 ` Morten Brørup
2022-10-18 16:20 ` Bruce Richardson
2022-10-19 7:38 ` David Marchand
2022-10-19 8:21 ` Morten Brørup
2022-10-19 8:28 ` David Marchand
2022-10-25 9:00 ` [PATCH v3 0/4] Telemetry support for traces David Marchand
2022-10-25 9:00 ` [PATCH v3 1/4] telemetry: support boolean type David Marchand
2022-10-25 9:34 ` Mattias Rönnblom
2022-10-25 9:43 ` David Marchand
2022-10-25 10:38 ` Bruce Richardson
2022-10-27 8:53 ` Power, Ciara
2022-10-25 9:00 ` [PATCH v3 2/4] telemetry: extend valid command characters David Marchand
2022-10-25 9:12 ` Power, Ciara
2022-10-25 9:00 ` [PATCH v3 3/4] trace: enable trace operations via telemetry David Marchand
2022-10-25 10:18 ` Mattias Rönnblom
2022-10-25 9:00 ` [PATCH v3 4/4] trace: create new directory for each trace dump David Marchand
2022-10-25 9:41 ` Mattias Rönnblom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1NWw1G8uzV8LPSBFfJTR_TGPhDMjzpOtBp3izGivS3bpQ@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=bruce.richardson@intel.com \
--cc=ciara.power@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=skori@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).