From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 59FEFA0093; Thu, 13 Oct 2022 16:09:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 11AC042F7F; Thu, 13 Oct 2022 16:09:36 +0200 (CEST) Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by mails.dpdk.org (Postfix) with ESMTP id EBC0B42EAF for ; Thu, 13 Oct 2022 16:09:33 +0200 (CEST) Received: by mail-qt1-f176.google.com with SMTP id f22so1177539qto.3 for ; Thu, 13 Oct 2022 07:09:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ElUDBlMrkTdyaxVKmw1RlQYgApltGogQbGAp7h4bOqY=; b=XIh6+G7gsb/66uWjVTAKmhWWgKb9np/vth9cQU9z6Txftim/msGG2W68z26Ic6/97T JkIeu9x4gyfyRbl3jsBaI3/7MljkGGKjDDT4BXFw54UyAswJe8e5cMMgOcJoEbENB4Yz U+SfK8mbQJz/lNORn8CU/j3oT8SUBgSaSzJSdcuRqy2/XORY1dXsQweJZkTlHAt78vGy Ea0NKb5llJVmYSfketFb+shRzMHKD+KQxLLnvNIWWuxGEho4Qa/YUVE5A2IPbhS8n0fJ h8Hh343OOsJH5t8hktkIZO0smSrZg/kGtWU2cfeZUMMun1zo1P/xjjb2sWKcc7UoCu5B gy4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ElUDBlMrkTdyaxVKmw1RlQYgApltGogQbGAp7h4bOqY=; b=IaLoufZyDRErJj8RK48XU7c1S8Sywgm+SlN/iokq4d1KklbW1rsYZiD75dz3LG29+l y0li76iCPr/lousiwGkDnjHBHZRgleRhdoVfmB5XOO4ttt5WDexkOdnW+jo2Wl11sdyw mCoG9ifW2eI/RMOJGMnhtJPOQkJz2lY9n2L6tBhoPLLz3s3sqpDvOkw55ExOjzrcTRM/ BFxZC/iWAMbu6eXcBwtMCaa4qGFfWSiXKvSaOz8pvNVDYwdQBwOhyK7BmgNmOxwl6Py6 /ofT93H1UCkFIQUMhujLxqI0RoGSBbpU8swhRbytUpemWeYMO1ibiD2Eadgsj9fLIL3Z bXaQ== X-Gm-Message-State: ACrzQf0Z20BX5/7fZqR9Tup+nn9k357zFMnHLHURGTGIqvyV8O77l3og PtTWxnPV2nlbAds6GgdDrWRNPEetqYxIdR4i/1U= X-Google-Smtp-Source: AMsMyM7zgLdQXnqPP8SfrUozqs7hPYvHz5ZNvR6o+fbSq88eX98Tg89NriU4QwFoAYRyTQF/rx54/7ZDTZZdrrgYilc= X-Received: by 2002:a05:622a:588:b0:39c:d5d9:2cb4 with SMTP id c8-20020a05622a058800b0039cd5d92cb4mr614546qtb.191.1665670173268; Thu, 13 Oct 2022 07:09:33 -0700 (PDT) MIME-Version: 1.0 References: <20221013074928.3062458-1-david.marchand@redhat.com> In-Reply-To: <20221013074928.3062458-1-david.marchand@redhat.com> From: Jerin Jacob Date: Thu, 13 Oct 2022 19:39:07 +0530 Message-ID: Subject: Re: [PATCH] trace: take live traces via telemetry To: David Marchand Cc: dev@dpdk.org, bruce.richardson@intel.com, Jerin Jacob , Sunil Kumar Kori , Ciara Power Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Oct 13, 2022 at 1:20 PM David Marchand wrote: > I would suggest to change the subject as "trace: enable trace operations via telemetry" or so > Register telemetry commands to list and configure trace points and later > save traces for a running DPDK application. > > Note: trace point names contain a '.', so the list of valid characters > used in telemetry commands and dictionary keys has been extended. > > Example with testpmd running with two net/null ports (startup command > from devtools/test-null.sh): > > --> /trace/disable,* > {"/trace/disable": {"Count": 2}} > > Signed-off-by: David Marchand > +} > + > +static int > +trace_telemetry_list(const char *cmd __rte_unused, > + const char *params, struct rte_tel_data *d) > +{ > + struct trace_point *tp; > + > + rte_tel_data_start_dict(d); > + STAILQ_FOREACH(tp, &tp_list, next) { > + if (params != NULL && fnmatch(params, tp->name, 0) != 0) > + continue; > + > + rte_tel_data_add_dict_string(d, tp->name, > + rte_trace_point_is_enabled(tp->handle) ? "Enabled" : "Disabled"); Could be changed to "Ena" and "Dis" or similar to reduce traffic on wire. Also, it may be good to add a few text in doc/guides/prog_guide/trace_lib.rst to tell this feature. Acked-by: Jerin Jacob