From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77CD5A0C47; Mon, 20 Sep 2021 08:23:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E613E40DF7; Mon, 20 Sep 2021 08:23:37 +0200 (CEST) Received: from mail-il1-f172.google.com (mail-il1-f172.google.com [209.85.166.172]) by mails.dpdk.org (Postfix) with ESMTP id 3DE0440DF5 for ; Mon, 20 Sep 2021 08:23:37 +0200 (CEST) Received: by mail-il1-f172.google.com with SMTP id q14so17481004ils.5 for ; Sun, 19 Sep 2021 23:23:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=emRRUENbqiu5XUnltemgJ7mzM4oLypXPF9VGV1gqR2w=; b=GL1Y6r47P9082w+wU5YGx6EkPnyrrWrv8uA/JCjjJg3B7pyKSO6JEtLSB2PbJBrUQJ JvBO5O5JcO9dr3VoxFKkGwDB7oJ3/GZYuUWP5IpsvjVQDCLe/43gqjlTOhhJPoG4gSfc IOwHguxDaCVvCI8xIN6ku0M+Qr8BgXtuAVSaOSmWlslQwHlHWXhHegz3BbcsgtEgl+Qe /Z32fgtu3TcJLAbCGEsXHKuUIARcKThC+oRcae4o10cvArSI94udU54/mrsZWfmmNnJK YlwwFg8bWllkQ3uLLQkL05N//JXE1BbspLClrp3D2cVTFwK2cjJJKFdv5dNRPO5Q+UTA XI5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=emRRUENbqiu5XUnltemgJ7mzM4oLypXPF9VGV1gqR2w=; b=Kgdv9fRzBKQeBErajLv05NR9x2DPKBgEIfqgMdWFv4jQJJE+k+26eJDz1TuFl8HuYQ BUok6e2d7sJ7FR+tNWkOGjVCVLGaB8Mv2OIMAemDFcWKfFEXGjmWIeOeAprfIQLmXhus ++xQseMdAdFuxkbdWa02T+GC9DaeNl+kDWGYaQvq87BI10FzXtsHfZ8IMx9JDyKBio+f yVWv8BJM7rqhjnjugNP+MzKRVVJobKGif8r4wsDCW6BLpgmlVV3zQwQIVliiqknTAEiK gXaTVyXjCR2L8xym3h2+4SXXl6R3EfEvbAM2JoXsSfMCRIbPRR9kI9S6RtInp6VqcfQE FYZQ== X-Gm-Message-State: AOAM532oy8Gz3GyBljEe5Pq2jyyw75XagiTsNKaWMBjBtZaKkTUNMybx D4oapVgqmJfJ89sdSrUyecl3zjyeaiNcqUT5Pok= X-Google-Smtp-Source: ABdhPJyZ9lW5QzdQozafp/C4qtxp4zOmOrGIq4BO+FyUYDWtZQWUuDGwVTLD7LDGnvPqMNCm+AGJLLJO1ycULPhYp6g= X-Received: by 2002:a92:c548:: with SMTP id a8mr8894064ilj.295.1632119016448; Sun, 19 Sep 2021 23:23:36 -0700 (PDT) MIME-Version: 1.0 References: <20210918131140.3543317-1-s.v.naga.harish.k@intel.com> <20210918131140.3543317-3-s.v.naga.harish.k@intel.com> In-Reply-To: <20210918131140.3543317-3-s.v.naga.harish.k@intel.com> From: Jerin Jacob Date: Mon, 20 Sep 2021 11:53:10 +0530 Message-ID: To: Naga Harish K S V , Pavan Nikhilesh , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= Cc: Jerin Jacob , "Jayatheerthan, Jay" , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v1 3/5] eventdev:rx_adapter:add per queue event buffer configure support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Sep 18, 2021 at 6:42 PM Naga Harish K S V wrote: > > To configure per queue event buffer size, applications sets > ``rte_event_eth_rx_adapter_params::use_queue_event_buf`` flag > as true and is passed to `rte_event_eth_rx_adapter_create2` api. > > The per queue event buffer size is populated in > ``rte_event_eth_rx_adapter_queue_conf::event_buf_size`` and passed > to ``rte_event_eth_rx_adapter_queue_add``. > > Signed-off-by: Naga Harish K S V Please change the subject to eventdev/rx_adapter: ... rest looks good to me. > --- > .../prog_guide/event_ethernet_rx_adapter.rst | 19 ++++++++++++------- > lib/eventdev/rte_event_eth_rx_adapter.h | 4 ++++ > 2 files changed, 16 insertions(+), 7 deletions(-) > > diff --git a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst > index cbf694c66b..55d09dbcb8 100644 > --- a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst > +++ b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst > @@ -62,12 +62,14 @@ service function and needs to create an event port for it. The callback is > expected to fill the ``struct rte_event_eth_rx_adapter_conf structure`` > passed to it. > > -If the application desires to control the event buffer size, it can use the > -``rte_event_eth_rx_adapter_create2()`` api. The event buffer size is > -specified using ``struct rte_event_eth_rx_adapter_params::event_buf_size``. > -The function is passed the event device to be associated with the adapter > -and port configuration for the adapter to setup an event port if the > -adapter needs to use a service function. > +If the application desires to control the event buffer size at adapter level, > +it can use the ``rte_event_eth_rx_adapter_create2()`` api. The event buffer size > +is specified using ``struct rte_event_eth_rx_adapter_params::event_buf_size``. > +To configure the event buffer size at queue level, the boolean flag > +``struct rte_event_eth_rx_adapter_params::use_queue_event_buf`` need to be > +set to true. The function is passed the event device to be associated with > +the adapter and port configuration for the adapter to setup an event port > +if the adapter needs to use a service function. > > Adding Rx Queues to the Adapter Instance > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > @@ -79,7 +81,9 @@ parameter. Event information for packets from this Rx queue is encoded in the > ``ev`` field of ``struct rte_event_eth_rx_adapter_queue_conf``. The > servicing_weight member of the struct rte_event_eth_rx_adapter_queue_conf > is the relative polling frequency of the Rx queue and is applicable when the > -adapter uses a service core function. > +adapter uses a service core function. The applications can configure queue > +event buffer size in ``struct rte_event_eth_rx_adapter_queue_conf::event_buf_size`` > +parameter. > > .. code-block:: c > > @@ -90,6 +94,7 @@ adapter uses a service core function. > queue_config.rx_queue_flags = 0; > queue_config.ev = ev; > queue_config.servicing_weight = 1; > + queue_config.event_buf_size = 1024; > > err = rte_event_eth_rx_adapter_queue_add(id, > eth_dev_id, > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.h b/lib/eventdev/rte_event_eth_rx_adapter.h > index a1b5e0ed37..f9e63dc126 100644 > --- a/lib/eventdev/rte_event_eth_rx_adapter.h > +++ b/lib/eventdev/rte_event_eth_rx_adapter.h > @@ -199,6 +199,8 @@ struct rte_event_eth_rx_adapter_queue_conf { > * Valid when RTE_EVENT_ETH_RX_ADAPTER_QUEUE_EVENT_VECTOR flag is set in > * @see rte_event_eth_rx_adapter_queue_conf::rx_queue_flags. > */ > + uint16_t event_buf_size; > + /**< event buffer size for this queue */ > }; > > /** > @@ -263,6 +265,8 @@ struct rte_event_eth_rx_adapter_vector_limits { > struct rte_event_eth_rx_adapter_params { > uint16_t event_buf_size; > /**< size of event buffer for the adapter */ > + bool use_queue_event_buf; > + /**< flag to indicate that event buffer is separate for each queue */ > }; > > /** > -- > 2.25.1 >