From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5E48A051A; Fri, 17 Jan 2020 10:55:25 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7B2F21D404; Fri, 17 Jan 2020 10:55:25 +0100 (CET) Received: from mail-il1-f195.google.com (mail-il1-f195.google.com [209.85.166.195]) by dpdk.org (Postfix) with ESMTP id 04FAF1D162; Fri, 17 Jan 2020 10:55:24 +0100 (CET) Received: by mail-il1-f195.google.com with SMTP id x5so20813122ila.6; Fri, 17 Jan 2020 01:55:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=n2JAr73tS5krae/55fbIuquZWcTDiYkmdvgReiahFMg=; b=BYWPyZFRNu2kaLL6PGznPqwocbxLBZ9otnrbgw7Yg5AH939SWpi1eq6F3RMJRymgG3 ytdnCiiA/UMPSgCWfz0O9npQEisJIsU4vNMDmPPfWVeyETYXQk0KUNxyxIBrKnE1DVAz 7h5fYndiQZJafIYAzQBkFzexQFRtTMdS4gB0k2ALd3N6qVSRv/ivDDZ4GYelmUwpFSLu h6PDatHb8Yc+OuCe9R74L2Y1QeRuGitfVCgjbQUPz2NG1RoYAtN0xzLzFxjFwid/KyQK O90fmFpJomtvhGBkNpganbaH5T106SY7yIXWYpPJ8jXtnI/Om6RG23Luh0v0noLao6TC 3/qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=n2JAr73tS5krae/55fbIuquZWcTDiYkmdvgReiahFMg=; b=bvhJIn4Y3iMYagVtpooSYhHF/tmQo7rGQ+nNOch2ZcNNXIL7KVvJ6NIQlaHeTRRZ+X DAp2eejaFdg3HapGa3azXcq/vvuaNbnXRSZOq7Ptlvxgxlb4kgesNrUsAYVVOktc98Vv fZJz9+2aiFEcndb0WXmPRB6q5PM6DiWQcY7wTHhJfLhHHwfy3tKYO7ca/QfpDqdm5fd4 j/tmzy/zR8l+fXEnzr70nBvmF1w1gDwIFliocgGayQKYB6omWeiOBKJiyqRyrwnTrELa rP+vRp6p0cj7HjG3W3Oj8wqWaoPT1SMisXDhtiRqD6QxkdGwrzFAfHPqI08HKpmdxV+N 2xMw== X-Gm-Message-State: APjAAAUAJcJPbfsD+OqEc8f7EWU5YA4K9Pwt3ngB7/jN167Xk7D02uAx ouIdvrkgSUkwJUT/DwrNaBHFdNbz7MICb5JxR2Y= X-Google-Smtp-Source: APXvYqzddjXr+gUBpk3ES82pG7DkqwLKwOCysm4aYHRaxu1M0jKA+v+LOCmUlgAC5vOLxt5Z9u7QzMPkJ19A4+XCOsQ= X-Received: by 2002:a92:481d:: with SMTP id v29mr2257769ila.271.1579254923369; Fri, 17 Jan 2020 01:55:23 -0800 (PST) MIME-Version: 1.0 References: <20191212131302.1626130-1-jerinj@marvell.com> <898e1731-4921-721b-0e42-ada50ab2bf94@redhat.com> In-Reply-To: From: Jerin Jacob Date: Fri, 17 Jan 2020 15:25:07 +0530 Message-ID: To: Maxime Coquelin Cc: Jerin Jacob , dpdk-dev , Thomas Monjalon , techboard@dpdk.org, "Richardson, Bruce" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-techboard] [PATCH] config: disable all kmods by default from v20.02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jan 17, 2020 at 1:59 PM Maxime Coquelin wrote: > > > > On 1/16/20 7:43 PM, Jerin Jacob wrote: > > On Fri, Jan 17, 2020 at 12:04 AM Maxime Coquelin > > wrote: > >> > >> > >> > >> On 1/16/20 2:11 PM, Jerin Jacob wrote: > >>> Ping. > >>> > >>> On Thu, Dec 12, 2019 at 6:42 PM wrote: > >>>> > >>>> From: Jerin Jacob > >>>> > >>>> Based on the techboard meeting held on 2019-11-06, > >>>> It's been decided to disable all kmods by default from v20.02. > >>>> > >>>> http://mails.dpdk.org/archives/dev/2019-November/151763.html > >>>> > >>>> Signed-off-by: Jerin Jacob > >>>> --- > >>>> config/common_linux | 2 -- > >>>> 1 file changed, 2 deletions(-) > >>>> > >>>> diff --git a/config/common_linux b/config/common_linux > >>>> index c5cf3d662..583efadc7 100644 > >>>> --- a/config/common_linux > >>>> +++ b/config/common_linux > >>>> @@ -8,9 +8,7 @@ CONFIG_RTE_EXEC_ENV_LINUX=y > >>>> CONFIG_RTE_EXEC_ENV_LINUXAPP=y > >>>> > >>>> CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y > >>>> -CONFIG_RTE_EAL_IGB_UIO=y > >>>> CONFIG_RTE_EAL_VFIO=y > >>>> -CONFIG_RTE_KNI_KMOD=y > >>>> CONFIG_RTE_LIBRTE_KNI=y > >>>> CONFIG_RTE_LIBRTE_PMD_KNI=y > >>>> CONFIG_RTE_LIBRTE_VHOST=y > >>>> -- > >>>> 2.24.0 > >>>> > >>> > >> > >> Looks good for make build system, but what about Meson? > >> as per meson_options.txt, isn't it enabled by default? > >> $ grep -rn enable_kmods meson_options.txt > >> 7:option('enable_kmods', type: 'boolean', value: true, > > > > + Bruce, > > > > Since meson autodetect the presence of Linux kernel dependency for the > > kmod build, > > I thought of keeping as it is as there is no harm. I am fine with > > either way, let me the > > know the feedback, I will send the v2 based on the comment. > > Actually, it would defeat the main reason I pushed for the kmods to be > disabled by default. Indeed, even if the kernel dependencies are > installed, build can break if internal kernel API changes, e.g.: Agree. I will send the next version with disabling kmod in meson by default. > commit c128a4e6317d49362e2158edc29887c844067c65 > Author: David Zeng > Date: Sat Dec 22 00:27:33 2018 +0800 > > kni: fix build on RHEL8 for arm and Power9 > > [ upstream commit 3d5501d568aacbcf71832691278f5656d3a9b649 ] > > Signed-off-by: David Zeng > Acked-by: Ferruh Yigit >