From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 999B1A04A6; Mon, 24 Jan 2022 10:05:11 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1FF2440DF6; Mon, 24 Jan 2022 10:05:11 +0100 (CET) Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) by mails.dpdk.org (Postfix) with ESMTP id C4F0D40040 for ; Mon, 24 Jan 2022 10:05:09 +0100 (CET) Received: by mail-io1-f49.google.com with SMTP id a12so18617124iod.9 for ; Mon, 24 Jan 2022 01:05:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=c1ZZk1YtgnhPoZaASCHLIALkfCRo33cZb7Y8GzApX0Q=; b=F5dTrO6lwMM0BwKXJimLc/aR0W3WrBoWmD0+2rTdpqqH0ir6jT+2EUAD2zbw2/m1WD f/wLSvMdxlVYsAuCWq11yWZMA74aB03KcTHoOhjPZgfDS49ORahpKDP1nspdPdrH3Dhf ISyHOFC5JtCyne8pA0Cv9zdg/w3lWt3M98B0+pKSFWhjoJ68zJiYol+/siUd637vpdXG vJYYGAY+p6kf83pV+RBWgGKZLEdJs7Eq6eGofM+FakG+PNbldHYQ0sUAy7k73Jm1+4P3 RedIK8CSRHy4AGj9p8cD38RxA+tyha/MOOKWMk1lvT//9G2qY8VWIkY6N2d3Z4LBlA3e qZfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=c1ZZk1YtgnhPoZaASCHLIALkfCRo33cZb7Y8GzApX0Q=; b=wFK3ojvVbaBrSkCl665Hcr3fa8GRbZcDGmc/hTJgdUnSb4W1fOzJMvantJHRjKko+Y HBmhtll4dsM/AoaCQz+Ds8i3Qsb3/2+IFkqSJ/9wSu5n5CY4OUoGytBVlgsf9bqu/71w SR0ulCq7VarPTVxToW0/wejnCXu5x2epOCsSmwcFu9W1Knd7+hmis93v7RhRksH52FVM prAJmpdMANgT5aYDo5CMiFdWLue5miXmdLzeercNJfhRWJ4TE0E0Z1iJ22w1mE1rJQ5s PuzMGSM3TzSNFRzkgSBFCX/AgkM9Y4187iNqawbZ9jhjQlFSppt+x6360gqESdCOfzcz LSLg== X-Gm-Message-State: AOAM531VXkG3mOvjTs9TKq/N8gHmCr+F3DT/2vFVqvcXttLnwzeEQRur vlSXzMmB6u768f96l9Q9cSqyAKSZ5gZNdpS+VD8= X-Google-Smtp-Source: ABdhPJzzeBX8YFpZb/wsNZOQ2rryN1ajzXbWXjc5fFdMx74ApNqrCFY9m1qgIv7jTLjuy6JIKt2K+MWrgl+A5guXe3Q= X-Received: by 2002:a02:bb87:: with SMTP id g7mr6352483jan.79.1643015108930; Mon, 24 Jan 2022 01:05:08 -0800 (PST) MIME-Version: 1.0 References: <20211213204140.5255-1-pbhagavatula@marvell.com> In-Reply-To: <20211213204140.5255-1-pbhagavatula@marvell.com> From: Jerin Jacob Date: Mon, 24 Jan 2022 14:34:42 +0530 Message-ID: Subject: Re: [PATCH] event/cnxk: fix qos devargs parsing To: Pavan Nikhilesh Cc: Jerin Jacob , Shijith Thotton , dpdk-dev Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Dec 14, 2021 at 2:11 AM wrote: > > From: Pavan Nikhilesh > > Fix qos devargs parsing using incorrect datatype for the > structure elements. > > Fixes: 38c2e3240ba8 ("event/cnxk: add option to control SSO HWGRP QoS") Cc: stable@dpdk.org > > Signed-off-by: Pavan Nikhilesh Applied to dpdk-next-net-eventdev/for-main. Thanks > --- > drivers/event/cnxk/cnxk_eventdev.c | 2 +- > drivers/event/cnxk/cnxk_eventdev.h | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/event/cnxk/cnxk_eventdev.c b/drivers/event/cnxk/cnxk_eventdev.c > index f7a5026250..6ad4e23e2b 100644 > --- a/drivers/event/cnxk/cnxk_eventdev.c > +++ b/drivers/event/cnxk/cnxk_eventdev.c > @@ -482,7 +482,7 @@ static void > parse_queue_param(char *value, void *opaque) > { > struct cnxk_sso_qos queue_qos = {0}; > - uint8_t *val = (uint8_t *)&queue_qos; > + uint16_t *val = (uint16_t *)&queue_qos; > struct cnxk_sso_evdev *dev = opaque; > char *tok = strtok(value, "-"); > struct cnxk_sso_qos *old_ptr; > diff --git a/drivers/event/cnxk/cnxk_eventdev.h b/drivers/event/cnxk/cnxk_eventdev.h > index 305c6a3b9e..4652b58a84 100644 > --- a/drivers/event/cnxk/cnxk_eventdev.h > +++ b/drivers/event/cnxk/cnxk_eventdev.h > @@ -74,9 +74,9 @@ typedef void (*cnxk_sso_hws_flush_t)(void *ws, uint8_t queue_id, uintptr_t base, > > struct cnxk_sso_qos { > uint16_t queue; > - uint8_t xaq_prcnt; > - uint8_t taq_prcnt; > - uint8_t iaq_prcnt; > + uint16_t xaq_prcnt; > + uint16_t taq_prcnt; > + uint16_t iaq_prcnt; > }; > > struct cnxk_sso_evdev { > -- > 2.17.1 >