From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81D7441C2C; Tue, 7 Feb 2023 08:17:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6FA9E42D0C; Tue, 7 Feb 2023 08:17:49 +0100 (CET) Received: from mail-vs1-f46.google.com (mail-vs1-f46.google.com [209.85.217.46]) by mails.dpdk.org (Postfix) with ESMTP id 0BE2940EF0; Tue, 7 Feb 2023 08:17:48 +0100 (CET) Received: by mail-vs1-f46.google.com with SMTP id a24so15330161vsl.2; Mon, 06 Feb 2023 23:17:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=PsDY2ThVO1fv+o2MdCJPxtYVANb0vaN6lnP7C4jrGQ8=; b=ls5MEdvNJMyM74NWbwceiGVhEMk3JEgl+qDIUnWR3kQSjZR84twS01ianYLYxT16as pMM6wTcT9hLDxcYDNSF2KicCglLxMmefoOq1G/PE2JzFF1P+8Ie0Lxj/+fqFcaZovZa0 YKFI9H0SKZAh4LAqgY1q2GDrQgkz/qqQGsMaPS3BuXqzOLGsrjBYwympicItClnyeund Qs/S+i9tvvmziFbqUCZxOTd/eKXC5ojkSrk5qZx0+hy6W7UwdTe3TiaxIdpq888lKy9p URwLodbBmrLyZTFTmICkstzSzCNPHRQnaVFmBYUND6qrjqFVpaMMdEokDVLaAo8ZsbWA Ljaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PsDY2ThVO1fv+o2MdCJPxtYVANb0vaN6lnP7C4jrGQ8=; b=ZRQUKBzjHbvoLQuN/od6bG4ND+RLAY3cy4qMT1sAtZH1gG6gEwS+FjKGUtF+vmNJ7w WzeSStuVi6FuPfIv35dlugiLB16JBXGkc/CbG7KqXjcjGYoj2NtVhB9KIO9oSYpuUYGf pUrijXKqZZqF3w/xGjO7Yq+0ZoyoQSfFrxPT0dm6cgsFrogOmVyTEPL5TWa3LrXJHNWd eX9qxmlWr2HaTQtroXHZffzWBszdOSurQ4TYzTwLDmBYDIDNrhAU/b82OJMg0MvcB+gE +cAOYNNTdMVZJOtQwNCn9FVkSGxyZqgB0tdJwRVPNP9FyadOjZJlnGBj8oOKat7b1m8W 96Zg== X-Gm-Message-State: AO0yUKWd0hTVuU2goV5HkCmSkj6PCkU/Ig3h9sy1E1fOuA6TH9uOhl+8 C9VN/EyD4sg+xlny3Tx4IvpVvW34/XdliuRB7Fw= X-Google-Smtp-Source: AK7set9zUoeE5jYPuZ/lZaKU6QjflGAlfY7Bl3FItap6i7myOtoUoQ+K1AY3DWUBiBV22w4DWychvt3dWG+ty7OU0rk= X-Received: by 2002:a67:ca83:0:b0:3fa:5334:55bd with SMTP id a3-20020a67ca83000000b003fa533455bdmr516365vsl.31.1675754267380; Mon, 06 Feb 2023 23:17:47 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Jerin Jacob Date: Tue, 7 Feb 2023 12:47:21 +0530 Message-ID: Subject: Re: [PATCH] eventdev/eth_rx: fix return of rx adapter instance get To: Shijith Thotton Cc: ganapati.kundapura@intel.com, jerinj@marvell.com, pbhagavatula@marvell.com, dev@dpdk.org, stable@dpdk.org, Naga Harish K S V Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jan 3, 2023 at 6:39 PM Shijith Thotton wrote: > > The API to get rx adapter instance is returning error for event devices > with internal port capability and eth_rx_adapter_instance_get op > undefined. But as the Rx adapter is internally maintaining the queue > information needed to find the instance id, event devices can opt out > from defining the op. Modified code to match this logic. > > Fixes: a1793ee8aba0 ("eventdev/eth_rx: add adapter instance get API") > > Signed-off-by: Shijith Thotton Updated the git commit as follows and applied to dpdk-next-net-eventdev/for-main. Thanks eventdev/eth_rx: fix return adapter instance get The API to get rx adapter instance is returning error for event devices with internal port capability and eth_rx_adapter_instance_get op undefined. But as the Rx adapter is internally maintaining the queue information needed to find the instance id, event devices can opt out from defining the op. Modified code to match this logic. Fixes: a1793ee8aba0 ("eventdev/eth_rx: add adapter instance get API") Cc: stable@dpdk.org Signed-off-by: Shijith Thotton > --- > lib/eventdev/rte_event_eth_rx_adapter.c | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c > index cf7bbd4d69..170823a03c 100644 > --- a/lib/eventdev/rte_event_eth_rx_adapter.c > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c > @@ -3415,14 +3415,10 @@ rte_event_eth_rx_adapter_instance_get(uint16_t eth_dev_id, > if (!rte_event_eth_rx_adapter_caps_get(rx_adapter->eventdev_id, > eth_dev_id, > &caps)) { > - if (caps & RTE_EVENT_ETH_RX_ADAPTER_CAP_INTERNAL_PORT) { > - ret = rxa_dev_instance_get(rx_adapter) ? > - rxa_dev_instance_get(rx_adapter) > - (eth_dev_id, > - rx_queue_id, > - rxa_inst_id) > - : -EINVAL; > - } > + if (caps & RTE_EVENT_ETH_RX_ADAPTER_CAP_INTERNAL_PORT && > + rxa_dev_instance_get(rx_adapter)) > + ret = rxa_dev_instance_get(rx_adapter)(eth_dev_id, rx_queue_id, > + rxa_inst_id); > } > > /* return if entry found */ > -- > 2.25.1 >