Re: [PATCH] doc: add deprecation notice for inconsistent socket_id types

[Jerin Jacob <jerinjacobk@gmail.com>]

On Fri, Oct 14, 2022 at 1:39 PM Markus Theil <markus.theil@tu-ilmenau.de> wrote:
>
> DPDK uses many different types for socket_id's in its whole code
> base. This leads to many warnings and casts in DPDK-based applications
> compiled with -Wconversion.
>
> Announce a treewide consolidation to the return type of rte_socket_id
> in DPDK 23.11.
> Signed-off-by: Markus Theil <markus.theil@tu-ilmenau.de>

Acked-by: Jerin Jacob <jerinj@marvell.com>


> ---
>  doc/guides/rel_notes/deprecation.rst | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 05cacb3ea8..7f4c468542 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -96,3 +96,10 @@ Deprecation Notices
>    to have another parameter ``qp_id`` to return the queue pair ID
>    which got error interrupt to the application,
>    so that application can reset that particular queue pair.
> +
> +* eal/treewide: currently socket_id's use many different data types
> +  throughout the codebase. This complicates compiling DPDK-based
> +  applications with enabled -Wconversion. Fix this, by changing
> +  all occurences to the return type of rte_socket_id().
> +  DPDK 23.11 should receive a batch cleanup to a single, consistent
> +  data type.
> --
> 2.38.0
>