From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD271A00C2; Fri, 14 Oct 2022 12:43:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 72CC342D26; Fri, 14 Oct 2022 12:43:31 +0200 (CEST) Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) by mails.dpdk.org (Postfix) with ESMTP id 9048442CF8 for ; Fri, 14 Oct 2022 12:43:29 +0200 (CEST) Received: by mail-qv1-f47.google.com with SMTP id mg6so2954551qvb.10 for ; Fri, 14 Oct 2022 03:43:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=hyP3T/a/JAMay+aPHOF1u/BuS04Wca+N8Kepz/GYPds=; b=itrSsjukdZiHYELkeRm0gzwH2ujsgTKmnJgmFsz8qqlroXPm//tHta8PBRcWTeRCao RzkQpODNlkVN0zKKtZfeRzZE3PtlLXbyP9OLiAmXgdMu4HepALY/SbPbajV8KHwylv4q hg8QBTL4mPssqbKZ0lZOz1d6TJfUJe+doF7TmXO4XQQpIJhmD36McI7zPfiAvyD9jKhK nZucfoSjxxCTenZ/UHKW5pZ/rEhY53m5r3JQpJ6GDZA7EXcWkfdWWBmVaHVhV54btHYb UW1LpJ2bb+2GWa9E2Q5kuPu36acAUwhoH/5kqwdl5EQRRg6fIY/EkiNGVwsHRlrupChz kuug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hyP3T/a/JAMay+aPHOF1u/BuS04Wca+N8Kepz/GYPds=; b=o0zjQtQJBXWPIHdFhjiTsWmdBUyUz0bjUFTlnxhOL3JzNIEuw7YgqKx/oZtnaHAHJj cKmk9rCGFcuFGkSjkg5v7ZnCWb1GR/WFFgnsIy49ueXf/xxbhOTTfxykBhfxEwvlYcd/ Frhje7W8C/8uR9/keDsrQlDKk8Ohj01/dImPAYCvGwDLMsAwczv6FZQIu+BljQWwZaWZ BknmTqqpkkf6FEwrsNIaXyTXs4WAj1Y4mYZJIpGCRtREiRskhZWgc8eRrmx0xPdRgPj7 xhl7oZgLGn8OfRgj5iJk+U/ZgiuDs0Lanp3h2CdATlnc7YCTgX3FReE4bfY07EiRnGtY 2Biw== X-Gm-Message-State: ACrzQf1XKwJK8p2kfNrIwjVdNBOtDOLvVCPtWJ74/1Z+rAFx0aLYiBGO cA8g6MnWSCbnp80Giv6LcALLNJbM/h0NRa+Y4rk= X-Google-Smtp-Source: AMsMyM6ullTZ5rEXgCsfU4pX6u3qXC8XgcQmTl3dcQ5MrtKiF8QLxICX8MVmPMLovu9l7NyU+4UKVQ+2Jbs/QrzJMjI= X-Received: by 2002:a05:6214:e49:b0:4b3:f24e:91ac with SMTP id o9-20020a0562140e4900b004b3f24e91acmr3218503qvc.41.1665744208984; Fri, 14 Oct 2022 03:43:28 -0700 (PDT) MIME-Version: 1.0 References: <20221014080944.10992-1-markus.theil@tu-ilmenau.de> In-Reply-To: <20221014080944.10992-1-markus.theil@tu-ilmenau.de> From: Jerin Jacob Date: Fri, 14 Oct 2022 16:13:02 +0530 Message-ID: Subject: Re: [PATCH] doc: add deprecation notice for inconsistent socket_id types To: Markus Theil Cc: dev@dpdk.org, Ferruh Yigit Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Oct 14, 2022 at 1:39 PM Markus Theil wrote: > > DPDK uses many different types for socket_id's in its whole code > base. This leads to many warnings and casts in DPDK-based applications > compiled with -Wconversion. > > Announce a treewide consolidation to the return type of rte_socket_id > in DPDK 23.11. > Signed-off-by: Markus Theil Acked-by: Jerin Jacob > --- > doc/guides/rel_notes/deprecation.rst | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index 05cacb3ea8..7f4c468542 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -96,3 +96,10 @@ Deprecation Notices > to have another parameter ``qp_id`` to return the queue pair ID > which got error interrupt to the application, > so that application can reset that particular queue pair. > + > +* eal/treewide: currently socket_id's use many different data types > + throughout the codebase. This complicates compiling DPDK-based > + applications with enabled -Wconversion. Fix this, by changing > + all occurences to the return type of rte_socket_id(). > + DPDK 23.11 should receive a batch cleanup to a single, consistent > + data type. > -- > 2.38.0 >