From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 03EF8A034F; Sun, 6 Jun 2021 19:56:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7ABD840040; Sun, 6 Jun 2021 19:56:55 +0200 (CEST) Received: from mail-il1-f170.google.com (mail-il1-f170.google.com [209.85.166.170]) by mails.dpdk.org (Postfix) with ESMTP id 83C8F4003F for ; Sun, 6 Jun 2021 19:56:54 +0200 (CEST) Received: by mail-il1-f170.google.com with SMTP id z1so14040125ils.0 for ; Sun, 06 Jun 2021 10:56:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BQUxiN/vJ4d5CapeNp3VknuzYt8aW7ft8zSxdfbfVmo=; b=ftHjfQscYEG9h0f82ubjU/T8FdNgLjzLDHuhqElaJeIqRUrH+d0E+F+UnJQEAKembm UGUpARbxZHAXflqKzfYFaA6WuzeFBW/xr5s8oU+vQO+S6NUMSy41kq+5I/P9U66P9Bav P/SOBBq7djT+c/aiyRE9iITJP4nVwB30/9fEZgBgxMgVYMY4OMa4QyRqGEp12l3pABsg L/tAuSIgBrnB6uj/fwouzZktpwPfKLukbKUkLAGaZM1GfOfxZ7EVN3riq4t7pnGqsnPf wm60YMTXqGNE061ToOJCHCZ34/LUw/3rg8gJQ+VEqQlsbgZbwqUmt0GHtiTU67WozKkq kQUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BQUxiN/vJ4d5CapeNp3VknuzYt8aW7ft8zSxdfbfVmo=; b=QFm1MUEKf/IhiOZZS7dvhu0u0AJm55VHE8QNNsfNcu/jyrgzbkD9JBagkLLo6UDf9Y bAs6DETksLyhO6B6qMoU4dFxdyWra/y4WxVB/MwdK1sGTdcsbEsXrS1CyG3WzhrnTj/a 7bJC5pHcmxbshbvl5wrGfg+WwL438RuRgwHxpIEsCNpRlrY3b4kCLLzU2hvYOetER9Mb kGvHdU/vDCpuyWnq+OHswOMy0xd4jK9zKLqxfkyv/9OP25zOOx8i8fUgxZzaCTgv23UY aIC/88g/iJywswcyZYTWSIRU8U2gOlSs9mvsyi3rT2BnewEu+sEQdlA2wEbk2PjSx0nk pO/A== X-Gm-Message-State: AOAM533flooghxRK997yXxTK4ucT16tmOIg4eS/V5oE/+tRNcFYHE/TR 8UQ4+6/UEsltZVkSI7qZjoLskreElHuuHqBZLJU= X-Google-Smtp-Source: ABdhPJyoR5m2BvRv4Iihv0Rwvtt1GaBdxZnge3Iaw1zV4YKAz2H/jKwIbr6SZohTCPcO6RGUBXaHEN5etdtrgcjt4Co= X-Received: by 2002:a92:1310:: with SMTP id 16mr12965765ilt.60.1623002213778; Sun, 06 Jun 2021 10:56:53 -0700 (PDT) MIME-Version: 1.0 References: <20210604114752.412856-1-michael.pfeiffer@tu-ilmenau.de> In-Reply-To: <20210604114752.412856-1-michael.pfeiffer@tu-ilmenau.de> From: Jerin Jacob Date: Sun, 6 Jun 2021 23:26:37 +0530 Message-ID: To: Michael Pfeiffer , "Richardson, Bruce" Cc: Jan Viktorin , Ruifeng Wang , Jerin Jacob , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eal: add include for rte_byteorder on ARM X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jun 4, 2021 at 5:18 PM Michael Pfeiffer wrote: > > Including rte_byteorder.h may fail for ARM builds with 'Platform must > be built with RTE_FORCE_INTRINSICS' if rte_config.h is not included > before. Include rte_config.h from rte_byteorder.h to solve the issue. > > Signed-off-by: Michael Pfeiffer Since -include rte_config.h added by meson, This issue is not coming with in tree build. IMO, Fix is correct. Please send v2 with - Add Fixes: tag and Cc: stable@dpdk.org so that i can be backported to stable tree. - Fix following checkformat.sh warning Wrong headline format: eal: add include for rte_byteorder on ARM Wrong headline case: "eal: add include for rte_byteorder on ARM": ARM --> Arm - Subject could be "eal: arm: fix out of tree build" or so. With above change: Acked-by: Jerin Jacob > --- > lib/eal/arm/include/rte_byteorder.h | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/lib/eal/arm/include/rte_byteorder.h b/lib/eal/arm/include/rte_byteorder.h > index df2f1d87ba..1f90db9943 100644 > --- a/lib/eal/arm/include/rte_byteorder.h > +++ b/lib/eal/arm/include/rte_byteorder.h > @@ -5,18 +5,19 @@ > #ifndef _RTE_BYTEORDER_ARM_H_ > #define _RTE_BYTEORDER_ARM_H_ > > -#ifndef RTE_FORCE_INTRINSICS > -# error Platform must be built with RTE_FORCE_INTRINSICS > -#endif > - > #ifdef __cplusplus > extern "C" { > #endif > > #include > #include > +#include > #include "generic/rte_byteorder.h" > > +#ifndef RTE_FORCE_INTRINSICS > +# error Platform must be built with RTE_FORCE_INTRINSICS > +#endif > + > /* fix missing __builtin_bswap16 for gcc older then 4.8 */ > #if !(__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 8)) > > -- > 2.31.1 >