From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC260A0577; Mon, 6 Apr 2020 15:20:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F06EC2B96; Mon, 6 Apr 2020 15:20:35 +0200 (CEST) Received: from mail-il1-f194.google.com (mail-il1-f194.google.com [209.85.166.194]) by dpdk.org (Postfix) with ESMTP id 054A2F12 for ; Mon, 6 Apr 2020 15:20:33 +0200 (CEST) Received: by mail-il1-f194.google.com with SMTP id p13so14580717ilp.3 for ; Mon, 06 Apr 2020 06:20:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=g5rVUztJtMDrAXR9WWqGzWfaskKPPlqvtJMv2eCGMjw=; b=U2WEy2gqxqUMcB9qKSs7Wq+6vabFyYFPpdLmBJzKrpZW4qUaGRk4J6bzNaJwd4qX9q 3rzs7UGJq0VWW1B3m1zqHdhdfy3u9EG66836hsBaY05jZOwAPJWyhUg+K+jQJ2d75Lje tOJw8ruh+okdgoGl9gwDkFnr2ZzvHAMEEuqLr2uskJFwawTX8ISCBky/tysEU2eEspKq xDA4F3fgB7hV2jWZfwDxTz322alfqHBUXMgShOpDNooxSpMcQghcQMG9PCMcwzV/vPSN ulizTG3sGNGUHE56FqHtXxOPkyIb5RppjS4RZXb+TfzfAsYoofIyykiVhQVLUstPAt6r bWiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g5rVUztJtMDrAXR9WWqGzWfaskKPPlqvtJMv2eCGMjw=; b=Zic7aO17smtNdwhGMwMWMdfHEoby0x8cObmbXB3hyPnGiCB81deWXu0w9plA0iIskq 6DRsJ3j8KPWo3ldnBRozROWAqRnkg5rV9E7ai69rBZifmc4qWlIyhmcQGvNqVud6+8Wa zicDUZz7beqJuNnG3DkKCtEeOCX4A9gBC7MgmVqbypVHHMGqhT/z2igoP9pTFGuiU/y2 aGmfsYgdakA7CcXJxSk6tD3uAevUjOx3GlghDsZJd3gm7949g3mtbyjjlVLH/Loj/Tgo 0V5cMVlhTCzAVZXjBGjds7GG+5wpI+OkAx7w+XlenU/7fVVZbkOSsSpUWwI+gGUs13Si ns3g== X-Gm-Message-State: AGi0PubcIRPOQRGl7yM+0SHITkp7TK+1rpY0U5l62Aa/LYLDPGOaWBUX ismlIuUHSYEwbHI06eXQzf78o7chFPQHN491r64= X-Google-Smtp-Source: APiQypIoFLP3gxfzRabEEN4lPDO9ndQe1Pl4tdmxfmFmSVcuA5ncHCjD4sEdg9HGk2zkC/mHrLM6jwhq6M8rx/OyW0k= X-Received: by 2002:a92:48cb:: with SMTP id j72mr21097524ilg.162.1586179233084; Mon, 06 Apr 2020 06:20:33 -0700 (PDT) MIME-Version: 1.0 References: <1585464438-111285-1-git-send-email-orika@mellanox.com> <2875521.ySyUEvhnHf@xps> <5151953.QU4070AmJz@xps> In-Reply-To: <5151953.QU4070AmJz@xps> From: Jerin Jacob Date: Mon, 6 Apr 2020 18:50:16 +0530 Message-ID: To: Thomas Monjalon Cc: Pavan Nikhilesh Bhagavatula , Ori Kam , Jerin Jacob Kollanukkaran , "xiang.w.wang@intel.com" , "dev@dpdk.org" , Shahaf Shuler , "hemant.agrawal@nxp.com" , Opher Reviv , Alex Rosenbaum , Dovrat Zifroni , Prasun Kapoor , "nipun.gupta@nxp.com" , "bruce.richardson@intel.com" , "yang.a.hong@intel.com" , "harry.chang@intel.com" , "gu.jian1@zte.com.cn" , "shanjiangh@chinatelecom.cn" , "zhangy.yun@chinatelecom.cn" , "lixingfu@huachentel.com" , "wushuai@inspur.com" , "yuyingxia@yxlink.com" , "fanchenggang@sunyainfo.com" , "davidfgao@tencent.com" , "liuzhong1@chinaunicom.cn" , "zhaoyong11@huawei.com" , "oc@yunify.com" , "jim@netgate.com" , "hongjun.ni@intel.com" , "j.bromhead@titan-ic.com" , "deri@ntop.org" , "fc@napatech.com" , "arthur.su@lionic.com" , "david.marchand@redhat.com" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [EXT] [PATCH v1 4/4] regexdev: implement regex rte level functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Apr 6, 2020 at 6:44 PM Thomas Monjalon wrote: > > 06/04/2020 14:33, Pavan Nikhilesh Bhagavatula: > > >> From: Pavan Nikhilesh Bhagavatula > > >> > >+uint16_t > > >> > >+rte_regexdev_enqueue_burst(uint8_t dev_id, uint16_t qp_id, > > >> > >+ struct rte_regex_ops **ops, uint16_t nb_ops) > > >> > >+{ > > >> > >+ return regex_devices[dev_id]- > > >> > >>enqueue(regex_devices[dev_id], qp_id, > > >> > >+ ops, nb_ops); > > >> > >+} > > >> > > > >> > Move these functions to .h in-lining them. > > >> > Also, please add debug checks @see > > >rte_eth_rx_burst/rte_eth_tx_burst. > > >> > > >> O.K will update. > > > > > >In general, inlining is a pain for ABI compatibility. > > >Please inline only if the gain is very significant. > > > > > > > The performance gain mostly comes from hoisting `regex_devices[dev_id]` load above the > > poll loop. > > Since, the performance measurement application is still in pipeline and regexdev would be > > experimental for next couple of releases I suggest inlining it now and worrying about ABI when > > experimental tag needs to be removed. > > No, we must worry about ABI from the beginning. I think, we need to have the performance number first before we decide one or another. > > > We can follow the same path as done by ethdev [https://www.mail-archive.com/dev@dpdk.org/msg142392.html] > > ethdev is not an argument. Actually this thread explains how to make it inline without exposing the internal structure unlike existing ethdev. The effort is stalled due to PMD changes required. In this case, regexdev is new so it is the correct time to add such code. > > >