From: Jerin Jacob <jerinjacobk@gmail.com>
To: Sunil Kumar Kori <skori@marvell.com>,
Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Vamsi Attunuru <vattunuru@marvell.com>, dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] common/octeontx2: reduce wait time for mbox messages
Date: Tue, 14 Jan 2020 09:19:40 +0530 [thread overview]
Message-ID: <CALBAE1Nb788nwyjKhAtUBEwjR0mMCdhqX-1Oi5RQzi91y0NOtg@mail.gmail.com> (raw)
In-Reply-To: <20191216150253.22835-1-skori@marvell.com>
On Mon, Dec 16, 2019 at 8:33 PM Sunil Kumar Kori <skori@marvell.com> wrote:
>
> After each mbox send operation, context waits for minimum 1ms to get
> corresponding response although response can come earlier.
> So reducing wait time to lower granularity.
>
> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
Applied to dpdk-next-net-mrvl/master. Thanks
> ---
> drivers/common/octeontx2/otx2_mbox.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/common/octeontx2/otx2_mbox.c b/drivers/common/octeontx2/otx2_mbox.c
> index c359bf42f..cc341aac3 100644
> --- a/drivers/common/octeontx2/otx2_mbox.c
> +++ b/drivers/common/octeontx2/otx2_mbox.c
> @@ -278,8 +278,9 @@ mbox_wait(struct otx2_mbox *mbox, int devid, uint32_t rst_timo)
> volatile struct otx2_mbox_dev *mdev = &mbox->dev[devid];
> uint32_t timeout = 0, sleep = 1;
>
> + rst_timo = rst_timo * 1000; /* Milli seconds to micro seconds */
> while (mdev->num_msgs > mdev->msgs_acked) {
> - rte_delay_ms(sleep);
> + rte_delay_us(sleep);
> timeout += sleep;
> if (timeout >= rst_timo) {
> struct mbox_hdr *tx_hdr =
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-01-14 3:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 15:02 Sunil Kumar Kori
2020-01-14 3:49 ` Jerin Jacob [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-12-16 14:55 Sunil Kumar Kori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1Nb788nwyjKhAtUBEwjR0mMCdhqX-1Oi5RQzi91y0NOtg@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=skori@marvell.com \
--cc=vattunuru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).