From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5A61A0A02; Wed, 24 Mar 2021 12:01:39 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D2F2B140D0B; Wed, 24 Mar 2021 12:01:37 +0100 (CET) Received: from mail-il1-f169.google.com (mail-il1-f169.google.com [209.85.166.169]) by mails.dpdk.org (Postfix) with ESMTP id 227054067B for ; Wed, 24 Mar 2021 12:01:37 +0100 (CET) Received: by mail-il1-f169.google.com with SMTP id d2so20952912ilm.10 for ; Wed, 24 Mar 2021 04:01:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fgKJtjm66C0ghodfdirc+cx5rZwnzd3Z7gRO3K/I5ug=; b=mvTkpGpQufq+l+fWTjYHeNzeWIHwGZp8hIyUzJs0d5+QORVNi9XQdsOk8yGt6RpMeO 5Mr66bYflUjKwOOL6xA/r7RtFDffj/lwWUaet3xfos3DUw6B16BT1th/WpODMG2dwKjQ 2p8jKqCbVOo9aCXhnOK8OjF5m3kF/TUkD1xmmWNQG1FISOY4CLJm1d2urHRpRjQLI1A5 ZEj1CTmByxEMqDTv97aaM8jIDv6S4FPfjvlTseNoETQX+KHNIKZlMiVaxHHU8686xEgt eU+nki6LtuzqEd6qu7AsKZFBhMc8eWSYa8pg7HmOU6U3ZrXqgcP9SQYANPHMqgxpxid7 K/kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fgKJtjm66C0ghodfdirc+cx5rZwnzd3Z7gRO3K/I5ug=; b=NIHs5eTnHdBs8q5pf6nwy/JHc5bbPijevALuvcawk8fihr7CDiYAaqc4aw1M8LdZRR DTpu6HJ7JjyRQCUqaoGJP8BVBoThd7a09dO5rc7cocRsVJO3CTu1VEjxFUedCPmyoTwH zTzEbkJ6vW3Uc+RR6Z/OmLBuqU2OUqYot/87Bj5coQX1NoGB7DRotvlTzR2Jl8pXRUzl ARKmIeYs37QTQ+jkUNjFI2XvftPciTvwT+u7I55zbxRwOzod1UIh2TJg09Yxui4I1d5B gzM2ZKIaYduOTOrOATEonJQwMSQM9tMMFuBnwsa0zXFWy67k8PzxTJ3yBAGHiKi3F6RE DAhA== X-Gm-Message-State: AOAM531h5B9cF7FaEUPlXdWDAgAm+Zru8GPhi9DoCZhcEEFP4iw1g7gp h4nTJPjZZhDVBvLVZmgdVivSUcmaJIyTPSWquqA= X-Google-Smtp-Source: ABdhPJw+6tJFFHzD1UBRwBbFYFsPFASYlXkrwVtabdheM31ZWEUfj1hOhj+W9cp9AhnTy1JVTBPxPwYjGVNKjRplDUo= X-Received: by 2002:a05:6e02:f90:: with SMTP id v16mr2022297ilo.294.1616583696509; Wed, 24 Mar 2021 04:01:36 -0700 (PDT) MIME-Version: 1.0 References: <20210225190112.2073-1-pbhagavatula@marvell.com> In-Reply-To: <20210225190112.2073-1-pbhagavatula@marvell.com> From: Jerin Jacob Date: Wed, 24 Mar 2021 16:31:20 +0530 Message-ID: To: Pavan Nikhilesh , Thomas Monjalon , David Marchand Cc: Jerin Jacob , Bruce Richardson , Harman Kalra , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/2] eal: make max interrupt vector id configurable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Feb 26, 2021 at 12:31 AM wrote: > > From: Pavan Nikhilesh > > Make RTE_MAX_RXTX_INTR_VEC_ID configurable as MSI-X support a > maximum of 2048 vectors. > The default value is unchanged and set to 512. IMO, We dont need to make it configurable and each platform sets its value. That scheme won't work as generic distribution build will fail to run. Since PCIe specification defines this value and there is no performance impact on increasing this, IMO, We can change to 2048 as default. Thought from others? > > Signed-off-by: Pavan Nikhilesh > --- > config/meson.build | 1 + > lib/librte_eal/include/rte_eal_interrupts.h | 1 - > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/config/meson.build b/config/meson.build > index 3cf560b8a..0fe4d0689 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -247,6 +247,7 @@ dpdk_conf.set('RTE_LIBEAL_USE_HPET', get_option('use_hpet')) > dpdk_conf.set('RTE_ENABLE_TRACE_FP', get_option('enable_trace_fp')) > # values which have defaults which may be overridden > dpdk_conf.set('RTE_MAX_VFIO_GROUPS', 64) > +dpdk_conf.set('RTE_MAX_RXTX_INTR_VEC_ID', 512) > dpdk_conf.set('RTE_DRIVER_MEMPOOL_BUCKET_SIZE_KB', 64) > dpdk_conf.set('RTE_LIBRTE_DPAA2_USE_PHYS_IOVA', true) > if dpdk_conf.get('RTE_ARCH_64') > diff --git a/lib/librte_eal/include/rte_eal_interrupts.h b/lib/librte_eal/include/rte_eal_interrupts.h > index 00bcc19b6..e9af1a4c2 100644 > --- a/lib/librte_eal/include/rte_eal_interrupts.h > +++ b/lib/librte_eal/include/rte_eal_interrupts.h > @@ -17,7 +17,6 @@ > #ifndef _RTE_EAL_INTERRUPTS_H_ > #define _RTE_EAL_INTERRUPTS_H_ > > -#define RTE_MAX_RXTX_INTR_VEC_ID 512 > #define RTE_INTR_VEC_ZERO_OFFSET 0 > #define RTE_INTR_VEC_RXTX_OFFSET 1 > > -- > 2.17.1 >