From: Jerin Jacob <jerinjacobk@gmail.com>
To: Pavan Nikhilesh <pbhagavatula@marvell.com>
Cc: Jerin Jacob <jerinj@marvell.com>, dpdk-dev <dev@dpdk.org>,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] test/eventdev: fix unintended vdev creation
Date: Wed, 15 Jan 2020 16:36:19 +0530 [thread overview]
Message-ID: <CALBAE1NeDBfV51fUB7rK5A1gqEzQu4sFY8EcXb==A_qLzC0Ykw@mail.gmail.com> (raw)
In-Reply-To: <20200106074243.2336-1-pbhagavatula@marvell.com>
On Mon, Jan 6, 2020 at 1:12 PM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Virtual eventdevice should only be created when there is no existing
> device with the same name.
>
> Fixes: e0f4a0ed4237 ("test: skip tests when missing requirements")
> Cc: stable@dpdk.org
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
Series applied to dpdk-next-eventdev/master. Thanks.
> ---
> app/test/test_eventdev.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/app/test/test_eventdev.c b/app/test/test_eventdev.c
> index 427dbbf77..56155838d 100644
> --- a/app/test/test_eventdev.c
> +++ b/app/test/test_eventdev.c
> @@ -996,9 +996,13 @@ test_eventdev_common(void)
> static int
> test_eventdev_selftest_impl(const char *pmd, const char *opts)
> {
> - rte_vdev_init(pmd, opts);
> + int ret = 0;
> +
> if (rte_event_dev_get_dev_id(pmd) == -ENODEV)
> + ret = rte_vdev_init(pmd, opts);
> + if (ret)
> return TEST_SKIPPED;
> +
> return rte_event_dev_selftest(rte_event_dev_get_dev_id(pmd));
> }
>
> --
> 2.17.1
>
prev parent reply other threads:[~2020-01-15 11:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 7:42 pbhagavatula
2020-01-06 7:42 ` [dpdk-dev] [PATCH 2/2] test/eventdev: fix octeontx2 event device name pbhagavatula
2020-01-15 11:06 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1NeDBfV51fUB7rK5A1gqEzQu4sFY8EcXb==A_qLzC0Ykw@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=pbhagavatula@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).