From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 5D53F42D67;
Fri, 30 Jun 2023 06:37:53 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 32E5A406B5;
Fri, 30 Jun 2023 06:37:53 +0200 (CEST)
Received: from mail-ua1-f45.google.com (mail-ua1-f45.google.com
[209.85.222.45]) by mails.dpdk.org (Postfix) with ESMTP id 3BEF84021F
for <dev@dpdk.org>; Fri, 30 Jun 2023 06:37:52 +0200 (CEST)
Received: by mail-ua1-f45.google.com with SMTP id
a1e0cc1a2514c-78a065548e3so579032241.0
for <dev@dpdk.org>; Thu, 29 Jun 2023 21:37:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20221208; t=1688099871; x=1690691871;
h=content-transfer-encoding:cc:to:subject:message-id:date:from
:in-reply-to:references:mime-version:from:to:cc:subject:date
:message-id:reply-to;
bh=N2ifmBjnSTvbv/Imqb2zs0QgAi5triTbGMUKnpdpBgg=;
b=AwXKAML1Y4dgWfSEcYtPjfHeTyLbGIMasntcxMjNOabAdm1MNWwsm7ySQMSyts5u4w
8ecR02kM3XDuiZ99mx1o8iH/XCJCeUUPSEv8CllMeMatn5ZCVVgxm+p3/+bUspYMgbev
imkH/dw9u4WvwBYBR++W1ZBg+G9wAbu2fWIKoXQM9voQwfCrJtOZ8fjtcF1R0SV++WCb
6EKzNkaZhTlDsHnUeyKb3Q0HDjw+Sewurg3739+0M9BIYMf0c3vDbCt+TCh4MxlaNq2L
bATfqcfhDCqOW1uvIRN1Ngj4ECkY9pcDL1aC3G2mMIkgsxc9/VoARaEDa3VDQO3W4+wM
9PQQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20221208; t=1688099871; x=1690691871;
h=content-transfer-encoding:cc:to:subject:message-id:date:from
:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=N2ifmBjnSTvbv/Imqb2zs0QgAi5triTbGMUKnpdpBgg=;
b=a6namJUbQN4IwyXZnEXiEFihB0W2rWoUEozgFk4TF0MhFHQeD3ZUKcDzIFwiQ+rhg6
7OQpuhepPDVSnHq5gRIKvn0S9BIzvmuJw+3QFAHdIwqBlaswzORW0RL1QKX05XwKTDmh
gkfk5lSQyGgtNVMzrMDpFn+8y4QQFo8jYtRrLAsIyjdMuOoFmNzOMZ5vbSvqCiXqjk/2
/h/Ajqs6jtt4h0VKGrZkIP1Hu6/1ZQ6d1m4how2yR8xR6l+UC+GGYh9v+a8NfUpVuWS0
hi6i4X/ko4zGTIZy0z1MIt6Xql+XIrvoW/pAPXc76kKpVqarXjNZ9xP7fyCSyFK1HIHO
oH3A==
X-Gm-Message-State: ABy/qLbwaxXrtbpRrum1EuXPvKbEOlbLG/t7jYKbCO77RwhovkOQO+jI
Cut2XA2gO6sO9eaLk5OXg791nk5lrvusUJu+vJs=
X-Google-Smtp-Source: APBJJlHF5NcYzTOAMCu2QgnVAFlAJYlm90TRYR35nUpC8elH1IXjcr4eH2eAdzdeuR+MpnDbp8rpmi40E3Umlaqn9hA=
X-Received: by 2002:a1f:c1c3:0:b0:463:b57a:e927 with SMTP id
r186-20020a1fc1c3000000b00463b57ae927mr1359591vkf.4.1688099871364; Thu, 29
Jun 2023 21:37:51 -0700 (PDT)
MIME-Version: 1.0
References: <20230609174205.150027-1-mattias.ronnblom@ericsson.com>
In-Reply-To: <20230609174205.150027-1-mattias.ronnblom@ericsson.com>
From: Jerin Jacob <jerinjacobk@gmail.com>
Date: Fri, 30 Jun 2023 10:07:25 +0530
Message-ID: <CALBAE1Nek10TUkPwtDcfsF_aA8Q5=-rQvqG1xHQyxagavHMoRA@mail.gmail.com>
Subject: Re: [RFC] eventdev: remove single-event enqueue operation
To: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>
Cc: jerinj@marvell.com, hofors@lysator.liu.se, dev@dpdk.org,
Pavan Nikhilesh <pbhagavatula@marvell.com>,
Timothy McDaniel <timothy.mcdaniel@intel.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Sachin Saxena <sachin.saxena@oss.nxp.com>,
Harry van Haaren <harry.van.haaren@intel.com>, Liang Ma <liangma@liangbit.com>,
Peter Mccarthy <peter.mccarthy@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On Fri, Jun 9, 2023 at 11:18=E2=80=AFPM Mattias R=C3=B6nnblom
<mattias.ronnblom@ericsson.com> wrote:
>
> Eliminate non-burst enqueue operation from Eventdev.
>
> The effect of this change is to reduce Eventdev code complexity
> somewhat and slightly improve performance.
>
> The single-event enqueue shortcut provided a very minor performance
> advantage in some situations (e.g., with a compile time-constant burst
> size of '1'), but would in other situations cause a noticeable
> performance penalty (e.g., rte_event_enqueue_forward_burst() with run
> time-variable burst sizes varying between '1' and larger burst sizes).
>
> Signed-off-by: Mattias R=C3=B6nnblom <mattias.ronnblom@ericsson.com>
>
> -typedef uint16_t (*event_enqueue_t)(void *port, const struct rte_event *=
ev);
> -/**< @internal Enqueue event on port of a device */
> -
> typedef uint16_t (*event_enqueue_burst_t)(void *port,
> const struct rte_event ev[],
> uint16_t nb_events);
> @@ -45,8 +42,6 @@ typedef uint16_t (*event_crypto_adapter_enqueue_t)(void=
*port,
> struct rte_event_fp_ops {
> void **data;
> /**< points to array of internal port data pointers */
> - event_enqueue_t enqueue;
> - /**< PMD enqueue function. */
Can we remove "dequeue" as well?
In any event, Please send a deprecation notice as it is an ABI change,
and we need to get merge the deprecation notice patch for v23.07.
I can review the deprecation notice patch quickly as soon as you send
it to make forward progress.
> event_enqueue_burst_t enqueue_burst;
> /**< PMD enqueue burst function. */
> event_enqueue_burst_t enqueue_new_burst;
> @@ -65,7 +60,7 @@ struct rte_event_fp_ops {
> /**< PMD Tx adapter enqueue same destination function. */
> event_crypto_adapter_enqueue_t ca_enqueue;
> /**< PMD Crypto adapter enqueue function. */
> - uintptr_t reserved[6];
> + uintptr_t reserved[7];
> } __rte_cache_aligned;
>