From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45B6E430F0; Thu, 24 Aug 2023 14:20:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D14D940EE1; Thu, 24 Aug 2023 14:20:39 +0200 (CEST) Received: from mail-vk1-f172.google.com (mail-vk1-f172.google.com [209.85.221.172]) by mails.dpdk.org (Postfix) with ESMTP id C810440150 for ; Thu, 24 Aug 2023 14:20:38 +0200 (CEST) Received: by mail-vk1-f172.google.com with SMTP id 71dfb90a1353d-48d0ceedda1so1766612e0c.3 for ; Thu, 24 Aug 2023 05:20:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692879638; x=1693484438; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hY6WNswtGaXE8WspgxYe+79U9eXfUTEFFrPwq7RR1Zs=; b=N2xaDV02oHGU6gZwyN7IErODoywyWXuzLntiTjMshCgFsx2iPRk/Om643GMgJBih5f Jz31fc1DWwqS2CLoVEx3izFZ1ws146Kerk1PPen4uWIIHkVIS2wdXDpSL5HBt0TyfP0D RInNcecy7ij1Tr4W4/AI90yWJ3vEaZjQrYixUOnLJawhkXaauINGE8TZE/tFrEKZd01u HL5J/scLK8qB49vSkKkwneTAsefK29jDlSb5Z5YWG8I1Wa8hFVPm9d06wZXUZxJ2RanH 3W8LQECvUbIyzLqIwQkBdWk8bIz84HnLcmkMfwxf1HnRFbV9blwZ09pMKsLystBCcQwy Z6pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692879638; x=1693484438; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hY6WNswtGaXE8WspgxYe+79U9eXfUTEFFrPwq7RR1Zs=; b=czauOZVyiewZosIiau5FWUJoHl6RIpUq6+7aY7ah294wvdsFQeI0LLYnUXGCWGER5L PdM3wug952j12bur/qC3ocC929ko7nIGqDDMe1E9v1NEzDAphkvs1ERQHjn2vpUYsVjw v4joNJJoqk+4LcXo2AWSYw+92pqX5/Kt8Z02W6G19adXNvoROHkgNtatKg3N2GBZ1EiS 6axSaR8+GJxA+zRJS3SIZEgC/M3MF2IfRCn3zS64RysBUaXX8u14lBZPBgYbnfsJ3qoT h+IF5zzsqxJ4832lHtlT3alTJvMJSCvgm5ZMrrf6woK9V4TZiCaegBEGjXeS/4I7vl5k ryYw== X-Gm-Message-State: AOJu0YxnO349ENhG+HFokbIqgLSw4Cjh1syLUWY2jtViitBdCrrH3/7l HvayGKBXIZNp/e7YEwYWqGC2Fyna2wXSNSc/MZ+w8OdDao0= X-Google-Smtp-Source: AGHT+IHoFLUDzoodXJzmrcenh+zIN0sD5xeWgXksC6ymnHNwqhz0tlt1hcsHLwE7dLkE1QBk68VBGpD8zTXCowHnacA= X-Received: by 2002:a1f:ed81:0:b0:48d:2bcf:f95b with SMTP id l123-20020a1fed81000000b0048d2bcff95bmr10658189vkh.12.1692879638022; Thu, 24 Aug 2023 05:20:38 -0700 (PDT) MIME-Version: 1.0 References: <20230823055000.2692083-1-adwivedi@marvell.com> <20230823055000.2692083-2-adwivedi@marvell.com> In-Reply-To: <20230823055000.2692083-2-adwivedi@marvell.com> From: Jerin Jacob Date: Thu, 24 Aug 2023 17:50:10 +0530 Message-ID: Subject: Re: [PATCH v1 1/2] common/cnxk: add sa to port mapping To: Ankur Dwivedi Cc: dev@dpdk.org, gakhil@marvell.com, vattunuru@marvell.com, jerinj@marvell.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Aug 23, 2023 at 12:15=E2=80=AFPM Ankur Dwivedi wrote: > > Adds sa to port mapping in roc mcs. This helps to propagate the tx and > rx pn threshold events to the correct ethernet device. > > Signed-off-by: Ankur Dwivedi > --- > drivers/common/cnxk/roc_mcs.c | 22 +++++++++++++++++++--- > drivers/common/cnxk/roc_mcs.h | 8 ++++++-- > drivers/common/cnxk/roc_mcs_sec_cfg.c | 6 ++++++ > drivers/common/cnxk/version.map | 1 + > 4 files changed, 32 insertions(+), 5 deletions(-) Found following build issue. Please fix and resend [for-next-net]dell[dpdk-next-net-mrvl] $ gcc -v Using built-in specs. COLLECT_GCC=3D/usr/bin/gcc COLLECT_LTO_WRAPPER=3D/usr/lib/gcc/x86_64-pc-linux-gnu/13.2.1/lto-wrapper Target: x86_64-pc-linux-gnu Configured with: /build/gcc/src/gcc/configure --enable-languages=3Dada,c,c++,d,fortran,go,lto,objc,obj-c++ --enable-bootstrap --prefix=3D/usr --libdir=3D/usr/lib --libexecdir=3D/usr/lib --mandir=3D/usr/share/man --infodir=3D/usr/share/info --with-bugur l=3Dhttps://bugs.archlinux.org/ --with-build-config=3Dbootstrap-lto --with-linker-hash-style=3Dgnu --with-system-zlib --enable-__cxa_atexit --enable-cet=3Dauto --enable-checking=3Drelease --enable-clocale=3Dgnu --enable-default-pie --enable-default-ssp --enable-gnu-indirect-function --enable-gnu-unique-object --enable-libstdcxx-backtrace --enable-link-serialization=3D1 --enable-linker-build-id --enable-lto --enable-multilib --enable-plugin --enable-shared --enable-threads=3Dposix --disable-l ibssp --disable-libstdcxx-pch --disable-werror Thread model: posix Supported LTO compression algorithms: zlib zstd gcc version 13.2.1 20230801 (GCC) [1778/2638] Compiling C object drivers/libtmp_rte_net_cnxk.a.p/net_cnxk_cnxk_ethdev_mcs.c.o FAILED: drivers/libtmp_rte_net_cnxk.a.p/net_cnxk_cnxk_ethdev_mcs.c.o ccache gcc -Idrivers/libtmp_rte_net_cnxk.a.p -Idrivers -I../drivers -Idrivers/net/cnxk -I../drivers/net/cnxk -Ilib/ethdev -I../lib/ethdev -I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/ eal/linux/include -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -Ilib/net -I../lib/n et -Ilib/mbuf -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter -I../lib/meter -Idrivers/bus/pci -I../drivers/bus/pci -I../drivers/bus/pci/linux -Ilib/pci -I../lib/pci -Idrivers/bus/vdev -I../drivers/bus/vdev -Ilib/cryptodev -I../lib/cryptodev -Ilib/rcu -I../lib/rcu -Ilib/eventdev -I../lib/eventdev -Ilib/hash -I../lib/hash -Ilib/timer -I../lib/timer -Ilib/security -I../lib/security -Idrivers/common/cnxk -I../drivers/common/cnxk -Idrivers/mempoo l/cnxk -I../drivers/mempool/cnxk -fdiagnostics-color=3Dalways -D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -Wextra -Werror -O2 -g -include rte_config.h -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declaratio ns -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed-member -Wno-packed-not-aligned -Wno-missing-field-initializers -Wno-zero-lengt h-bounds -D_GNU_SOURCE -fPIC -march=3Dnative -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-truncation -flax-vector-conversions -Wno-strict-aliasing -DRTE_LOG_DEFAULT_LOGTYPE=3Dpmd.net.cnxk -MD -MQ drivers/libtmp_rte_net_cnxk.a.p/net _cnxk_cnxk_ethdev_mcs.c.o -MF drivers/libtmp_rte_net_cnxk.a.p/net_cnxk_cnxk_ethdev_mcs.c.o.d -o drivers/libtmp_rte_net_cnxk.a.p/net_cnxk_cnxk_ethdev_mcs.c.o -c ../drivers/net/cnxk/cnxk_ethdev_mcs.c ../drivers/net/cnxk/cnxk_ethdev_mcs.c: In function =E2=80=98cnxk_mcs_dev_in= it=E2=80=99: ../drivers/net/cnxk/cnxk_ethdev_mcs.c:707:40: error: passing argument 3 of =E2=80=98roc_mcs_event_cb_register=E2=80=99 from incompatible pointer = type [-Werror=3Dincompatible-pointer-types] 707 | cnxk_mcs_event_cb, dev->eth_dev, mcs_dev); | ^~~~~~~~~~~~~~~~~ | | | int (*)(void *, struct roc_mcs_event_desc *, void *) In file included from ../drivers/common/cnxk/roc_api.h:118, from ../drivers/net/cnxk/cnxk_ethdev.h:24, from ../drivers/net/cnxk/cnxk_ethdev_mcs.c:5: ../drivers/common/cnxk/roc_mcs.h:598:59: note: expected =E2=80=98roc_mcs_dev_cb_fn=E2=80=99 {aka =E2=80=98int (*)(void *, struct ro= c_mcs_event_desc *, void *, unsigned char)=E2=80=99} but argument is of type =E2=80=98int (*)(v= oid *, struct roc_mcs_event_desc *, void *)=E2=80=99 598 | roc_mcs_dev_cb_fn cb_fn, void *cb_arg, void *userdata); | ~~~~~~~~~~~~~~~~~~^~~~~ ../drivers/net/cnxk/cnxk_ethdev_mcs.c:714:40: error: passing argument 3 of =E2=80=98roc_mcs_event_cb_register=E2=80=99 from incompatible pointer = type [-Werror=3Dincompatible-pointer-types] 714 | cnxk_mcs_event_cb, dev->eth_dev, mcs_dev); | ^~~~~~~~~~~~~~~~~ | | | int (*)(void *, struct roc_mcs_event_desc *, void *) ../drivers/common/cnxk/roc_mcs.h:598:59: note: expected =E2=80=98roc_mcs_dev_cb_fn=E2=80=99 {aka =E2=80=98int (*)(void *, struct ro= c_mcs_event_desc *, void *, unsigned char)=E2=80=99} but argument is of type =E2=80=98int (*)(v= oid *, struct roc_mcs_event_desc *, void *)=E2=80=99 598 | roc_mcs_dev_cb_fn cb_fn, void *cb_arg, void *userdata); | ~~~~~~~~~~~~~~~~~~^~~~~ ../drivers/net/cnxk/cnxk_ethdev_mcs.c:721:40: error: passing argument 3 of =E2=80=98roc_mcs_event_cb_register=E2=80=99 from incompatible pointer = type [-Werror=3Dincompatible-pointer-types] 721 | cnxk_mcs_event_cb, dev->eth_dev, mcs_dev); | ^~~~~~~~~~~~~~~~~ | | | int (*)(void *, struct roc_mcs_event_desc *, void *) ../drivers/common/cnxk/roc_mcs.h:598:59: note: expected =E2=80=98roc_mcs_dev_cb_fn=E2=80=99 {aka =E2=80=98int (*)(void *, struct ro= c_mcs_event_desc *, void *, unsigned char)=E2=80=99} but argument is of type =E2=80=98int (*)(v= oid *, struct roc_mcs_event_desc *, void *)=E2=80=99 598 | roc_mcs_dev_cb_fn cb_fn, void *cb_arg, void *userdata); | ~~~~~~~~~~~~~~~~~~^~~~~