From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 66F0EA0524;
	Thu,  2 Jul 2020 11:54:13 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id C7E451D8D4;
	Thu,  2 Jul 2020 11:54:12 +0200 (CEST)
Received: from mail-io1-f67.google.com (mail-io1-f67.google.com
 [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id 8C3301D8D0
 for <dev@dpdk.org>; Thu,  2 Jul 2020 11:54:11 +0200 (CEST)
Received: by mail-io1-f67.google.com with SMTP id c16so28199278ioi.9
 for <dev@dpdk.org>; Thu, 02 Jul 2020 02:54:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=+pNv3iEMtY16p7H33FfRvq2QExluS52zOCOeITl29Qw=;
 b=nnbaxG20TDTG+30NPCa10iKZizU7zpHrRyJsaKp67W8zKs+eUe4EJVjeqJA7zNr7IF
 4xttZxA4Ddrc7BxL3Q0LtqL7rs8rE5vctXFUfsvl0Bus4hseU4Mu1RSh2PzHl19vVmMn
 aZQ7lTpBri6WeIUvZkFlJrMx6b0hD4fackYwKHjeASrWIVO1KlgzKH5/HUp40XGX6cqo
 3rffVI6WCArqPTQC9+ZsJnv9kaBUW7oBS7aOgzk6r6sCXleZF2qB4aZ0xzzTO42V7wqB
 vyote2pAD+QvlcgJh0lSujfLX3g6KJZxG1EGvUnH41WiiGPdT3kcFHunCafA8TucJ+1f
 81Ww==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=+pNv3iEMtY16p7H33FfRvq2QExluS52zOCOeITl29Qw=;
 b=ePJzZ9Q+S8JxodQQgE2szNFgboCtEm+LKBJsuDb9PGc9nEraIWOzpnvSJy3MXv78LS
 r+FRj23hYMNZy5hbz/pmYfWCWGa3MSXixNJILHWXSXsN+No7KCfFYEpgwZcaGa6Q8hCa
 sUnsDEmdgejQlgwQI0dq8hZWOwuwVXcAmo8YtZTT2D3xiLSmtb90BjyDxp+kbr49mvap
 3qOj7dxJkway5IOZYn5lgvpyrB9LdB0iFTE/pGO8e83vaDIl1uCeBHuHZ3OlQMwoNgRY
 txrpfvaVAxbvGe9DeVwvAp56dpk8/FfnAcwyHumYZtpSkFnR0pyplqTxPg1eFP4lDYfW
 unhA==
X-Gm-Message-State: AOAM5313+n+m/2zL5QH0w+5Ex1TKAtieDM4YuP/e0DzsgcmEzgf1axXi
 UjLlFubpEmypKBNO50LdjEfTZWcEuw+BlqWwtUI=
X-Google-Smtp-Source: ABdhPJyn2cRHGukbpTPe/oemXvisLWIFu8jP4vCzoqsAbNs5XDfvU5bwdkcVmNmR7Tra9aNBg6otLkiSTsjLp/S0wGY=
X-Received: by 2002:a05:6602:21c7:: with SMTP id
 c7mr6565814ioc.1.1593683650871; 
 Thu, 02 Jul 2020 02:54:10 -0700 (PDT)
MIME-Version: 1.0
References: <20200701180507.2850094-1-thomas@monjalon.net>
 <20200702091752.GB611@bricha3-MOBL.ger.corp.intel.com>
In-Reply-To: <20200702091752.GB611@bricha3-MOBL.ger.corp.intel.com>
From: Jerin Jacob <jerinjacobk@gmail.com>
Date: Thu, 2 Jul 2020 15:23:55 +0530
Message-ID: <CALBAE1NjkSUvYhN7yFBJ1iU2z-T=043=8QtmYc5WC=4LGmRoPw@mail.gmail.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Thomas Monjalon <thomas@monjalon.net>, dpdk-dev <dev@dpdk.org>, 
 David Marchand <david.marchand@redhat.com>,
 Nithin Dabilpuram <ndabilpuram@marvell.com>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH] build: remove special handling for node
	library
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Jul 2, 2020 at 2:48 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> On Wed, Jul 01, 2020 at 08:05:06PM +0200, Thomas Monjalon wrote:
> > What is the point of adding librte_node a second time separately?
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
>
> I suspect that this is a hangover from when we did not explicitly
> link_whole all DPDK libs.

Yes. The constructor functions are not getting linked if there is NO
dependency from this library.