From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96610A0520; Sat, 27 Jun 2020 09:44:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DFFED1BF7B; Sat, 27 Jun 2020 09:44:49 +0200 (CEST) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id 3016D1B952 for ; Sat, 27 Jun 2020 09:44:48 +0200 (CEST) Received: by mail-io1-f65.google.com with SMTP id c16so12155904ioi.9 for ; Sat, 27 Jun 2020 00:44:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JQi90r7Aablw0EwemrGrZzqp1R5TBg39MLsDn1TYg+g=; b=Nok7bXzGulNWLcLNHUH89mwkX5385wChLm19wMZUlhOk1OD401yhK45oB+dv8Ki8uZ mOmqblHNkjCq7HGkRmPpdizcHrvScKA1nhu29SAQCM6TQHW2ZaKKXz8U6lbXzcVC/GqQ aY5xnVFkvWXUU74p3jckz8QmoRzzVJXY/gQRN8QpQYXRs43+LoEm/LtjHpI3FEaK0hv/ OJM9JG6kw47JGu39MiC6awXNNlUP+pMvdo9IDfeHabXqi24ERAiv3+B0xMT/xbwJJfJb 9v924/HtsBdw6bgH4UZjFvll6oBWiV9X1ywz7jlBqM2Cj/hHKFUOybF70b7W979Lss/i bgRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JQi90r7Aablw0EwemrGrZzqp1R5TBg39MLsDn1TYg+g=; b=q+qUBPDRPVS7N0Uq49viaNanu+QCflNC6F4dFhjju7xzp5nAH5FSSyCUXyt4QXr4sT ZqVdVG9cXzL/3sh2TqtxSeoEIJYpKpk3Ocu2h7fL+XUA+NoIk8tXCh9RTp4IE/PoxVOS SqNk1foDwLkoWnngUSSiENA3nNpFapr8cVoNDzuYk9ssaq5lnuW3+D5kDWXhmvC4S8l7 CpVbuT3642f2wyDWLwW6N0+r174o4eBIQvWXoXY2Tt/SSA9DRmwbjpe3S9X4Kb1wLF8U QRIzI4Ajq8kvDCSPBVxmwKkq0J0vS26fs/xkttE0X2QeX7IMUwE/KCmwEpowdmYWyTDi V2bA== X-Gm-Message-State: AOAM531LEa5OwN7L1H2sqD25+QdqisFSfnf9jDZOsbVgoorKXG9wkj6x UEAUMjI6aTz61KooFpKAhk7gQULtIiCzqkrMn/0= X-Google-Smtp-Source: ABdhPJz00/EPGcCR9YKGBQwBkHJafH8TVwNUKNgmdw9FroJazPoEFZtOM61bpMxz7bDQtUnOlYg6xBamA3vdAgzJAKQ= X-Received: by 2002:a05:6602:21c7:: with SMTP id c7mr5268709ioc.1.1593243887280; Sat, 27 Jun 2020 00:44:47 -0700 (PDT) MIME-Version: 1.0 References: <1593232671-5690-1-git-send-email-timothy.mcdaniel@intel.com> <1593232671-5690-2-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: <1593232671-5690-2-git-send-email-timothy.mcdaniel@intel.com> From: Jerin Jacob Date: Sat, 27 Jun 2020 13:14:31 +0530 Message-ID: To: Tim McDaniel , Ray Kinsella , Neil Horman Cc: Jerin Jacob , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , dpdk-dev , Gage Eads , "Van Haaren, Harry" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 01/27] eventdev: dlb upstream prerequisites X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > + > +/** Event port configuration structure */ > +struct rte_event_port_conf_v20 { > + int32_t new_event_threshold; > + /**< A backpressure threshold for new event enqueues on this port. > + * Use for *closed system* event dev where event capacity is limited, > + * and cannot exceed the capacity of the event dev. > + * Configuring ports with different thresholds can make higher priority > + * traffic less likely to be backpressured. > + * For example, a port used to inject NIC Rx packets into the event dev > + * can have a lower threshold so as not to overwhelm the device, > + * while ports used for worker pools can have a higher threshold. > + * This value cannot exceed the *nb_events_limit* > + * which was previously supplied to rte_event_dev_configure(). > + * This should be set to '-1' for *open system*. > + */ > + uint16_t dequeue_depth; > + /**< Configure number of bulk dequeues for this event port. > + * This value cannot exceed the *nb_event_port_dequeue_depth* > + * which previously supplied to rte_event_dev_configure(). > + * Ignored when device is not RTE_EVENT_DEV_CAP_BURST_MODE capable. > + */ > + uint16_t enqueue_depth; > + /**< Configure number of bulk enqueues for this event port. > + * This value cannot exceed the *nb_event_port_enqueue_depth* > + * which previously supplied to rte_event_dev_configure(). > + * Ignored when device is not RTE_EVENT_DEV_CAP_BURST_MODE capable. > + */ > uint8_t disable_implicit_release; > /**< Configure the port not to release outstanding events in > * rte_event_dev_dequeue_burst(). If true, all events received through > @@ -733,6 +911,14 @@ struct rte_event_port_conf { > rte_event_port_default_conf_get(uint8_t dev_id, uint8_t port_id, > struct rte_event_port_conf *port_conf); > > +int > +rte_event_port_default_conf_get_v20(uint8_t dev_id, uint8_t port_id, > + struct rte_event_port_conf_v20 *port_conf); > + > +int > +rte_event_port_default_conf_get_v21(uint8_t dev_id, uint8_t port_id, > + struct rte_event_port_conf *port_conf); Hi Timothy, + ABI Maintainers (Ray, Neil) # As per my understanding, the structures can not be versioned, only function can be versioned. i.e we can not make any change to " struct rte_event_port_conf" # We have a similar case with ethdev and it deferred to next release v20.11 http://patches.dpdk.org/patch/69113/ Regarding the API changes: # The slow path changes general looks good to me. I will review the next level in the coming days # The following fast path changes bothers to me. Could you share more details on below change? diff --git a/app/test-eventdev/test_order_atq.c b/app/test-eventdev/test_order_atq.c index 3366cfc..8246b96 100644 --- a/app/test-eventdev/test_order_atq.c +++ b/app/test-eventdev/test_order_atq.c @@ -34,6 +34,8 @@ continue; } + ev.flow_id = ev.mbuf->udata64; + # Since RC1 is near, I am not sure how to accommodate the API changes now and sort out ABI stuffs. # Other concern is eventdev spec get bloated with versioning files just for ONE release as 20.11 will be OK to change the ABI. # While we discuss the API change, Please send deprecation notice for ABI change for 20.11, so that there is no ambiguity of this patch for the 20.11 release.