From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1144FA00C2; Thu, 9 Dec 2021 08:50:11 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9619E410DC; Thu, 9 Dec 2021 08:50:10 +0100 (CET) Received: from mail-il1-f182.google.com (mail-il1-f182.google.com [209.85.166.182]) by mails.dpdk.org (Postfix) with ESMTP id 394D840F35 for ; Thu, 9 Dec 2021 08:50:09 +0100 (CET) Received: by mail-il1-f182.google.com with SMTP id j7so4488147ilk.13 for ; Wed, 08 Dec 2021 23:50:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JCwl9QcORhx7kloOAU7T7cN+peKBPy/g1rrrnE1EH2s=; b=YFq6oTYSsma3O1Q6MS3rWQXZPi1xB7tpJsGsmuyOiFV5YcSfgvMi7XHWEc2i3GsnTz 1YDzXx5TL4YCcIsuWLEYOAG/Locl/vGAVB7K6gFj1qCPnL35nBrtIV6MaIINQNtbmg1v BU4gFdaJiuG84PLnB5if7YD+n60lZBFBCqhJNlDIkO4FX0uW5jCBy8RyVFfF2z4pCd/G Zy7J8U1c4Mn5wgcdzNypLYpvbQc24+mVnIQHcNx6/77F/GVw4Srem73rOMPdUxSOZSWr QzTNj8gzyVfKTd87akPT+/jMEmaNaDmIbekHZuIeayAqiZ5MmIqSOD8CiERJm6AOrY6R 18zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JCwl9QcORhx7kloOAU7T7cN+peKBPy/g1rrrnE1EH2s=; b=rmquGeZxrU4bw1FTzAf7RvmeYk1mimoF+2ahtr4CYWT6PPTQv6OIkaPrUqMjiv5hg8 hLLzMT/lZCdjoM8cpouNv+P2nVXUGaePvBY6IrFYMAsF4zfctIMtPk4WpJvLzgFLIWIa 0OHLCxRp0gqiaXIN2FR7/OzbIqmf49nq/QTxq0Z4zvpG1cpgVpRwEyLmyeyhLpdQnnMh ciBkuojoY7LtpqgdjAFktEGNBDXUR4MlFctWFQ3pAiJmYAw4tuwJ4JHr8G49dNl8lDuk Ob3PwGsUBxIqWAw76GALUdxXTvOZrjMD0tIefp033jYpE3Cpap7T6B8WbW4gANhpDMm2 fq0g== X-Gm-Message-State: AOAM530Ah3QdIwUEYWMZrhK6Ctev4/BulZg3DRJGXxZjtp41weCinIwv /dYi1a5WDo8DpWjEP34ca7KBC3hncc7DWq864G0= X-Google-Smtp-Source: ABdhPJyiiznFxt9vvqel9t0F3I2s0aGfFUZH3S9sOgirkYGwiUWetOs6ga5xiLuVN6QTiqewahd8B+NUaE01A1EMwTk= X-Received: by 2002:a92:cf45:: with SMTP id c5mr13892778ilr.251.1639036208253; Wed, 08 Dec 2021 23:50:08 -0800 (PST) MIME-Version: 1.0 References: <1638928262-13177-1-git-send-email-jizh@linux.microsoft.com> <1638990000-3228-1-git-send-email-jizh@linux.microsoft.com> <1638990000-3228-5-git-send-email-jizh@linux.microsoft.com> In-Reply-To: <1638990000-3228-5-git-send-email-jizh@linux.microsoft.com> From: Jerin Jacob Date: Thu, 9 Dec 2021 13:19:42 +0530 Message-ID: Subject: Re: [PATCH v14 04/11] app/test: skip interrupt tests on Windows To: Jie Zhou Cc: dpdk-dev , Dmitry Kozlyuk , "Richardson, Bruce" , roretzla@microsoft.com, Narcisa Ana Maria Vasile , "Dmitry Malloy (MESHCHANINOV)" , Pallavi Kadam , talshn@nvidia.com, Thomas Monjalon , Aaron Conole Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Dec 9, 2021 at 12:30 AM Jie Zhou wrote: > > Even though test_interrupts.c can compile on Windows, skip interrupt > tests for now since majority of eal_interrupt on Windows are stubs. > Will remove the skip after interrupt being fully enabled on Windows. > > Signed-off-by: Jie Zhou > Acked-by: Dmitry Kozlyuk > > --- > app/test/test_interrupts.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/app/test/test_interrupts.c b/app/test/test_interrupts.c > index 2a05399f96..eec9b2805b 100644 > --- a/app/test/test_interrupts.c > +++ b/app/test/test_interrupts.c > @@ -12,6 +12,15 @@ > > #include "test.h" > > +#ifdef RTE_EXEC_ENV_WINDOWS Across the series, Instead of adding conditional compilation everywhere, Why not disable specific file for compilation for windows? Purpose of EAL to abstract the differences in execution environment and application should not know that. > +static int > +test_interrupt(void) > +{ > + printf("Interrupt on Windows is not fully supported yet, skipping test\n"); > + return TEST_SKIPPED; > +} > +#else > + > #define TEST_INTERRUPT_CHECK_INTERVAL 100 /* ms */ > > /* predefined interrupt handle types */ > @@ -590,5 +599,6 @@ test_interrupt(void) > > return ret; > } > +#endif /*ifdef RTE_EXEC_ENV_WINDOWS*/ > > REGISTER_TEST_COMMAND(interrupt_autotest, test_interrupt); > -- > 2.31.0.vfs.0.1 >