From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C3090A00BE; Wed, 30 Oct 2019 13:33:17 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2125D1BFCD; Wed, 30 Oct 2019 13:33:17 +0100 (CET) Received: from mail-il1-f195.google.com (mail-il1-f195.google.com [209.85.166.195]) by dpdk.org (Postfix) with ESMTP id 7A87C1BFAE for ; Wed, 30 Oct 2019 13:33:15 +0100 (CET) Received: by mail-il1-f195.google.com with SMTP id y5so1966545ilb.5 for ; Wed, 30 Oct 2019 05:33:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=M5dWOa7XIZU8mvMcfZB5m60/uD+rPgwWtgSrpOfaROk=; b=t/zb8NjggInIvPNzhkHZd2g4bHRGbwlS0HvL35kfdK2bz5Pi4I/Mtp9aQk1AVpOY+A 09ObLHux4E7n4yUcUSC56mchqK0lBH61W9fi34208NwYHed/y6hmdCDUzS5nX3+SC+qa ZWqS2xcNPKmJEaFT8Wi40u+sGKc8NmW2ysa9CNXpepyommxo9hFajIe6JddSFGZkEpl3 FYkWnslaEWhD6HDW9k2X7gqYpWRlHNUelqdzUHbGNrM5IgWn228LCEWewfGbp91xsL6B T8oSPy6PFv8+wZBNzn6WVgav3fHAwXvZYHGMRMtYxQoDyCSkoKyiyh+XjT7vPkt012/Y nhNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=M5dWOa7XIZU8mvMcfZB5m60/uD+rPgwWtgSrpOfaROk=; b=gJ+OOzcwauSPz/wxPRmBLXjGkqxyZ0DAQY7HpwWPyvhps8Jr07tQN7qpS2xH2WCNbK FE0DMbyGXGr2B34VCcVp7CM7PvgM1jma7+Rpyo6RAzw0Cu1I60FPaZFaXB42efurbAXL uRQ2gVHxxXXNYDHffs1qMCu01BnXC4uhtIeEN3DauMP6NewknSpBbbyjHgbloRDhFY+I E0aoO4+YEOCkv8GR49pQuy1spjZ/X/tpg1T5ypD9oJzucvYHgj/Hz3EIY1twts3rRugk hLZAK/qNwazNBk05wnTr41N6tOIXhVq2VxBefCASpSsFKPPRHNov3nt4IasHTErUHxCl SsVA== X-Gm-Message-State: APjAAAW1IE52Q6NsBwoVSccPhxKKVHqhJifTNI2ye/kb0G+CMjPn9M5U urxA6OM3X829e0WshETEWdvdwmURAntBePcgtfOhx9Ro X-Google-Smtp-Source: APXvYqxNfoyDF3CV3QLI7qDvsMXgIej8xiXqMTZxfLZ3GDQaEu5cpWtXLjigigyOWvPnBSz9wCoTJ4WZVqRpKurbbgI= X-Received: by 2002:a92:ce12:: with SMTP id b18mr34588763ilo.130.1572438794578; Wed, 30 Oct 2019 05:33:14 -0700 (PDT) MIME-Version: 1.0 References: <1571125801-45773-1-git-send-email-joyce.kong@arm.com> <1571799298-18873-1-git-send-email-joyce.kong@arm.com> <2670371.SxHcXEKB0j@xps> In-Reply-To: From: Jerin Jacob Date: Wed, 30 Oct 2019 18:02:58 +0530 Message-ID: To: "Gavin Hu (Arm Technology China)" Cc: "thomas@monjalon.net" , "Joyce Kong (Arm Technology China)" , "dev@dpdk.org" , nd , "jerinj@marvell.com" , "stephen@networkplumber.org" , "mb@smartsharesystems.com" , Honnappa Nagarahalli , "ravi1.kumar@amd.com" , "rmody@marvell.com" , "shshaikh@marvell.com" , "xuanziyang2@huawei.com" , "cloud.wangxiaoyun@huawei.com" , "zhouguoyang@huawei.com" , "adrien.mazarguil@6wind.com" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 0/6] implement common rte bit operation APIs in PMDs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 30, 2019 at 3:25 PM Gavin Hu (Arm Technology China) wrote: > > Hi Thomas, > > > -----Original Message----- > > From: Thomas Monjalon > > Sent: Wednesday, October 30, 2019 12:43 AM > > To: Joyce Kong (Arm Technology China) > > Cc: dev@dpdk.org; nd ; jerinj@marvell.com; > > stephen@networkplumber.org; mb@smartsharesystems.com; Honnappa > > Nagarahalli ; Gavin Hu (Arm Technology > > China) ; ravi1.kumar@amd.com; rmody@marvell.com; > > shshaikh@marvell.com; xuanziyang2@huawei.com; > > cloud.wangxiaoyun@huawei.com; zhouguoyang@huawei.com; > > adrien.mazarguil@6wind.com > > Subject: Re: [dpdk-dev] [PATCH v2 0/6] implement common rte bit operation > > APIs in PMDs > > > > 23/10/2019 04:54, Joyce Kong: > > > There are a lot functions of bit operations scattered in PMDs, > > > consolidate them into a common API family and applied in different > > > PMDs to reduce code duplication. > > > > Please, could you look at what Adrien did in the Mellanox PMD? > > > > http://code.dpdk.org/dpdk/latest/source/drivers/net/mlx5/mlx5_utils.h#L28 > The code has less duplication, but it requires a less natural declaration of variables > http://code.dpdk.org/dpdk/latest/source/drivers/net/mlx5/mlx5.h#L607 > Should we take this way? IMO, We need to consider the MACRO based scheme only as of the last resort. > /Gavin > > > > >