From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95E8342C61; Thu, 8 Jun 2023 17:31:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 13ADC410D7; Thu, 8 Jun 2023 17:31:06 +0200 (CEST) Received: from mail-ua1-f41.google.com (mail-ua1-f41.google.com [209.85.222.41]) by mails.dpdk.org (Postfix) with ESMTP id 87F82410D3 for ; Thu, 8 Jun 2023 17:31:04 +0200 (CEST) Received: by mail-ua1-f41.google.com with SMTP id a1e0cc1a2514c-78a0c37428cso227399241.0 for ; Thu, 08 Jun 2023 08:31:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686238264; x=1688830264; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=t1WHYZtgQNBmMif8nFwoQNL49jgpGQyBUsd5aTlB/pw=; b=QjD3dDQZ+fGE5kw2xnSgb5TVyqOWG39aOLET04bbP1XyBrr6k+/DETONosRgZrUCFr MRoYhXV2wnI6unmsZqjtW9ltctbQLE2JTmiA/MMnti9ANw87WaxDNGSOw9x/nbU4wRIf oJ4Y6zEhelg5y/Y07YJvzVylp545ns1Yg7gyGHb5zPbKA577QEmcZEm3K3Tbvm41Mye6 Nq+WOjYG00AKOtRekHdwS5/NA20xLi2na2f2FHN5BUuep0QgkHrFplCdCtRk3SQK6Ve6 /Bfo5Sl5lceO5E5pMtUKzFsjUNPgy3hoGuKi0Oq5GifOv/+vjcT0JV94Ru3DX6ZABXri Ptdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686238264; x=1688830264; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t1WHYZtgQNBmMif8nFwoQNL49jgpGQyBUsd5aTlB/pw=; b=MZtWToQVKtSiPLvdhP0JrfLirxqGI+Se8BWbENlerIPeGVy3pC8Yu9q5nf8k0ktP0J QADa2oM+kF3UI6ZVTIioWYkAv2L8u/1W9KebDFKqe2nysZ9URDLHU/3TskGx5y7GlM08 lUH315zwHUCh89MYMC7GcH4Vx6cTJKVZrUjsP9eXu+HH3+7L27VcCyiv3icn8kt0qFx4 U5Xy9ofo++ivHAIYlPQg9nADlMRfFsSuT08bNS+DuI4k0VCBVUngMJcr3iK0Hpynaqaq nvlSvPiO+HYzHDBNtpWNYY3/5QxltEsxzj0NIV4GgmEBBfazpsK/cEV3ib3MfjkU32G+ X5sw== X-Gm-Message-State: AC+VfDy9irVmj9zwtI+UGgfm8GMyjf4bHr8rFQTPuG8gDDixxCqblEz6 MF90LmTi7YBuZ9FK4K5p3JfZglgwvtw4m05ACSw= X-Google-Smtp-Source: ACHHUZ5l6yJ8Y6wwFumgut67RLTX0hQw3xB/RpcW6Xdv7MV8UjGTcgw+VQFHtcskNcoWonoH5CKWBNWww3zF+fswLyE= X-Received: by 2002:a67:ff84:0:b0:43b:17b6:56e6 with SMTP id v4-20020a67ff84000000b0043b17b656e6mr2168819vsq.16.1686238263676; Thu, 08 Jun 2023 08:31:03 -0700 (PDT) MIME-Version: 1.0 References: <20230608095759.1800617-1-zhirun.yan@intel.com> <20230608151844.1823783-1-zhirun.yan@intel.com> In-Reply-To: <20230608151844.1823783-1-zhirun.yan@intel.com> From: Jerin Jacob Date: Thu, 8 Jun 2023 21:00:37 +0530 Message-ID: Subject: Re: [PATCH v11 00/16] graph enhancement for multi-core dispatch To: Zhirun Yan , Thomas Monjalon Cc: dev@dpdk.org, jerinj@marvell.com, kirankumark@marvell.com, ndabilpuram@marvell.com, stephen@networkplumber.org, pbhagavatula@marvell.com, cunming.liang@intel.com, haiyue.wang@intel.com, mattias.ronnblom@ericsson.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jun 8, 2023 at 8:55=E2=80=AFPM Zhirun Yan wr= ote: > > V11: > Update comments and fix to add experimental flags for rte_graph_model_is_= valid() in patch 04. > Update added symbols in alphabetical order in version.map with patch 04,0= 5,06,08,10. > Update commit message in patch 16. + @Thomas Monjalon This patch series looks good from my PoV to merge this in rc1. If you don't find any issue, please consider merging in this rc1. > > V10: > Add rte_graph_worker_model_no_check_get() for fast path, extract rte_grap= h_model_is_valid() > in patch 04. > Change RTE_ASSERT to return in patch 06. > Change to treat not defined RTE_GRAPH_MODEL_SELECT as runtime pick in pat= ch 13. > Move stats into dispatch union in patch 14. > Change example to align with RTE_GRAPH_MODEL_SELECT scheme in patch 16. > Squash patch 17(doc) into patch 13(prog_guide), 16(example guide). > > > V9: > Fix CI build issues for doc building(move TAILQ next pointer out of union= ) in patch 09,10. > Fix graph model check in rte_graph_worker_model_set() in patch 04. > Fix typo in doc. > > V8: > No performance dorp for original l3fwd-graph and graph_perf_autotest. > > Update graph model set/get functions and add graph_model_is_valid() in pa= tch 04. > Update doc for new scheme usage(choose model in runtime or compile time). > Update dispatch schedule struct into union. > Change enum rte_graph_worker_model to macro define in rte_graph_worker_co= mmon.h. > Add model clone in graph_clone() in patch 08. > Remove unnecessary inline for slow path func graph_src_node_avail() in pa= tch 06. > > > V7: > Revert rte_rdtsc_precise() in fastpath to fix performance issues in patch= 03. > Introduce new scheme for model choosing. Use RTE_GRAPH_MODEL_SELECT to ch= oose in > compile-time in patch 13, 15.(must have rte_graph_worker_model_set() to= help > other config func to do model specific things like alloc wq, collect st= ats) > Extract the common func clone_name() into graph_private.h for graph/node = clone in > patch 07.(new patch) > Use rte_graph->model in rte_graph_worker_model_set() instead of RTE_PER_L= CORE_*. > Add test case for all new APIs in patch 16(new patch). > Remove *_END line in enum rte_graph_worker_model in patch 04. > Add model check for graph lcore binding. > Rename workqueue as graph_mcore_dispatch_wq_node in patch 09. > Change all new model files/APIs with prefix _mcore_dispatch_. > Change description of new API, comments of func/structure to explicitly m= ention for > mcore dispatch model only. Add Doxygen comments. > Update l3fwd-graph with new scheme, Update doc. > Update MAINTAINERS. > Fix typo and format issues. > > V6: > Change rte_rdtsc() to rte_rdtsc_precise(). > Add union in rte_graph_param to configure models. > Remove memset in fastpath, add RTE_ASSERT for cloned graph. > Update copyright in patch 02. > Update l3fwd-graph node affinity, start from rx core successively. > > V5: > Fix CI build issues about dynamically update doc. > > V4: > Fix CI build issues about undefined reference of sched apis. > Remove inline for model setting. > > V3: > Fix CI build issues about TLS and typo. > > V2: > Use git mv to keep git history. > Use TLS for per-thread local storage. > Change model name to mcore dispatch. > Change API with specific mode name. > Split big patch. > Fix CI issues. > Rebase l3fwd-graph example. > Update doc and maintainers files. > > > Currently, rte_graph supports RTC (Run-To-Completion) model within each > of a single core. > RTC is one of the typical model of packet processing. Others like > Pipeline or Hybrid are lack of support. > > The patch set introduces a 'multicore dispatch' model selection which > is a self-reacting scheme according to the core affinity. > The new model enables a cross-core dispatching mechanism which employs a > scheduling work-queue to dispatch streams to other worker cores which > being associated with the destination node. When core flavor of the > destination node is a default 'current', the stream can be continue > executed as normal. > > Example: > 3-node graph targets 3-core budget > > RTC: > Graph: node-0 -> node-1 -> node-2 @Core0. > > + - - - - - - - - - - - - - - - - - - - - - + > ' Core #0/1/2 ' > ' ' > ' +--------+ +---------+ +--------+ ' > ' | Node-0 | --> | Node-1 | --> | Node-2 | ' > ' +--------+ +---------+ +--------+ ' > ' ' > + - - - - - - - - - - - - - - - - - - - - - + > > Dispatch: > > Graph topo: node-0 -> Core1; node-1 -> node-2; node-2 -> node-3. > Config graph: node-0 @Core0; node-1/3 @Core1; node-2 @Core2. > > .. code-block:: diff > > + - - - - - -+ +- - - - - - - - - - - - - + + - - - - - -+ > ' Core #0 ' ' Core #1 ' ' Core #2 ' > ' ' ' ' ' ' > ' +--------+ ' ' +--------+ +--------+ ' ' +--------+ ' > ' | Node-0 | - - - ->| Node-1 | | Node-3 |<- - - - | Node-2 | ' > ' +--------+ ' ' +--------+ +--------+ ' ' +--------+ ' > ' ' ' | ' ' ^ ' > + - - - - - -+ +- - -|- - - - - - - - - - + + - - -|- - -+ > | | > + - - - - - - - - - - - - - - - - + > > > The patch set has been break down as below: > > 1. Split graph worker into common and default model part. > 2. Inline graph node processing to make it reusable. > 3. Add set/get APIs to choose worker model. > 4. Introduce core affinity API to set the node run on specific worker cor= e. > (only use in new model) > 5. Introduce graph affinity API to bind one graph with specific worker > core. > 6. Introduce graph clone API. > 7. Introduce stream moving with scheduler work-queue in patch 8~12. > 8. Add stats for new models. > 9. Abstract default graph config process and integrate new model into > example/l3fwd-graph. Add new parameters for model choosing. > > We could run with new worker model by this: > ./dpdk-l3fwd-graph -l 8,9,10,11 -n 4 -- -p 0x1 --config=3D"(0,0,9)" -P > --model=3D"dispatch" > > References: > https://static.sched.com/hosted_files/dpdkuserspace22/a6/graph%20introduc= e%20remote%20dispatch%20for%20mult-core%20scaling.pdf > > > Zhirun Yan (16): > graph: rename rte_graph_work as common > graph: split graph worker into common and default model > graph: move node process into inline function > graph: add get/set graph worker model APIs > graph: introduce graph node core affinity API > graph: introduce graph bind unbind API > graph: move node clone name func into private as common > graph: introduce graph clone API for other worker core > graph: add structure for stream moving between cores > graph: introduce stream moving cross cores > graph: enable create and destroy graph scheduling workqueue > graph: introduce graph walk by cross-core dispatch > graph: enable graph multicore dispatch scheduler model > graph: add stats for mcore dispatch model > test/graph: add functional tests for mcore dispatch model > examples/l3fwd-graph: introduce mcore dispatch worker model > > MAINTAINERS | 3 +- > app/test/test_graph.c | 130 ++++ > doc/guides/prog_guide/graph_lib.rst | 71 ++- > doc/guides/sample_app_ug/l3_forward_graph.rst | 16 + > examples/l3fwd-graph/main.c | 230 +++++-- > lib/graph/graph.c | 161 +++++ > lib/graph/graph_debug.c | 6 + > lib/graph/graph_populate.c | 1 + > lib/graph/graph_private.h | 90 +++ > lib/graph/graph_stats.c | 76 ++- > lib/graph/meson.build | 4 +- > lib/graph/node.c | 27 +- > lib/graph/rte_graph.h | 65 ++ > lib/graph/rte_graph_model_mcore_dispatch.c | 191 ++++++ > lib/graph/rte_graph_model_mcore_dispatch.h | 134 ++++ > lib/graph/rte_graph_model_rtc.h | 46 ++ > lib/graph/rte_graph_worker.c | 39 ++ > lib/graph/rte_graph_worker.h | 503 +-------------- > lib/graph/rte_graph_worker_common.h | 598 ++++++++++++++++++ > lib/graph/version.map | 11 + > 20 files changed, 1834 insertions(+), 568 deletions(-) > create mode 100644 lib/graph/rte_graph_model_mcore_dispatch.c > create mode 100644 lib/graph/rte_graph_model_mcore_dispatch.h > create mode 100644 lib/graph/rte_graph_model_rtc.h > create mode 100644 lib/graph/rte_graph_worker.c > create mode 100644 lib/graph/rte_graph_worker_common.h > > -- > 2.37.2 >