From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5003DA034C; Wed, 21 Dec 2022 12:00:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3FF1940A7F; Wed, 21 Dec 2022 12:00:23 +0100 (CET) Received: from mail-vk1-f173.google.com (mail-vk1-f173.google.com [209.85.221.173]) by mails.dpdk.org (Postfix) with ESMTP id 490ED40A7A for ; Wed, 21 Dec 2022 12:00:22 +0100 (CET) Received: by mail-vk1-f173.google.com with SMTP id v81so7045168vkv.5 for ; Wed, 21 Dec 2022 03:00:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Ay8ICuw3CSvL20+ELsv1fBdekIlE8VswC02XjQToB9s=; b=lAlj+4KGVGmCfFoCJ7EUfDTB2+ZuELvcciJCmFF9xTyzKHEzTmxfv/Kpck8mniPTLM DfOoSVxa43dX5ZiRsDd7gaBc2yGTNRI4D5t2yRGj0yQc6H98NN3BgZQaLgoH6ekjZqT8 sKu6ga0W33+yewThcLuCTI/R3PUi5vkW/ss2rrnApD32aKjnbDCpv7tF+Y7k3EAU2TgW kmXF/2mBYuEqFCllluhCaDu26n/pBeyUmzgO9rM7NgSzxnfcaFHKYw7u65IohqjuA3pe KQ3yMgK/tM5cZHK1WLJllqL+EMhz0lOw5sZk3ipUz2yCum1vGX+x3ne0/aDg19jP23Pe MniQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ay8ICuw3CSvL20+ELsv1fBdekIlE8VswC02XjQToB9s=; b=DMvl2UqhWSU2jRdJq3tTsnVNVL0Ta9XxCATFyl/nwIAfQYFKiDeP2tOiQxWzfSFkg+ QZX1kX3/ufek0wr2GBE4MJcItZm8XngCL2lKzEl8xLxdxjTIWjx/BrXHe2NODeoaXMZs w8lcVnH192ZhYbYgc2kGz2wYLDdSstuTb704SteAjREpBzZ1j6RcpXDU3l1NSldqO6hC uPEWcMNRGTlJq1H907kFIM6fHtxoz1q+b5FnD7o+JGhvjDZb2p5X3+N6EOd6VXXyE49c 9eM7I7Wi5oWnv7hwkqJ6eZZe0k4NqqxW67w17o4l797wrr9c+NDzPmsaMoTCHg7hFNVE yFpA== X-Gm-Message-State: AFqh2kpWyjQ1H58ci8p/L3Gg32K4BguJSgK4STEh7KBtnMoBeJ3nCWiz EPSnQpUGdw+mDenZDuymE1B4JDGyLq8kPSvqa5u3alG5g88PtQ== X-Google-Smtp-Source: AMrXdXuUtqwueIib7snQZkft146wxAdYZ+pVzFnxVMwEknoSBULc4ys6oJ6MGsHJNNvqM1SO5zqqukNyewQskQo/ffE= X-Received: by 2002:a1f:6604:0:b0:3bd:adaf:adcc with SMTP id a4-20020a1f6604000000b003bdadafadccmr138687vkc.5.1671620421511; Wed, 21 Dec 2022 03:00:21 -0800 (PST) MIME-Version: 1.0 References: <20221205215416.7ac53a55@hermes.local> <20221221090017.3715030-1-rongweil@nvidia.com> <20221221090017.3715030-3-rongweil@nvidia.com> In-Reply-To: From: Jerin Jacob Date: Wed, 21 Dec 2022 16:29:54 +0530 Message-ID: Subject: Re: [RFC v3 2/2] ethdev: add API to set process to active or standby To: Rongwei Liu Cc: Matan Azrad , Slava Ovsiienko , Ori Kam , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Ferruh Yigit , Andrew Rybchenko , "dev@dpdk.org" , Raslan Darawsheh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Dec 21, 2022 at 3:02 PM Rongwei Liu wrote: > > HI Jerin: > Hi Rongwei > BR > Rongwei > > > -----Original Message----- > > From: Jerin Jacob > > Sent: Wednesday, December 21, 2022 17:13 > > To: Rongwei Liu > > Cc: Matan Azrad ; Slava Ovsiienko > > ; Ori Kam ; NBU-Contact- > > Thomas Monjalon (EXTERNAL) ; Ferruh Yigit > > ; Andrew Rybchenko > > ; dev@dpdk.org; Raslan Darawsheh > > > > Subject: Re: [RFC v3 2/2] ethdev: add API to set process to active or s= tandby > > > > External email: Use caution opening links or attachments > > > > > > On Wed, Dec 21, 2022 at 2:31 PM Rongwei Liu wrote= : > > > > > > Users may want to change the DPDK process to different versions > > > > Different version of DPDK? If there is any ABI change how to support th= is? > > > There is a new member which was introduced into rte_eth_dev_info but it s= houldn=E2=80=99t be ABI breaking since using reserved fields. That is just for rte_eth_dev_info. What about the ABI change in different ethdev structure and rte_flow structures across different DPDK ABI versions. > > > such as hot upgrade. > > > There is a strong requirement to simplify the logic and shorten the > > > traffic downtime as much as possible. > > > > > > This update introduces new rte_eth process role definitions: active o= r > > > standby. > > > > > > The active role means rules are programmed to HW immediately, and no > > > > Why it has to be specific only to rte_flow rule? If it spedieic to rte_= flow, why it > > is in rte_eth_process_ name space? > For now, this design focuses on the flow rule offloading and traffic redi= rection. > When switching process version, it' important to make sure which applicat= ion receives and handles the traffic. Changing the DPDK version runtime is just beyond rte_flow driver. > The changing should be effective across all probing eth devices, that' wh= y it was put under rte_eth_process_ (for all rte_eth_dev) name space. > > > > Also, if we are moving the standby, What about the rule whose ABI is ch= anged > > between versions? > > Like the comments mentioned: " Before role transition, all the rules set = by the active process should be flushed first. " What happens to rte_flow flow handles for existing ones which is created with version X? Also What if new version Y has ABI change in rte_flow_pattern and rte_flow_action structure? For me, If DPDK version change is needed, simply reload the application. This API will soon bloat, and it will be a mess if to start handling Different DPDK version which is not ABI compatible at all. > > > behavior changed. This is the default state. > > > The standby role means rules are queued in the HW. If no active roles > > > alive or back to active, the rules are effective immediately. > > > > > > Signed-off-by: Rongwei Liu