From: Jerin Jacob <jerinjacobk@gmail.com>
To: Nithin Dabilpuram <ndabilpuram@marvell.com>,
Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Pavan Nikhilesh <pbhagavatula@marvell.com>,
Jerin Jacob <jerinj@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>, dpdk-dev <dev@dpdk.org>,
Harman Kalra <hkalra@marvell.com>, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/octeontx2: avoid per-pkt barrier with multi seg
Date: Sat, 31 Oct 2020 19:25:53 +0530 [thread overview]
Message-ID: <CALBAE1NqBwKBdsGH3GRfYTZWLk+dbO=o0_N1BhhXS+7W63hiDg@mail.gmail.com> (raw)
In-Reply-To: <20201028114643.6723-1-ndabilpuram@marvell.com>
On Wed, Oct 28, 2020 at 5:17 PM Nithin Dabilpuram
<ndabilpuram@marvell.com> wrote:
>
> Avoid per-pkt barrier with multi-seg with fast free
> and remove mbuf update to NULL.
>
> Fixes: ce8628c66a22 ("net/octeontx2: fix jumbo frame crash")
> Cc: hkalra@marvell.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
Applied to dpdk-next-net-mrvl/for-main. Thanks
> ---
>
> v2:
> - Add fixes tag and also cc stable
>
> drivers/event/octeontx2/otx2_worker.h | 22 ++++++++--------------
> drivers/net/octeontx2/otx2_tx.c | 8 ++++++--
> drivers/net/octeontx2/otx2_tx.h | 12 ++++++++----
> 3 files changed, 22 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/event/octeontx2/otx2_worker.h b/drivers/event/octeontx2/otx2_worker.h
> index 4501f4e..3efd3ba 100644
> --- a/drivers/event/octeontx2/otx2_worker.h
> +++ b/drivers/event/octeontx2/otx2_worker.h
> @@ -288,18 +288,12 @@ otx2_ssogws_event_tx(struct otx2_ssogws *ws, struct rte_event ev[],
>
> /* Perform header writes before barrier for TSO */
> otx2_nix_xmit_prepare_tso(m, flags);
> - /* Lets commit any changes in the packet here in case of single seg as
> - * no further changes to mbuf will be done.
> - * While for multi seg all mbufs used are set to NULL in
> - * otx2_nix_prepare_mseg() after preparing the sg list and these changes
> - * should be committed before LMTST.
> - * Also in no fast free case some mbuf fields are updated in
> - * otx2_nix_prefree_seg
> - * Hence otx2_nix_xmit_submit_lmt_release/otx2_nix_xmit_mseg_one_release
> - * has store barrier for multiseg.
> + /* Lets commit any changes in the packet here in case when
> + * fast free is set as no further changes will be made to mbuf.
> + * In case of fast free is not set, both otx2_nix_prepare_mseg()
> + * and otx2_nix_xmit_prepare() has a barrier after refcnt update.
> */
> - if (!(flags & NIX_TX_MULTI_SEG_F) &&
> - !(flags & NIX_TX_OFFLOAD_MBUF_NOFF_F))
> + if (!(flags & NIX_TX_OFFLOAD_MBUF_NOFF_F))
> rte_io_wmb();
> txq = otx2_ssogws_xtract_meta(m, txq_data);
> otx2_ssogws_prepare_pkt(txq, m, cmd, flags);
> @@ -311,12 +305,12 @@ otx2_ssogws_event_tx(struct otx2_ssogws *ws, struct rte_event ev[],
> if (!ev->sched_type) {
> otx2_nix_xmit_mseg_prep_lmt(cmd, txq->lmt_addr, segdw);
> otx2_ssogws_head_wait(ws);
> - if (otx2_nix_xmit_submit_lmt_release(txq->io_addr) == 0)
> + if (otx2_nix_xmit_submit_lmt(txq->io_addr) == 0)
> otx2_nix_xmit_mseg_one(cmd, txq->lmt_addr,
> txq->io_addr, segdw);
> } else {
> - otx2_nix_xmit_mseg_one_release(cmd, txq->lmt_addr,
> - txq->io_addr, segdw);
> + otx2_nix_xmit_mseg_one(cmd, txq->lmt_addr,
> + txq->io_addr, segdw);
> }
> } else {
> /* Passing no of segdw as 4: HDR + EXT + SG + SMEM */
> diff --git a/drivers/net/octeontx2/otx2_tx.c b/drivers/net/octeontx2/otx2_tx.c
> index 4458d8b..439c46f 100644
> --- a/drivers/net/octeontx2/otx2_tx.c
> +++ b/drivers/net/octeontx2/otx2_tx.c
> @@ -77,11 +77,15 @@ nix_xmit_pkts_mseg(void *tx_queue, struct rte_mbuf **tx_pkts,
> otx2_nix_xmit_prepare_tso(tx_pkts[i], flags);
> }
>
> + /* Lets commit any changes in the packet here as no further changes
> + * to the packet will be done unless no fast free is enabled.
> + */
> + if (!(flags & NIX_TX_OFFLOAD_MBUF_NOFF_F))
> + rte_io_wmb();
> +
> for (i = 0; i < pkts; i++) {
> otx2_nix_xmit_prepare(tx_pkts[i], cmd, flags);
> segdw = otx2_nix_prepare_mseg(tx_pkts[i], cmd, flags);
> - /* Lets commit any changes in the packet */
> - rte_io_wmb();
> otx2_nix_xmit_prepare_tstamp(cmd, &txq->cmd[0],
> tx_pkts[i]->ol_flags, segdw,
> flags);
> diff --git a/drivers/net/octeontx2/otx2_tx.h b/drivers/net/octeontx2/otx2_tx.h
> index d6ea3b4..a97b160 100644
> --- a/drivers/net/octeontx2/otx2_tx.h
> +++ b/drivers/net/octeontx2/otx2_tx.h
> @@ -440,13 +440,17 @@ otx2_nix_prepare_mseg(struct rte_mbuf *m, uint64_t *cmd, const uint16_t flags)
> sg_u = sg_u | ((uint64_t)m->data_len << (i << 4));
> *slist = rte_mbuf_data_iova(m);
> /* Set invert df if buffer is not to be freed by H/W */
> - if (flags & NIX_TX_OFFLOAD_MBUF_NOFF_F)
> + if (flags & NIX_TX_OFFLOAD_MBUF_NOFF_F) {
> sg_u |= (otx2_nix_prefree_seg(m) << (i + 55));
> + /* Commit changes to mbuf */
> + rte_io_wmb();
> + }
> /* Mark mempool object as "put" since it is freed by NIX */
> - if (!(sg_u & (1ULL << (i + 55)))) {
> - m->next = NULL;
> +#ifdef RTE_LIBRTE_MEMPOOL_DEBUG
> + if (!(sg_u & (1ULL << (i + 55))))
> __mempool_check_cookies(m->pool, (void **)&m, 1, 0);
> - }
> + rte_io_wmb();
> +#endif
> slist++;
> i++;
> nb_segs--;
> --
> 2.8.4
>
prev parent reply other threads:[~2020-10-31 13:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 11:39 [dpdk-dev] [PATCH] " Nithin Dabilpuram
2020-10-28 11:46 ` [dpdk-dev] [PATCH v2] " Nithin Dabilpuram
2020-10-31 13:55 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1NqBwKBdsGH3GRfYTZWLk+dbO=o0_N1BhhXS+7W63hiDg@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hkalra@marvell.com \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=pbhagavatula@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).