From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 669A8A053C; Thu, 6 Feb 2020 16:06:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 054821C0CF; Thu, 6 Feb 2020 16:06:47 +0100 (CET) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id 6BC631BF9E for ; Thu, 6 Feb 2020 16:06:46 +0100 (CET) Received: by mail-io1-f67.google.com with SMTP id n21so6634985ioo.10 for ; Thu, 06 Feb 2020 07:06:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=zEqdlxKjpj9n4dTSW5qUA9i8566zlhL0s+X2pnci+Kk=; b=of5gaTb7OLr7jT7uojsLs3pTsq/eap4CheO5bAlaAtbGqlvAaUr03+d3cO+nKg0xxg P33biTaitlGbsyeQh9lWhpRgET+P63+6jJ0KT4a+koQljf7sQcb9aURZqaAxOKcu9DYM itPkvESNYUqXGyD19NKMZ74sgid6gVwunj2rHPowYfD8Drzo417vJWwCU4xSJ0TwAVH5 SX7HJRurjO8lnbEezoHwD2CjrhJo6AdzZzqhcQDVQ0GzO1JkqKhoMgYWcFYhOJu4/sxu WsOPYvlB7DM/PEpW/R67HO/bDayA2Xab5lQd16lv0BLoldcQc9VH0AvtnR6RUlS27Gw4 Czxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=zEqdlxKjpj9n4dTSW5qUA9i8566zlhL0s+X2pnci+Kk=; b=FBCKTZvuIbLpdH3V2vxEJyVvLsEJm3UitnQe/Ozsf7MbGM02RHGttB6Kau2WHhdsEG J2EQ77fwE9OCWGQUtwTIBRwc7XDfbLmUVXPWUSq/+4viWu3BcpppUO4HHeMgZASTgWJb +U0p0pOF0+LyttoUbQvyh2UqTIjXbf3sEwSjfOQPZMIvKark39Afm4yZDQ0BXmQDUAC+ W0RqtJScNR4AW8hz0fFG6PVWhlPt8ob9fqQTgLcy+Pk/v7tyNRK/9BpGgF6g9eZklDJE 5wsgujh3ZnpUXQ6uTx9siEBXsuHOxQ4Oqt/CT7N99CUPM8eTvCmcwKKBvDgeE1MLR7fG c7MA== X-Gm-Message-State: APjAAAW9IxE0Jl2yfods9EOicKXvW4V+WKYMjeJRfJWelEbcEmnoJaOV ALB8kZ7sTvQxlqeeQKCGb5lr5u2VWYRT4JtNcec= X-Google-Smtp-Source: APXvYqw6lvdenGrWqAyOhbSLL3nil0A+hqsikDQWIZ6aQXFiLh1jRGi5NobqCBfSuXxm2/QOfFVQ8KyW0PFwOauZr9c= X-Received: by 2002:a02:cc75:: with SMTP id j21mr33575271jaq.113.1581001605490; Thu, 06 Feb 2020 07:06:45 -0800 (PST) MIME-Version: 1.0 References: <20200206142749.GA777@bricha3-MOBL.ger.corp.intel.com> <256f5d9f-ca90-8946-64c0-319a886bff3a@6wind.com> In-Reply-To: <256f5d9f-ca90-8946-64c0-319a886bff3a@6wind.com> From: Jerin Jacob Date: Thu, 6 Feb 2020 20:36:29 +0530 Message-ID: To: Thierry Herbelot Cc: Bruce Richardson , "dev@dpdk.org" , Anoob Joseph , Akhil Goyal Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] drivers/octeontx2: compilation fails without RTE_LIBRTE_SECURITY X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Feb 6, 2020 at 8:26 PM Thierry Herbelot wrote: > > On 2/6/20 3:48 PM, Jerin Jacob wrote: > > On Thu, Feb 6, 2020 at 8:06 PM Thierry Herbelot > > wrote: > >> > >> On 2/6/20 3:27 PM, Bruce Richardson wrote: > >>> On Thu, Feb 06, 2020 at 02:39:28PM +0100, Thierry Herbelot wrote: > >>>> Hello, > >>>> > >>>> When RTE_LIBRTE_SECURITY is disabled, compilation fails for octeontx= 2 (on an > >>>> Intel machine): > >>>> > >>>> git clone git://dpdk.org/dpdk > >>>> cd dpdk > >>>> make config T=3Dx86_64-native-linux-gcc > >>>> cd build > >>>> vi .config > >>>> =3D> disable RTE_LIBRTE_IPSEC and RTE_LIBRTE_SECURITY > >>>> make > >>>> ... > >>>> =3D=3D Build drivers/net/octeontx2 > >>>> CC otx2_rx.o > >>>> In file included from .../dpdk/drivers/net/octeontx2/otx2_ethdev_sec= .h:10, > >>>> from .../dpdk/drivers/net/octeontx2/otx2_rx.h:11, > >>>> from .../dpdk/drivers/net/octeontx2/otx2_ethdev.h= :24, > >>>> from .../dpdk/drivers/net/octeontx2/otx2_rx.c:7: > >>>> .../dpdk/drivers/crypto/octeontx2/otx2_ipsec_fp.h:9:10: fatal error: > >>>> rte_security.h: No such file or directory > >>>> #include > >>>> ^~~~~~~~~~~~~~~~ > >>>> compilation terminated. > >>>> > >>>> This seems cause by f44e7163775537 ('net/octeontx2: add security ses= sion > >>>> operations'). > >>>> > >>> Disabling parts of the build, particularly libraries, is always likel= y to > >>> cause other build failures. I'm not sure we should, or even need to, > >>> support the disabling of arbitrary libs in DPDK. > >> > >> Hello, > >> > >> On the other hand, there is no reason delivering unused code in a DPDK > >> application: an application should be free to select its needed 'modul= es'. > > > > Just to understand the use case, What would be the downside of > > compiling unwanted code? > > In meson, it takes only jiffies to compile code and If we use, > > -no-whole-archive then the generated binary will not be bloated, > > Considering the case where "make" build system will be deprecated soon > > and, for meson, I don't think, we are > > planning to take the route of disabling the "core libraries". > > > > Could you share the real-world use for this? > > My only concern is we can not make tons of #define in the driver code. > > So, eventually, we end up > > disabling the driver. > > Hello Jerin, Hello Thierry, > > Our use case is that IPsec is provided as part of 6WIND stack, not using > the version from DPDK (we are using the crypto PMDs from DPDK). I see. But still, I don't see any issue even If the 6WIND stack is not usin= g any security or IPsec lib files. Both library and header files will be just unu= sed in the install directory. Right? Or am I missing something? > In any case, as the compilation of DPDK is (still) driven by a separate > configuration file, it should be possible that some combination of No configuration file option with meson to opt-in and opt-out the library. > options are disabled, and still DPDK builds fine. > > Thierry > > > > > > > > >> > >> Thanks > >> > >> Thierry > >> > >>> > >>> /Bruce > >>> > >> > > > -- > Thierry Herbelot > 6WIND > Senior Software Engineer > > Tel: +33 1 39 30 92 61 > Fax: +33 1 39 30 92 11 > thierry.herbelot@6wind.com > www.6wind.com > Immeuble Central Gare - B=C3=A2t C 1, place Charles de Gaulle 78180 > Montigny-le-Bretonneux, France > > Ce courriel ainsi que toutes les pi=C3=A8ces jointes, est uniquement dest= in=C3=A9 > =C3=A0 son ou ses destinataires. Il contient des informations confidentie= lles > qui sont la propri=C3=A9t=C3=A9 de 6WIND. Toute r=C3=A9v=C3=A9lation, dis= tribution ou copie > des informations qu'il contient est strictement interdite. Si vous avez > re=C3=A7u ce message par erreur, veuillez imm=C3=A9diatement le signaler = =C3=A0 > l'=C3=A9metteur et d=C3=A9truire toutes les donn=C3=A9es re=C3=A7ues > > This e-mail message, including any attachments, is for the sole use of > the intended recipient(s) and contains information that is confidential > and proprietary to 6WIND. All unauthorized review, use, disclosure or > distribution is prohibited. If you are not the intended recipient, > please contact the sender by reply e-mail and destroy all copies of the > original message.