From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D1C7A0597; Wed, 8 Apr 2020 10:38:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 04E671C025; Wed, 8 Apr 2020 10:38:50 +0200 (CEST) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id 434E31BFC5 for ; Wed, 8 Apr 2020 10:38:48 +0200 (CEST) Received: by mail-io1-f65.google.com with SMTP id i19so4320814ioh.12 for ; Wed, 08 Apr 2020 01:38:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YDgHvX6kdTW0KFLq0oNaXmkJZmBD7/NAvLsQPGWEqiA=; b=QmE0RjeOHqulGTFk3f5/VCCpOyZq057oNz3S+YMpZ2KdL1ivTgyor8xv8+6oUtvxiM bCfrLT0QvNOeLCl1+y0EuQp6B4I3Kgogae0O18E4IuF/kh4KYtdPp2E4l/nOW5I0G7Vb o3pQQRjBDyTQeyvsqUx5yU6lblUFrfrjzbUw1id2H16xALpNMrdNwfrX8LYYKvo5T4pS FTxqsZbeBicg5hMyBbnXnUmpbZTxvNTivsxHQA7vZfcLEJP44y+pyc1cO1aXkbFWDO07 8+L3AVDxW95X1n3mCBUf0cbrV6SXFxTUvxoidGndeXztD1mxsN6QViRHDJLpUMQA5vk9 M5Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YDgHvX6kdTW0KFLq0oNaXmkJZmBD7/NAvLsQPGWEqiA=; b=pBqHevsxuP0uDIe2FVkjrpbtHQGNZPW3q4E2DkfoRVGVzKeZ0mtmrhjDz3udh5GUGy EK5LAE7monTRAlVC6WZRx6q//o9HXilHd+7xU4tWSJQUaxbGe1qmyovxNuo90IL2gxe7 PV6MK02WjQnu9gAi/Xgt2E0iImg57rznGeLHwUP4LfvgEICrP5MEqwUpt62v+iXCpeL8 CVDLYbqOgKr3Uw2aHUI4K6KfE6oXewXS7WBDQejYcOQqx3GD3BwT4KgNyKamaBqsdvA2 Bo1Io8HpF0DHBS1f2mubaLJyQgtw4uXO2Gir4JQq8qDJdS1jlqQlLFZDsG8zzDc/FSZD Q8bQ== X-Gm-Message-State: AGi0Pub+HiOpA3yLpeWEdAEvIvMDLyI4UTXscjWpeZO7DE+GHrC1qv+2 uerXVRcmh7eb7RcjWt3gLReBjizjXMNJsBpvVyU= X-Google-Smtp-Source: APiQypLV593o4cdHT/I/FyvgRIxlyLiWkkKxvZeVFDn67nOrqEts0Vt2CxC58AhksDt7lakbMlNlTCZQUMm9U6A+9z8= X-Received: by 2002:a5e:8815:: with SMTP id l21mr5990662ioj.59.1586335127519; Wed, 08 Apr 2020 01:38:47 -0700 (PDT) MIME-Version: 1.0 References: <1585464438-111285-1-git-send-email-orika@mellanox.com> <1585464438-111285-3-git-send-email-orika@mellanox.com> In-Reply-To: From: Jerin Jacob Date: Wed, 8 Apr 2020 14:08:31 +0530 Message-ID: To: Ori Kam Cc: Guy Kaneti , Jerin Jacob Kollanukkaran , "xiang.w.wang@intel.com" , "dev@dpdk.org" , Pavan Nikhilesh Bhagavatula , Shahaf Shuler , "hemant.agrawal@nxp.com" , Opher Reviv , Alex Rosenbaum , Dovrat Zifroni , Prasun Kapoor , "nipun.gupta@nxp.com" , "bruce.richardson@intel.com" , "yang.a.hong@intel.com" , "harry.chang@intel.com" , "gu.jian1@zte.com.cn" , "shanjiangh@chinatelecom.cn" , "zhangy.yun@chinatelecom.cn" , "lixingfu@huachentel.com" , "wushuai@inspur.com" , "yuyingxia@yxlink.com" , "fanchenggang@sunyainfo.com" , "davidfgao@tencent.com" , "liuzhong1@chinaunicom.cn" , "zhaoyong11@huawei.com" , "oc@yunify.com" , "jim@netgate.com" , "hongjun.ni@intel.com" , "j.bromhead@titan-ic.com" , "deri@ntop.org" , "fc@napatech.com" , "arthur.su@lionic.com" , Thomas Monjalon , Parav Pandit Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v1 2/4] regexdev: add regex core h file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > The rte_regex_dev which has enqueue() and dequeue() function pointer > > > should not be NOT allocated from hugepage > > > as per process it will have different enqueue() and dequeue() function > > > pointer value. Making it hugepage, another process > > > overwrites it. > > > > > > > > > > I didn't say this structure should be allocated from huge page. > > Unless I'm missing something, from memory this is exactly the same > > as if we had pointer to the priv. > > > > Private data should be allocated from the hugepage so that multiple > processes can access it. > > Whereas the memory that contains the enqueue() and dequeue() should not > be from hugepage. > > So both can not be from the same memory. Right? > > > > Yes you are right, in current implementation the idea was to support only > single process. > But I will update this code, to make it more like ethdev. > Thanks for understanding. We would like to avoid rework when we add multi-process. Please check the [re]configure the function and it memory allocation requirement for storing the queue pointers as well from ethdev subsystem(in fact, all existing subsystem has same scheme).