From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC8D2A04FA; Tue, 9 Jun 2020 06:42:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 26C5E2BAB; Tue, 9 Jun 2020 06:42:21 +0200 (CEST) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id 32CB62B89 for ; Tue, 9 Jun 2020 06:42:20 +0200 (CEST) Received: by mail-io1-f67.google.com with SMTP id k8so8963624iol.13 for ; Mon, 08 Jun 2020 21:42:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zqL/S7khburgOjKacqwFxD66I+2ypSXXwzguEDpM5Ns=; b=IqJrQqDiCBfnnU4FGYs42ryesjn1yC0ebbTrYwm5+bOV+OnVMumqF4pxvKnINM/rPW 22UCP4Q/wuUjsWbAuiWSy9QSRlRGmdNq7xluNpFSasL3s7Q4bOIVJpWtYdoyRMNAC0Ro q/cqRcE/ZW0S088WIrHX3aIeosvXr4w+yOjHdDZe4JQOjmsMFBgMMGM+0kVuMLz2abBk w/GJ0rMFXFOBJ9PzGp1HEZlYqjYLUxcXTZeuIUb6SOa8hDkCzvnWFOPLXSVKObBbiBnv WiCMQIUmcvdDrKPauTlGaQvmizLr9to9yfzRsCDF2a+Z2fadNBK1LaEffftRMZUAj+i4 728Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zqL/S7khburgOjKacqwFxD66I+2ypSXXwzguEDpM5Ns=; b=USw6u/tjOfrecr0ZVYsZdiDWjcSYm0seKoESPk5a7NmDTg5fiE/xRnLs8/y66jZj5q INIOD8jiOfQv2xBrTpl8aryAsuapqebd4ifOkaSqJukiuXOji/48cCxaqCVhmGb9kJD3 F3ZlLihOo4AcOv9ByNHJERVjJpRQXsfNM2S4eXrtc73LIfTGZFHqdpgl9q8a7kPdcyOE puwWgXuWXcJHS5qIYPT1u0vkY5CDcxeZVOmdHrA56sOpBzUt1OXZObcngsXO7VsaG+Xd 1qkxL/GPoKWavmVofZeZzRxZqWSS0mIngMKph1E1JiCINAN5TgEtOtD//Pc1svM3HjUJ L+mQ== X-Gm-Message-State: AOAM530MrfHKElkmt3EnvonmJUWULeZFeBdMGAwT+fYoBEmJw0+dF74/ rYTx1VSQhordDzfsYe3V62xpfzIObRlZ07SQAdQ= X-Google-Smtp-Source: ABdhPJxVxXFQW7BCRsAwN1FKyPwW+ga12jy4PNvfYlPUe6iY4P9Cv71b8x4M52gv3Y+P6/reiqk8KPcQeUU6DyVXl1g= X-Received: by 2002:a05:6602:2001:: with SMTP id y1mr24215090iod.94.1591677739387; Mon, 08 Jun 2020 21:42:19 -0700 (PDT) MIME-Version: 1.0 References: <20200608164640.189755-1-bruce.richardson@intel.com> <20200608121723.7a042105@hermes.lan> In-Reply-To: <20200608121723.7a042105@hermes.lan> From: Jerin Jacob Date: Tue, 9 Jun 2020 10:12:03 +0530 Message-ID: To: Stephen Hemminger Cc: Bruce Richardson , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH RFC] devtools: increase default line length to 100 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jun 9, 2020 at 12:47 AM Stephen Hemminger wrote: > > On Mon, 8 Jun 2020 17:46:40 +0100 > Bruce Richardson wrote: > > > Rather than continuing to recommend an 80-char line limit, let's take a hint > > from the Linux kernel[1] and aim for an 100-char recommended limit instead. > > > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bdc48fa11e46f867ea4d75fa59ee87a7f48be144 > > > > Signed-off-by: Bruce Richardson > > --- > > devtools/checkpatches.sh | 2 +- > > doc/guides/contributing/coding_style.rst | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh > > index 158087f1c..4970ed830 100755 > > --- a/devtools/checkpatches.sh > > +++ b/devtools/checkpatches.sh > > @@ -15,7 +15,7 @@ VALIDATE_NEW_API=$(dirname $(readlink -f $0))/check-symbol-change.sh > > # Codespell can also be enabled by setting DPDK_CHECKPATCH_CODESPELL to a valid path > > # to a dictionary.txt file if dictionary.txt is not in the default location. > > codespell=${DPDK_CHECKPATCH_CODESPELL:-enable} > > -length=${DPDK_CHECKPATCH_LINE_LENGTH:-80} > > +length=${DPDK_CHECKPATCH_LINE_LENGTH:-100} > > > > # override default Linux options > > options="--no-tree" > > diff --git a/doc/guides/contributing/coding_style.rst b/doc/guides/contributing/coding_style.rst > > index 4efde93f6..1db3a7bbe 100644 > > --- a/doc/guides/contributing/coding_style.rst > > +++ b/doc/guides/contributing/coding_style.rst > > @@ -21,7 +21,7 @@ The rules and guidelines given in this document cannot cover every situation, so > > * In the case of creating new files, the style should be consistent within each file in a given directory or module. > > * The primary reason for coding standards is to increase code readability and comprehensibility, therefore always use whatever option will make the code easiest to read. > > > > -Line length is recommended to be not more than 80 characters, including comments. > > +Line length is recommended to be not more than 100 characters, including comments. > > [Tab stop size should be assumed to be 8-characters wide]. > > > > .. note:: > > I would even support going to 120 characters. > > Acked-by: Stephen Hemminger Acked-by: Jerin Jacob