DPDK patches and discussions
 help / color / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: "McDaniel, Timothy" <timothy.mcdaniel@intel.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
	Mattias Rönnblom <mattias.ronnblom@ericsson.com>,
	 dpdk-dev <dev@dpdk.org>, Gage Eads <gage.eads@intel.com>,
	 "Van Haaren, Harry" <harry.van.haaren@intel.com>
Subject: Re: [dpdk-dev] [PATCH 02/27] eventdev: do not pass disable_implicit_release bit to trace macro
Date: Tue, 11 Aug 2020 23:18:37 +0530
Message-ID: <CALBAE1Nujffcv-f_71BnUoJPu5po3eW3vDBKZPfoFQdpd1XTyA@mail.gmail.com> (raw)
In-Reply-To: <1596138614-17409-3-git-send-email-timothy.mcdaniel@intel.com>

On Fri, Jul 31, 2020 at 1:23 AM McDaniel, Timothy
<timothy.mcdaniel@intel.com> wrote:
>
> From: "McDaniel, Timothy" <timothy.mcdaniel@intel.com>
>
> Previous implementation traced u8 disable_impl_release, which
> is now a bit field contained in the new u32 event_port_cfg
> field.
>
> Signed-off-by: McDaniel, Timothy <timothy.mcdaniel@intel.com>
> ---
>  lib/librte_eventdev/rte_event_crypto_adapter.c |    2 +-
>  lib/librte_eventdev/rte_event_eth_tx_adapter.c |    5 +++--
>  lib/librte_eventdev/rte_eventdev.c             |    3 +--
>  lib/librte_eventdev/rte_eventdev_trace.h       |    9 +++++----
>  4 files changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/lib/librte_eventdev/rte_event_crypto_adapter.c b/lib/librte_eventdev/rte_event_crypto_adapter.c
> index 8f25933..2717857 100644
> --- a/lib/librte_eventdev/rte_event_crypto_adapter.c
> +++ b/lib/librte_eventdev/rte_event_crypto_adapter.c
> @@ -269,7 +269,7 @@ struct crypto_queue_pair_info {
>         event_crypto_adapter[id] = adapter;
>
>         rte_eventdev_trace_crypto_adapter_create(id, dev_id, adapter, conf_arg,
> -               mode);
> +                                                mode);

# Be careful about, unwanted line changes in the series.
If you would like to fix some coding standard stuff send a separate
patch. Please don't make
unnecessary line changes in the patch.
# Please make sure all patches pass check-git-log.sh and checkpatch.sh sanity.



>         return 0;
>  }
>
> diff --git a/lib/librte_eventdev/rte_event_eth_tx_adapter.c b/lib/librte_eventdev/rte_event_eth_tx_adapter.c
> index 8a72256..a8a010e 100644
> --- a/lib/librte_eventdev/rte_event_eth_tx_adapter.c
> +++ b/lib/librte_eventdev/rte_event_eth_tx_adapter.c
> @@ -943,8 +943,9 @@ static int txa_service_queue_del(uint8_t id,
>                 txa_dev_id_array[id] = TXA_INVALID_DEV_ID;
>                 return ret;
>         }
> +
>         rte_eventdev_trace_eth_tx_adapter_create(id, dev_id, NULL, port_conf,
> -               ret);
> +                                                ret);
>         txa_dev_id_array[id] = dev_id;
>         return 0;
>  }
> @@ -987,7 +988,7 @@ static int txa_service_queue_del(uint8_t id,
>         }
>
>         rte_eventdev_trace_eth_tx_adapter_create(id, dev_id, conf_cb, conf_arg,
> -               ret);
> +                                                ret);
>         txa_dev_id_array[id] = dev_id;
>         return 0;
>  }
> diff --git a/lib/librte_eventdev/rte_eventdev.c b/lib/librte_eventdev/rte_eventdev.c
> index db2f9b7..550de73 100644
> --- a/lib/librte_eventdev/rte_eventdev.c
> +++ b/lib/librte_eventdev/rte_eventdev.c
> @@ -816,6 +816,7 @@
>                 diag = rte_event_port_unlink(dev_id, port_id, NULL, 0);
>
>         rte_eventdev_trace_port_setup(dev_id, port_id, port_conf, diag);
> +
>         if (diag < 0)
>                 return diag;
>
> @@ -1425,10 +1426,8 @@ struct rte_eventdev *
>                 eventdev->data = eventdev_data;
>
>                 if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
> -
>                         strlcpy(eventdev->data->name, name,
>                                 RTE_EVENTDEV_NAME_MAX_LEN);
> -
>                         eventdev->data->dev_id = dev_id;
>                         eventdev->data->socket_id = socket_id;
>                         eventdev->data->dev_started = 0;
> diff --git a/lib/librte_eventdev/rte_eventdev_trace.h b/lib/librte_eventdev/rte_eventdev_trace.h
> index 4de6341..5dd72d9 100644
> --- a/lib/librte_eventdev/rte_eventdev_trace.h
> +++ b/lib/librte_eventdev/rte_eventdev_trace.h
> @@ -53,13 +53,14 @@
>  RTE_TRACE_POINT(
>         rte_eventdev_trace_port_setup,
>         RTE_TRACE_POINT_ARGS(uint8_t dev_id, uint8_t port_id,
> -               const struct rte_event_port_conf *port_conf, int rc),
> +               const struct rte_event_port_conf *port_conf,
> +               int rc),
>         rte_trace_point_emit_u8(dev_id);
>         rte_trace_point_emit_u8(port_id);
>         rte_trace_point_emit_i32(port_conf->new_event_threshold);
>         rte_trace_point_emit_u16(port_conf->dequeue_depth);
>         rte_trace_point_emit_u16(port_conf->enqueue_depth);
> -       rte_trace_point_emit_u8(port_conf->disable_implicit_release);
> +       rte_trace_point_emit_u32(port_conf->event_port_cfg);
>         rte_trace_point_emit_int(rc);
>  )
>
> @@ -165,7 +166,7 @@
>         rte_trace_point_emit_i32(port_conf->new_event_threshold);
>         rte_trace_point_emit_u16(port_conf->dequeue_depth);
>         rte_trace_point_emit_u16(port_conf->enqueue_depth);
> -       rte_trace_point_emit_u8(port_conf->disable_implicit_release);
> +       rte_trace_point_emit_u32(port_conf->event_port_cfg);
>         rte_trace_point_emit_ptr(conf_cb);
>         rte_trace_point_emit_int(rc);
>  )
> @@ -257,7 +258,7 @@
>         rte_trace_point_emit_i32(port_conf->new_event_threshold);
>         rte_trace_point_emit_u16(port_conf->dequeue_depth);
>         rte_trace_point_emit_u16(port_conf->enqueue_depth);
> -       rte_trace_point_emit_u8(port_conf->disable_implicit_release);
> +       rte_trace_point_emit_u32(port_conf->event_port_cfg);
>  )
>
>  RTE_TRACE_POINT(
> --
> 1.7.10
>

  reply index

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1593232671-5690-0-git-send-email-timothy.mcdaniel@intel.com>
2020-07-30 19:49 ` [dpdk-dev] [PATCH 00/27] Add Intel DLM PMD to 20.11 McDaniel, Timothy
2020-07-30 19:49   ` [dpdk-dev] [PATCH 01/27] eventdev: dlb upstream prerequisites McDaniel, Timothy
2020-08-11 17:44     ` Jerin Jacob
2020-07-30 19:49   ` [dpdk-dev] [PATCH 02/27] eventdev: do not pass disable_implicit_release bit to trace macro McDaniel, Timothy
2020-08-11 17:48     ` Jerin Jacob [this message]
2020-07-30 19:49   ` [dpdk-dev] [PATCH 03/27] event/dlb: add shared code version 10.7.9 McDaniel, Timothy
2020-08-11 18:22     ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran
2020-07-30 19:49   ` [dpdk-dev] [PATCH 04/27] event/dlb: add make and meson build infrastructure McDaniel, Timothy
2020-08-11 18:24     ` Jerin Jacob
2020-07-30 19:49   ` [dpdk-dev] [PATCH 05/27] event/dlb: add DLB documentation McDaniel, Timothy
2020-08-11 18:26     ` Jerin Jacob
2020-07-30 19:49   ` [dpdk-dev] [PATCH 06/27] event/dlb: add dynamic logging McDaniel, Timothy
2020-08-11 18:27     ` Jerin Jacob
2020-07-30 19:49   ` [dpdk-dev] [PATCH 07/27] event/dlb: add private data structures and constants McDaniel, Timothy
2020-07-30 19:49   ` [dpdk-dev] [PATCH 08/27] event/dlb: add definitions shared with LKM or shared code McDaniel, Timothy
2020-07-30 19:49   ` [dpdk-dev] [PATCH 09/27] event/dlb: add inline functions used in multiple files McDaniel, Timothy
2020-07-30 19:49   ` [dpdk-dev] [PATCH 10/27] event/dlb: add PFPMD-specific interface layer to shared code McDaniel, Timothy
2020-07-30 19:49   ` [dpdk-dev] [PATCH 11/27] event/dlb: add flexible PMD to device interfaces McDaniel, Timothy
2020-07-30 19:49   ` [dpdk-dev] [PATCH 12/27] event/dlb: add the PMD's public interfaces McDaniel, Timothy
2020-07-30 19:50   ` [dpdk-dev] [PATCH 13/27] event/dlb: add xstats support McDaniel, Timothy
2020-07-30 19:50   ` [dpdk-dev] [PATCH 14/27] event/dlb: add PMD self-tests McDaniel, Timothy
2020-07-30 19:50   ` [dpdk-dev] [PATCH 15/27] event/dlb: add probe McDaniel, Timothy
2020-07-30 19:50   ` [dpdk-dev] [PATCH 16/27] event/dlb: add infos_get and configure McDaniel, Timothy
2020-07-30 19:50   ` [dpdk-dev] [PATCH 17/27] event/dlb: add queue_def_conf and port_def_conf McDaniel, Timothy
2020-07-30 19:50   ` [dpdk-dev] [PATCH 18/27] event/dlb: add queue setup McDaniel, Timothy
2020-07-30 19:50   ` [dpdk-dev] [PATCH 19/27] event/dlb: add port_setup McDaniel, Timothy
2020-07-30 19:50   ` [dpdk-dev] [PATCH 20/27] event/dlb: add port_link McDaniel, Timothy
2020-07-30 19:50   ` [dpdk-dev] [PATCH 21/27] event/dlb: add queue_release and port_release McDaniel, Timothy
2020-07-30 19:50   ` [dpdk-dev] [PATCH 22/27] event/dlb: add port_unlink and port_unlinks_in_progress McDaniel, Timothy
2020-07-30 19:50   ` [dpdk-dev] [PATCH 23/27] event/dlb: add eventdev_start McDaniel, Timothy
2020-07-30 19:50   ` [dpdk-dev] [PATCH 24/27] event/dlb: add timeout_ticks, dump, xstats, and selftest McDaniel, Timothy
2020-07-30 19:50   ` [dpdk-dev] [PATCH 25/27] event/dlb: add enqueue and its burst variants McDaniel, Timothy
2020-07-30 19:50   ` [dpdk-dev] [PATCH 26/27] event/dlb: add dequeue, dequeue_burst, and variants McDaniel, Timothy
2020-07-30 19:50   ` [dpdk-dev] [PATCH 27/27] event/dlb: add eventdev_stop and eventdev_close McDaniel, Timothy
2020-06-27  4:37 [dpdk-dev] [PATCH 00/27] event/dlb Intel DLB PMD Tim McDaniel
2020-06-27  4:37 ` [dpdk-dev] [PATCH 02/27] eventdev: do not pass disable_implicit_release bit to trace macro Tim McDaniel
  -- strict thread matches above, loose matches on Subject: below --
2020-06-12 21:24 [dpdk-dev] [PATCH 00/27] V1 event/dlb add Intel DLB PMD McDaniel, Timothy
2020-06-12 21:24 ` [dpdk-dev] [PATCH 02/27] eventdev: do not pass disable_implicit_release bit to trace macro McDaniel, Timothy

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALBAE1Nujffcv-f_71BnUoJPu5po3eW3vDBKZPfoFQdpd1XTyA@mail.gmail.com \
    --to=jerinjacobk@gmail.com \
    --cc=dev@dpdk.org \
    --cc=gage.eads@intel.com \
    --cc=harry.van.haaren@intel.com \
    --cc=jerinj@marvell.com \
    --cc=mattias.ronnblom@ericsson.com \
    --cc=timothy.mcdaniel@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox