From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A127459D8; Thu, 19 Sep 2024 20:19:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D7B46406FF; Thu, 19 Sep 2024 20:19:17 +0200 (CEST) Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) by mails.dpdk.org (Postfix) with ESMTP id 823214026B for ; Thu, 19 Sep 2024 20:19:16 +0200 (CEST) Received: by mail-oi1-f177.google.com with SMTP id 5614622812f47-3e03f0564c6so837152b6e.2 for ; Thu, 19 Sep 2024 11:19:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726769956; x=1727374756; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9tXJYhQ04N1bmm9VsjEIh81mkz/asAZVvLHxfJnSYIs=; b=j+hb0DPMB7j/4Stts08ujUegaL34G44ni+N7tJo205nehwxY25xNEajI4mjq2/rRRu mDI0QnuBjQp44Mf7kf9EYWIjMF4Gz0nb7Tg6ma20iWhMxzULwcb1X5UFWetN4M5cYZ3F TbOnpOkkQH0AcHlYNXcGAKVUXaKu/T5ih1+kHmtUaTOzuqib2vWy9UELS+wNBAmGS4Oa KbRMZmnZt2I2eR/0IYOh7O9b7H1lueRhY1ORtGkmI+zwoVGFnC/5o0b0WJYAk2GkG43h VAxg5KU4Rc6DHoIIfOu5BPXwc5NpZYAFQ4CEKJpsp5TOPtjAR/MuFbCoClyKLTs0TSQJ AYNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726769956; x=1727374756; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9tXJYhQ04N1bmm9VsjEIh81mkz/asAZVvLHxfJnSYIs=; b=HNKehbWrDwN1YLagUamM9ZQ3VHAm1kV7A1JwrndenBaYF28oLLzWdagwEUMEt2aiYY OrHk2+pkipuA6LmpUiI/v8aHEt6OXpAUazOEKXrKgNidejuT88OIZ3C3q+zy21gJP5gL Yu9FZOcvmfcPgM1vZQ5IUaaTGhI7ypWg9aUYRSPPNr8W2narUSnZR2JmYKCgI77wHreG gCVG6i+EKRs54C65xX8xyZEKeSDMwbesCap+9ChEkATHtsU8pvWRty3Qpn8LZPYt7zH/ fR15j5LND6ItYjgQnzVlxB//WpfRON/PxN/up1QVZ/8jY5bHIdkBkQSjrj7SqJx2pawF /AzA== X-Gm-Message-State: AOJu0YzmwOJJDBEUnvH2WGvPVow+FF9LNA7irndr30LDqQcqpu2eTLLc hghY1lHV7ADs4lO0DOIFav1n9Y2AYxiBti++sdNgI0zIUFT+4NH80nU+n8Pjc+L+Xl62jY7uYcr O9AEX22iKQwx2BbcNoIEZ8WQdHpg= X-Google-Smtp-Source: AGHT+IGJgUeNppz2joaucZTX6E3F4bmcUmNMZ4SClgc0DStCSQSNaCy1g6Hm/rktXzDpymH4jACA0lgZ96v+gLQ39Go= X-Received: by 2002:a05:6808:1a25:b0:3e0:4c92:401a with SMTP id 5614622812f47-3e271b6c8e1mr349374b6e.4.1726769955666; Thu, 19 Sep 2024 11:19:15 -0700 (PDT) MIME-Version: 1.0 References: <20240827053259.12033-1-vattunuru@marvell.com> In-Reply-To: <20240827053259.12033-1-vattunuru@marvell.com> From: Jerin Jacob Date: Thu, 19 Sep 2024 23:48:49 +0530 Message-ID: Subject: Re: [PATCH] net/octeon_ep: add device removal event callback To: Vamsi Krishna Cc: dev@dpdk.org, jerinj@marvell.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Aug 27, 2024 at 11:03=E2=80=AFAM Vamsi Krishna wrote: > > From: Vamsi Attunuru > > Patch adds an event callback to catch any device removal Please remove patch. > event occurred during driver probe. This callback helps > in terminating the execution if there is any device removal > event during the driver probe. > > Patch also moves global register configuration into dev_configure() Please remove patch. > routine and also validates register reads for any invalid > return values from hardware during driver probe. > > Signed-off-by: Vamsi Attunuru > --- > Depends-on: patch-142958 ("net/octeon_ep: extend mailbox functionality") > > drivers/net/octeon_ep/cnxk_ep_vf.c | 2 + > drivers/net/octeon_ep/otx2_ep_vf.c | 2 + > drivers/net/octeon_ep/otx_ep_ethdev.c | 58 +++++++++++++++++++-------- > drivers/net/octeon_ep/otx_ep_mbox.c | 11 +++++ > drivers/net/octeon_ep/otx_ep_vf.c | 2 + Update the release notes for this new feature. > 5 files changed, 59 insertions(+), 16 deletions(-) > > diff --git a/drivers/net/octeon_ep/cnxk_ep_vf.c b/drivers/net/octeon_ep/c= nxk_ep_vf.c > index 39b28de2d0..68b89fce4f 100644 > --- a/drivers/net/octeon_ep/cnxk_ep_vf.c > +++ b/drivers/net/octeon_ep/cnxk_ep_vf.c > @@ -408,6 +408,8 @@ cnxk_ep_vf_setup_device(struct otx_ep_device *otx_ep) > > /* Get IOQs (RPVF] count */ > reg_val =3D oct_ep_read64(otx_ep->hw_addr + CNXK_EP_R_IN_CONTROL(= 0)); > + if (reg_val =3D=3D (uint64_t)-1) Use UINT64_MAX from across the patch.