From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7465EA04AB; Thu, 7 Nov 2019 19:55:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9BA8F1BFBB; Thu, 7 Nov 2019 19:55:45 +0100 (CET) Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by dpdk.org (Postfix) with ESMTP id 0D64C1BFBA for ; Thu, 7 Nov 2019 19:55:44 +0100 (CET) Received: by mail-io1-f68.google.com with SMTP id s3so3499674ioe.3 for ; Thu, 07 Nov 2019 10:55:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9g10upjzZ7eVMpO4xhUZAzLoTMLD5oDMicWI5vYSR1A=; b=L61xBA3oS9dDw0UQdcL53sK3x7y1t44yLzgfPLbt+TTtCIvJnlYWNFTYbYMUk05LhH RrMYOFkPvNDpw66UkEHSwmbF+alGjxKEJFKTk0yjvAcTaRSPIwwcjoyApFIx/fLedgmj gcupAW+Km3/SJnBoGC/SAIA9xyWmDPVPxRmQPBLAh4iyzSaaJgcIuyNCvl/BN34Inrgn sObYr75CUqq4+kqRdpyQ6dWbQcW3e/JqQEDXeHWHZgpDxo+/GcdbcM+9IcxdOIdQ5GcM W9dCWRPR0vABRKYEI5GfVWgU23phs/gC4uZdVd+UdW5d3EHAsw5QNMvmaLBNlWbMOxNd SVNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9g10upjzZ7eVMpO4xhUZAzLoTMLD5oDMicWI5vYSR1A=; b=IQh1WQmDmRs0/gZItrx4bgzenYBnJOpn4LDi2gZgrqFoaKiTBs1E+h9W9dNFJw9EUH v14z2bKt2cumMRbbP+8LOX+s9afROd37tta0dHVC929dVDbP/uuMiWqpUnKBBQEo/aJP eROIRHVuHa9M9Re9x9qhi4bksTzk96TrYtd+iaMLoeI8ne/9FpMWPWgl492BQwQDjnMC O7vYBUJBuR+Pk3sASBS3owTkQaJVCs48sip/EURd/mmQgDOfqNvmXDFKQbxEG24hH0hv eVt1SvfYLlUHd8TpWOdif6jTKSoXhKtGe1bTwtZposyM/jqHisr6XK931VMpzrImg4g8 l/pg== X-Gm-Message-State: APjAAAV3psqmaAB7fqYgxxuCQgUBdw5m8tYzXrHfOq5FRjGADrQHkHc1 GLXYOO4qS2MtgTFN9gmdZ7dd1tK8FdWOzNSTqaQ= X-Google-Smtp-Source: APXvYqxZ5xADhFZCP+UrPAbTqrknA8FX2npZSvjciANm/o9qzCLoDV8OTUkTPCYoE83IMcHYUNOR/jexIsy7/7HAJig= X-Received: by 2002:a5d:8056:: with SMTP id b22mr4820887ior.60.1573152942927; Thu, 07 Nov 2019 10:55:42 -0800 (PST) MIME-Version: 1.0 References: <20191029153722.4547-1-pbhagavatula@marvell.com> <20191106191803.15098-1-pbhagavatula@marvell.com> <20191106191803.15098-9-pbhagavatula@marvell.com> In-Reply-To: From: Jerin Jacob Date: Fri, 8 Nov 2019 00:25:32 +0530 Message-ID: To: Ferruh Yigit Cc: Pavan Nikhilesh , Andrew Rybchenko , jerinj@marvell.com, thomas@monjalon.net, Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , John McNamara , Marko Kovacevic , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v16 8/8] app/testpmd: add command to set supported ptype mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 8 Nov, 2019, 12:10 am Ferruh Yigit, wrote: > On 11/6/2019 7:18 PM, pbhagavatula@marvell.com wrote: > > From: Pavan Nikhilesh > > > > Add command to set supported ptype mask. > > Usage: > > set port ptype_mask > /* *************** > > > > /* list of instructions */ > > @@ -19155,6 +19237,7 @@ cmdline_parse_ctx_t main_ctx[] = { > > (cmdline_parse_inst_t *)&cmd_show_vf_stats, > > (cmdline_parse_inst_t *)&cmd_clear_vf_stats, > > (cmdline_parse_inst_t *)&cmd_show_port_supported_ptypes, > > + (cmdline_parse_inst_t *)&cmd_set_port_ptypes, > > (cmdline_parse_inst_t *)&cmd_ptype_mapping_get, > > (cmdline_parse_inst_t *)&cmd_ptype_mapping_replace, > > (cmdline_parse_inst_t *)&cmd_ptype_mapping_reset, > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > > index 5ba974162..812aebf35 100644 > > --- a/app/test-pmd/testpmd.c > > +++ b/app/test-pmd/testpmd.c > > @@ -2024,6 +2024,7 @@ start_port(portid_t pid) > > queueid_t qi; > > struct rte_port *port; > > struct rte_ether_addr mac_addr; > > + static uint8_t clr_ptypes = 1; > > > > if (port_id_is_invalid(pid, ENABLED_WARN)) > > return 0; > > @@ -2153,6 +2154,10 @@ start_port(portid_t pid) > > } > > } > > configure_rxtx_dump_callbacks(verbose_level); > > + if (clr_ptypes) { > > + clr_ptypes = 0; > > + rte_eth_dev_set_ptypes(pi, RTE_PTYPE_UNKNOWN, > NULL, 0); > > + } > > I am not sure about this command, we have now capability to set/disable > ptypes > on demand, why disabling them by default? > As forward engines are not using the ptype offload. If a specific forward mode need the offload, it can be enabled. >