DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: Hanumanth Pothula <hpothula@marvell.com>
Cc: Nithin Dabilpuram <ndabilpuram@marvell.com>,
	Kiran Kumar K <kirankumark@marvell.com>,
	 Sunil Kumar Kori <skori@marvell.com>,
	Satha Rao <skoteshwar@marvell.com>, dpdk-dev <dev@dpdk.org>,
	Jerin Jacob <jerinj@marvell.com>
Subject: Re: [PATCH] common/cnxk: add lower bound check for SSO resources
Date: Fri, 10 Jun 2022 14:58:51 +0530	[thread overview]
Message-ID: <CALBAE1Nw-UVy9FSdxTnnrJFdznfes5O1=+2bquddAJwdUQUTow@mail.gmail.com> (raw)
In-Reply-To: <20220531121950.3511727-1-hpothula@marvell.com>

On Tue, May 31, 2022 at 5:50 PM Hanumanth Pothula <hpothula@marvell.com> wrote:
>
> Observing a crash when the user runs the second test case, with the
> first test case using all HWGRP and HWS, SSO resources. This happens
> as there are no HWGRP and HWS resources left for the second test case.
>
> Make sure to process a test case only when valid HWGRPS and HWS
> are present by adding lower bound check for HWGRPS and HWS.
>
> Signed-off-by: Hanumanth Pothula <hpothula@marvell.com>

Applied to dpdk-next-net-eventdev/for-main. Thanks

> ---
>  drivers/common/cnxk/roc_sso.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/common/cnxk/roc_sso.c b/drivers/common/cnxk/roc_sso.c
> index f8a0a96533..8997e6f999 100644
> --- a/drivers/common/cnxk/roc_sso.c
> +++ b/drivers/common/cnxk/roc_sso.c
> @@ -598,9 +598,9 @@ roc_sso_rsrc_init(struct roc_sso *roc_sso, uint8_t nb_hws, uint16_t nb_hwgrp)
>         struct sso_lf_alloc_rsp *rsp_hwgrp;
>         int rc;
>
> -       if (roc_sso->max_hwgrp < nb_hwgrp)
> +       if (!nb_hwgrp || roc_sso->max_hwgrp < nb_hwgrp)
>                 return -ENOENT;
> -       if (roc_sso->max_hws < nb_hws)
> +       if (!nb_hws || roc_sso->max_hws < nb_hws)
>                 return -ENOENT;
>
>         rc = sso_rsrc_attach(roc_sso, SSO_LF_TYPE_HWS, nb_hws);
> --
> 2.25.1
>

      reply	other threads:[~2022-06-10  9:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-31 12:19 Hanumanth Pothula
2022-06-10  9:28 ` Jerin Jacob [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALBAE1Nw-UVy9FSdxTnnrJFdznfes5O1=+2bquddAJwdUQUTow@mail.gmail.com' \
    --to=jerinjacobk@gmail.com \
    --cc=dev@dpdk.org \
    --cc=hpothula@marvell.com \
    --cc=jerinj@marvell.com \
    --cc=kirankumark@marvell.com \
    --cc=ndabilpuram@marvell.com \
    --cc=skori@marvell.com \
    --cc=skoteshwar@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).