From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EBD14A04B6; Wed, 19 Jan 2022 17:26:25 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C7F7541165; Wed, 19 Jan 2022 17:26:25 +0100 (CET) Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) by mails.dpdk.org (Postfix) with ESMTP id 700CB41147 for ; Wed, 19 Jan 2022 17:26:24 +0100 (CET) Received: by mail-io1-f54.google.com with SMTP id s11so3408113ioe.12 for ; Wed, 19 Jan 2022 08:26:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kY7t4ivLRNL/IgHB/V4caKeOL9qojudcUDFaxGfaL4U=; b=CqxPddq9mI3dsoeP9GzhJMLxQd+EVIP/NUizLkAjGvDUZ/98PPzcQU1K/6nMUZBbzH zOkk4AtryZ0VgXAQfwiCkPO61OYay89Uu81KlMVI5fETpANSGAYxVFbEM7yLp4eMSyDB 7glM/DIhifqj3cz4Eaa8PQDvFoxwLofz+NI76UJ4oOtzECZpCHuPhrt/1AzhQb9SapOO qrOG42pMV+eH6aNW9GAUmb1ZRKABD5vynqRSOc6Tg9woUfxLNYH/b2S3xMUcDkkXQKcw boqXJTslgaflno3Ofl3f3m4RDLtGNyR2l9GLGHofEUV4QcuctZXUkzBkSKDO+6lh0X1o 14fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kY7t4ivLRNL/IgHB/V4caKeOL9qojudcUDFaxGfaL4U=; b=tNh72gL3Y6EpWJx8UR4RKdvDYORGpHYueBGH/QXbt4whjM8zhm6njAshxtihkoztr4 cBDVicOZN33IJsEcTPFWqXc7njYsu4GJCD1l3419ut0LZn7ql8sp5IMKO7JkyfJDax+1 6MULAiYrOJmUy3uec79wVOuyfuDBvJbleOuHpwQDjbzwTLfUhRKjW38MJS7SydkSCXJH Lt4Yk3LN0vM0Mk38oUp4rnT8a3ToJjPnrUrN1fiHhC2eL9xV0pDUve3k6EK26Qg/2aHj nAjWOh97ez+eJLd/zAMdmI9yrF+rE7Bxa+6TCjoxa+0znOOGgt6yjMkCN/Nj9AfAkHjN U1vg== X-Gm-Message-State: AOAM532WmYd9sm9rADRpK0xkEGkUd1YfZEaFXBrElGM3VSn/7pczGCiZ ueNCRwkvvgpr7xo6woDzOhakFqwpIS9uMW/E/Os= X-Google-Smtp-Source: ABdhPJz5ol7adOYBYOdepsnX3RzJvoY7P8lyKAH3ToJkoW6U/Pw2SNIIYX9i1WrVkLvrzAaKgk1JZOUoPDoJYkgpA3s= X-Received: by 2002:a5e:c319:: with SMTP id a25mr5515221iok.94.1642609583780; Wed, 19 Jan 2022 08:26:23 -0800 (PST) MIME-Version: 1.0 References: <20211209091342.27017-1-ndabilpuram@marvell.com> <20211209091342.27017-4-ndabilpuram@marvell.com> In-Reply-To: <20211209091342.27017-4-ndabilpuram@marvell.com> From: Jerin Jacob Date: Wed, 19 Jan 2022 21:55:57 +0530 Message-ID: Subject: Re: [PATCH 4/8] common/cnxk: reset stale values on error debug registers To: Nithin Dabilpuram , Ferruh Yigit Cc: Jerin Jacob , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , dpdk-dev , Harman Kalra Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Dec 9, 2021 at 2:44 PM Nithin Dabilpuram wrote: > > From: Harman Kalra > > LF's error debug registers like NIX_LF_SQ_OP_ERR_DBG, > NIX_LF_MNQ_ERR_DBG, NIX_LF_SEND_ERR_DBG captures debug > info for an error detected during LMT operation or meta > enqueue or after meta enqueue granted respectively. HW > sets a valid bit when info is captured and SW is expected > to clear this valid bit by writing 1, else these registers > will show stale values of first interrupt when occurred and > will never update with subsequent interrupts. > > Signed-off-by: Harman Kalra Acked-by: Jerin Jacob Applied to dpdk-next-net-mrvl/for-next-net. Thanks > --- > drivers/common/cnxk/roc_nix_irq.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/common/cnxk/roc_nix_irq.c b/drivers/common/cnxk/roc_nix_irq.c > index a5cd9d4..7dcd533 100644 > --- a/drivers/common/cnxk/roc_nix_irq.c > +++ b/drivers/common/cnxk/roc_nix_irq.c > @@ -202,9 +202,12 @@ nix_lf_sq_debug_reg(struct nix *nix, uint32_t off) > uint64_t reg; > > reg = plt_read64(nix->base + off); > - if (reg & BIT_ULL(44)) > + if (reg & BIT_ULL(44)) { > plt_err("SQ=%d err_code=0x%x", (int)((reg >> 8) & 0xfffff), > (uint8_t)(reg & 0xff)); > + /* Clear valid bit */ > + plt_write64(BIT_ULL(44), nix->base + off); > + } > } > > static void > -- > 2.8.4 >