From: Jerin Jacob <jerinjacobk@gmail.com>
To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
Cc: Ruifeng Wang <ruifeng.wang@arm.com>,
Shijith Thotton <sthotton@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>, "nd@arm.com" <nd@arm.com>
Subject: Re: [dpdk-dev] [EXT] [PATCH] event/cnxk: fix clang warning on Arm
Date: Wed, 30 Jun 2021 19:48:38 +0530 [thread overview]
Message-ID: <CALBAE1NwoRqQq=2VVkLWXogL-YPqngTaOv9m_z8wUkTKH_M=xg@mail.gmail.com> (raw)
In-Reply-To: <PH0PR18MB408634085CD356B07B2B3852DE0D9@PH0PR18MB4086.namprd18.prod.outlook.com>
On Fri, Jun 18, 2021 at 12:51 PM Pavan Nikhilesh Bhagavatula
<pbhagavatula@marvell.com> wrote:
>
>
>
> >-----Original Message-----
> >From: Ruifeng Wang <ruifeng.wang@arm.com>
> >Sent: Thursday, June 10, 2021 12:55 PM
> >To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>; Shijith
> >Thotton <sthotton@marvell.com>
> >Cc: dev@dpdk.org; nd@arm.com; Ruifeng Wang
> ><ruifeng.wang@arm.com>
> >Subject: [EXT] [PATCH] event/cnxk: fix clang warning on Arm
> >
> >External Email
> >
> >----------------------------------------------------------------------
> >Build with Clang-10 has warning:
> >drivers/event/cnxk/cnxk_tim_worker.h:372:23: warning: value size
> >does not match register size specified by the constraint and modifier [-
> >Wasm-operand-widths]
> > : [rem] "=&r"(rem)
> > ^
> >drivers/event/cnxk/cnxk_tim_worker.h:365:17: note: use constraint
> >modifier "w"
> > " ldxr %[rem], [%[crem]] \n"
> > ^~~~~~
> > %w[rem]
> >
> >Changed variable type to match register size, which placates clang.
> >
> >Fixes: 300b796262a1 ("event/cnxk: add timer arm routine")
> >Cc: pbhagavatula@marvell.com
> >
> >Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
>
> LGTM, thanks.
>
> Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Applied to dpdk-next-net-eventdev/for-main. Thanks
>
> >---
> > drivers/event/cnxk/cnxk_tim_worker.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/drivers/event/cnxk/cnxk_tim_worker.h
> >b/drivers/event/cnxk/cnxk_tim_worker.h
> >index 7caeb1a8fb..78e36ffafe 100644
> >--- a/drivers/event/cnxk/cnxk_tim_worker.h
> >+++ b/drivers/event/cnxk/cnxk_tim_worker.h
> >@@ -320,7 +320,7 @@ cnxk_tim_add_entry_mp(struct cnxk_tim_ring
> >*const tim_ring,
> > struct cnxk_tim_ent *chunk;
> > struct cnxk_tim_bkt *bkt;
> > uint64_t lock_sema;
> >- int16_t rem;
> >+ int64_t rem;
> >
> > __retry:
> > cnxk_tim_get_target_bucket(tim_ring, rel_bkt, &bkt,
> >&mirr_bkt);
> >--
> >2.25.1
>
prev parent reply other threads:[~2021-06-30 14:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 7:25 [dpdk-dev] " Ruifeng Wang
2021-06-18 7:21 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2021-06-30 14:18 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1NwoRqQq=2VVkLWXogL-YPqngTaOv9m_z8wUkTKH_M=xg@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=nd@arm.com \
--cc=pbhagavatula@marvell.com \
--cc=ruifeng.wang@arm.com \
--cc=sthotton@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).