From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1FEFA0A0F; Wed, 30 Jun 2021 16:19:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6CC6840141; Wed, 30 Jun 2021 16:19:05 +0200 (CEST) Received: from mail-il1-f179.google.com (mail-il1-f179.google.com [209.85.166.179]) by mails.dpdk.org (Postfix) with ESMTP id B0B9F40040 for ; Wed, 30 Jun 2021 16:19:04 +0200 (CEST) Received: by mail-il1-f179.google.com with SMTP id 3so3009782ilj.3 for ; Wed, 30 Jun 2021 07:19:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bPVXSFXz4D2il1IFxOLOXphoSC1ESPzzmnrx/QlMjRk=; b=aIfIIAU3+stDofgaFqegC4/vuY1tOIHaqGVEVMN4TcdeBscRr9zC6uuN3zehprzd2g hl0DXnEKjoaba8BiNHUY5Nmvypdo0Yi6t5FV9APszU7Qfc7KgzOGUUHA20v3tbFR0FPc 1VJS4UgJyac/Risl3xgohkQQlkVEFy/vQ3VpSuFGEWlrCv3S9IDGKfub7mdnSqNmNgsV PEW4Qju9epmeL5DLEzsKkhbm8dqEJBsi1jQ2RXR59iiChQLCAYH0EA0qF1T1SDKZhuCn TpsAO74/35OCB4vlbLJ1FenQQVpvFvlnNwqcd7cSjm23jKR5W3mVAdm3mfXKfr6TUNGM vQsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bPVXSFXz4D2il1IFxOLOXphoSC1ESPzzmnrx/QlMjRk=; b=hCdfNvyQKfJ/R7f1DyfGIqnpgj5xD8gZE3zNdID8/uWNeR78LpjJiKrwa/SuUpLXlN nqKe0/7zlQXf89/pz3NE7w3jVLtS0eNpL2nw83QXtB6wUH+4Bnc8iUW8JvD7NQiVdonl MUR9QwRoOlTI6qFh3uHb6AGwC//GaJMHAGU7b6JtU6VMHii/Yw6Erxc3elpBUAuE2IfE jwEdrdz+berS/htTpkJY+RMx11AO4ZOfBjmRQXmOwXETAhnsE18HPe5P+tRwTfUjqnMa pBN/MgMHp6Lu36/TwXBuKvMO2dqEMPM3pG9s3sszxIoI9JXXtj7e3+gxmEEcbPzz0a0f BL+A== X-Gm-Message-State: AOAM531ptPYwiGiMMSis/x0CRHwvnvtWIwqqmNWxnTF43DZVxiR90BJb UBlNglem7A5Vb5XEPVqFq09A8Ii2SO77HZHTAzI= X-Google-Smtp-Source: ABdhPJw/HHfO160QFsG9thq5bYrCRgFwp4bFeotQ1phjRKqzcKjYbTyaZaUMBCi4tDsbLx/YE1U5S+H/d/WQ5gBdmao= X-Received: by 2002:a05:6e02:13b0:: with SMTP id h16mr10426503ilo.271.1625062744119; Wed, 30 Jun 2021 07:19:04 -0700 (PDT) MIME-Version: 1.0 References: <20210610072511.232027-1-ruifeng.wang@arm.com> In-Reply-To: From: Jerin Jacob Date: Wed, 30 Jun 2021 19:48:38 +0530 Message-ID: To: Pavan Nikhilesh Bhagavatula Cc: Ruifeng Wang , Shijith Thotton , "dev@dpdk.org" , "nd@arm.com" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [EXT] [PATCH] event/cnxk: fix clang warning on Arm X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jun 18, 2021 at 12:51 PM Pavan Nikhilesh Bhagavatula wrote: > > > > >-----Original Message----- > >From: Ruifeng Wang > >Sent: Thursday, June 10, 2021 12:55 PM > >To: Pavan Nikhilesh Bhagavatula ; Shijith > >Thotton > >Cc: dev@dpdk.org; nd@arm.com; Ruifeng Wang > > > >Subject: [EXT] [PATCH] event/cnxk: fix clang warning on Arm > > > >External Email > > > >---------------------------------------------------------------------- > >Build with Clang-10 has warning: > >drivers/event/cnxk/cnxk_tim_worker.h:372:23: warning: value size > >does not match register size specified by the constraint and modifier [- > >Wasm-operand-widths] > > : [rem] "=&r"(rem) > > ^ > >drivers/event/cnxk/cnxk_tim_worker.h:365:17: note: use constraint > >modifier "w" > > " ldxr %[rem], [%[crem]] \n" > > ^~~~~~ > > %w[rem] > > > >Changed variable type to match register size, which placates clang. > > > >Fixes: 300b796262a1 ("event/cnxk: add timer arm routine") > >Cc: pbhagavatula@marvell.com > > > >Signed-off-by: Ruifeng Wang > > LGTM, thanks. > > Acked-by: Pavan Nikhilesh Applied to dpdk-next-net-eventdev/for-main. Thanks > > >--- > > drivers/event/cnxk/cnxk_tim_worker.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >diff --git a/drivers/event/cnxk/cnxk_tim_worker.h > >b/drivers/event/cnxk/cnxk_tim_worker.h > >index 7caeb1a8fb..78e36ffafe 100644 > >--- a/drivers/event/cnxk/cnxk_tim_worker.h > >+++ b/drivers/event/cnxk/cnxk_tim_worker.h > >@@ -320,7 +320,7 @@ cnxk_tim_add_entry_mp(struct cnxk_tim_ring > >*const tim_ring, > > struct cnxk_tim_ent *chunk; > > struct cnxk_tim_bkt *bkt; > > uint64_t lock_sema; > >- int16_t rem; > >+ int64_t rem; > > > > __retry: > > cnxk_tim_get_target_bucket(tim_ring, rel_bkt, &bkt, > >&mirr_bkt); > >-- > >2.25.1 >