From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D5DFDA00C4; Wed, 28 Sep 2022 14:23:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 47A6A4281E; Wed, 28 Sep 2022 14:23:34 +0200 (CEST) Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com [209.85.219.54]) by mails.dpdk.org (Postfix) with ESMTP id 7B1484280C for ; Wed, 28 Sep 2022 14:23:33 +0200 (CEST) Received: by mail-qv1-f54.google.com with SMTP id r14so1108072qvn.3 for ; Wed, 28 Sep 2022 05:23:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=q4TNUny5pc9TJQTjS9RblmhfjM2CjO6h0afXoayUWcE=; b=TovEATuMAmtNgjm0qlSXzf3h10tQJPy3A10GP5htSukHB+axYtdqLkWvoPhZQUHsXB n/TPX0w3eerJrzY8x2QJgOQwRLuStE6FSjAs61ThvA2ktzQ6ZH8Oc7ufyQtqtEBBYmKs ZhMTkhSpYj4Y6cAzWzIx52TuOp8hapjsqPtUkYZZCTO5mMMMwQPiUPb0NPh1Fw2TW8ST rJeBHBZHv0OTuyAl6UKttLroA8llZVGXUnKPX9DbzEd50LUynCnUQ8L51SpEuzU/tCiD pKe1epsfDh5iUjs898UjhCpotXAFARmsC7FoRjSv/qRfdezEtTYJTn/UQ4ojYKD4hM3q nNwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=q4TNUny5pc9TJQTjS9RblmhfjM2CjO6h0afXoayUWcE=; b=WpZdf1Y+o+ZqBmm2O7reYvu71FgO5ROnpJchZ7EoqSWwaGk9ZJbUHL6QEHuwPhVV9y 5rTQ9bxfsackOO8PeZXWf4ulYrt9d0iWDUwcpCjt6cWIZsXNkR8auB1Ffg5lrNpiAlYg hQqHqjybJEQcQIWW51yvXn51goIGexfJ5s9H7hhzgiEFrUjPrzeVCQDfHL1ZEVYECgKa qk+dUZRIlkj5cu3SxBcd1M+EVDrtklPu2G8OERIwM3layVLaygks9cj1hTszIgyMi4zz SfrTxN/gqT5IcFufAWHnYaN44pb9ugvfWSK/YinYm0OnfJGF+UJmE13ogD/E96jhv/xk /UoA== X-Gm-Message-State: ACrzQf2CRLRTpRYGwxhEQZtx6h0clSI60WRiWkxztDbcrMvQMaz9ip0Q fmN3hxJdzsYyCVMEQk/B5JSArmNgOjIGHzhQpDg= X-Google-Smtp-Source: AMsMyM70f0RNQ9jQ3vutGb6fxKiilGrt4IZMGNEEm9sOxItWQDvybcEy+CNa/7raCqX/k/IfNBGHjJuNn30qvq4Cw0I= X-Received: by 2002:a0c:f3d3:0:b0:4a0:86d9:1807 with SMTP id f19-20020a0cf3d3000000b004a086d91807mr25954554qvm.19.1664367812867; Wed, 28 Sep 2022 05:23:32 -0700 (PDT) MIME-Version: 1.0 References: <20220713130340.2886839-1-jerinj@marvell.com> <21900891.hxa6pUQ8Du@thomas> In-Reply-To: <21900891.hxa6pUQ8Du@thomas> From: Jerin Jacob Date: Wed, 28 Sep 2022 17:53:06 +0530 Message-ID: Subject: Re: [PATCH v2 1/1] ethdev: support congestion management To: Thomas Monjalon Cc: Bruce Richardson , Olivier Matz , Jerin Jacob , skori@marvell.com, Ferruh Yigit , Andrew Rybchenko , dev@dpdk.org, david.marchand@redhat.com, orika@nvidia.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Sep 28, 2022 at 5:38 PM Thomas Monjalon wrote: > > 28/09/2022 13:14, Jerin Jacob: > > On Tue, Sep 27, 2022 at 8:39 PM Bruce Richardson > > wrote: > > > > > > On Tue, Sep 27, 2022 at 04:36:18PM +0200, Thomas Monjalon wrote: > > > > > > > ++ > > > > > > > > I feel EAL is not the right place for CMAN definitions. > > > > > > > > After a discussion with Jerin, I understand we could use the same > > > > definitions in other API classes, not only ethdev. However I think this > > > > .h file should be better hosted in lib/ethdev/ with its own namespace > > > > rte_cman. Then other libs could include this rte_cman.h without having a > > > > strong dependency on ethdev. > > > > > > > > Deal? > > > > > > > Would rte_net also be an option? Alternatively, is this related to the work > > > > Looks like the net is a good option. Since it is just a header file > > any place would be OK. > > > > + @Olivier Matz > > > > Any objections to keeping rte_cman.h to lib/net? > > lib/net/ is supposed to be standardized packet headers definitions. Since it had lib/net/net_crc.h, I thought it is OK to keep it in lib/net. No strong opinion. I will keep it as lib/ethdev/rte_cman.h then. > >