From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5759DA0577; Mon, 13 Apr 2020 13:32:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B196C2A5D; Mon, 13 Apr 2020 13:32:22 +0200 (CEST) Received: from mail-il1-f194.google.com (mail-il1-f194.google.com [209.85.166.194]) by dpdk.org (Postfix) with ESMTP id BC556DE0 for ; Mon, 13 Apr 2020 13:32:21 +0200 (CEST) Received: by mail-il1-f194.google.com with SMTP id t11so8211148ils.1 for ; Mon, 13 Apr 2020 04:32:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=UxX57WwYrG5JOU5YYnOQe5NUNYcyN+nM3m8fNKigcw8=; b=LQN/DfUAGNgJiJlgKBGiwsavO2Qr/g5guE3gaB9wRXa+aBis1QKjUc9L0a3AYDcmW/ nLVeAIU1vkNjvWdUyFL1qklCy/bpdgkdBd/+D9Lqn2/OEme7XxI7E5SqK0Odhw346kt/ po9jd/Tt6fNWjsbsTh2Kb7/r52w0Hrkr2CXRl50cpKqaIaZMCwW4/cDI73Xu58ns51k0 KmhOU8AFZRzjeD34Uxf7wJlYmm1X1fUC3lXvIKj47jOlLqP2XU/cUjF2Jc6rEHszKyXc 5fGyBfXDIPeitjTomi+gAKS0j3NeqVSwt6N2vwr/qC84f+sKv7a/X2hDDxsLTDMwwtYi q94Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=UxX57WwYrG5JOU5YYnOQe5NUNYcyN+nM3m8fNKigcw8=; b=EcbI51Xwpzel1eNxXyS0SIvZND+Dbk1u6P+a8Zir7jXhpmVM5WRX7oV/XnM5YnEV6C t/sLGoCIlZzxK5FXlTbbpztEYwmgqy+E7R6YyriKukuy9oQMVq8CuOafSAp+I8K0OuKb 7RcYuKpUSziDMEJxb7jrRwRppZ1Arr0tCwsyQz+brig1aQUC0e0JEBPGOE4YmitERD00 LfgVv4uT9YTIiDCZBQniU/0Z1hvz6sGLNz773SWrqxszQoASaA8f9tXf656MeFfyVNfF qo3pLlbvjdt5HAnbthcPcQTkL5HzN9RnrBfKrsoIEwng60aYGIeF79VP80+zqjHds1hQ hI1A== X-Gm-Message-State: AGi0PubgOwJ9pZ5q6y4A9ORcBHYVYgk3JqgRdssuuCyYczyASmCCTIo7 VvfKXZYrIFewBfMARc9h+60s3mUuU5+/d3QF2iM= X-Google-Smtp-Source: APiQypJgvMhMz1HqUZ4V27NiVOLVxwlbBB0NA+o1qPDKOKHWmQVYMW9QtZYpm+LBIg7wulCCQMf+Dom7YevEclD1V0c= X-Received: by 2002:a92:cecd:: with SMTP id z13mr16487861ilq.271.1586777540971; Mon, 13 Apr 2020 04:32:20 -0700 (PDT) MIME-Version: 1.0 References: <1583114253-15345-1-git-send-email-xiangxia.m.yue@gmail.com> <1586444567-9311-1-git-send-email-xiangxia.m.yue@gmail.com> In-Reply-To: From: Jerin Jacob Date: Mon, 13 Apr 2020 17:02:04 +0530 Message-ID: To: Tonghao Zhang Cc: Olivier Matz , Andrew Rybchenko , Gage Eads , "Artem V. Andreev" , Jerin Jacob , Nithin Dabilpuram , Vamsi Attunuru , Hemant Agrawal , David Marchand , Anatoly Burakov , "Richardson, Bruce" , dpdk-dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH dpdk-dev v2 1/2] eal: introduce rte-init queue for libraries initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Apr 12, 2020 at 9:03 AM Tonghao Zhang wr= ote: > > On Sun, Apr 12, 2020 at 11:20 AM Tonghao Zhang = wrote: > > > > On Fri, Apr 10, 2020 at 9:11 PM Jerin Jacob wro= te: > > > > > > On Fri, Apr 10, 2020 at 11:48 AM Jerin Jacob = wrote: > > > > > > > > > > Three more items are missing in this patch > Can I add "Co-authored-by" for you ? We are not using that tag in DPDK. Feel free to add, Suggested-by: Jerin Jacob > > > > 1) Unit test case for new API > > > 2) Make the new API __rte_experimal > > Hi Jerin > > This API will be invoked in mempool, if use that prefix, there is a > > compile warning: > > include/rte_mempool.h:933:2: error: =E2=80=98rte_init_register=E2=80=99= is deprecated > > (declared at x86_64-native-linuxapp-gcc/include/rte_init.h:61): Symbol > > is not yet part of stable ABI [-Werror=3Ddeprecated-declarations] http://patches.dpdk.org/patch/68119/ will be applied soon. So it will not a problem,