From: Jerin Jacob <jerinjacobk@gmail.com>
To: Pavan Nikhilesh <pbhagavatula@marvell.com>
Cc: Jerin Jacob <jerinj@marvell.com>, dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] event/octeontx2: remove hotspots by prefetching data
Date: Thu, 31 Oct 2019 16:20:25 +0530 [thread overview]
Message-ID: <CALBAE1NxD+ZUUCX13H066adK8NhTy5hpyivLYQVdpst=sXyHwQ@mail.gmail.com> (raw)
In-Reply-To: <20191023160707.2329-1-pbhagavatula@marvell.com>
On Wed, Oct 23, 2019 at 9:37 PM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Recent profiling revealed few hotspots in octeontx2 event device
> driver add prefetch hints to reduce stalls.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Applied to dpdk-next-eventdev/master. Thanks.
> ---
> drivers/event/octeontx2/otx2_worker.h | 1 +
> drivers/event/octeontx2/otx2_worker_dual.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/event/octeontx2/otx2_worker.h b/drivers/event/octeontx2/otx2_worker.h
> index 6f7842199..092ba71f7 100644
> --- a/drivers/event/octeontx2/otx2_worker.h
> +++ b/drivers/event/octeontx2/otx2_worker.h
> @@ -280,6 +280,7 @@ otx2_ssogws_event_tx(struct otx2_ssogws *ws, struct rte_event ev[],
> struct rte_mbuf *m = ev[0].mbuf;
> const struct otx2_eth_txq *txq = otx2_ssogws_xtract_meta(m);
>
> + rte_prefetch_non_temporal(txq);
> /* Perform header writes before barrier for TSO */
> otx2_nix_xmit_prepare_tso(m, flags);
> otx2_ssogws_order(ws, !ev->sched_type);
> diff --git a/drivers/event/octeontx2/otx2_worker_dual.c b/drivers/event/octeontx2/otx2_worker_dual.c
> index ff68472ef..7016eee4a 100644
> --- a/drivers/event/octeontx2/otx2_worker_dual.c
> +++ b/drivers/event/octeontx2/otx2_worker_dual.c
> @@ -148,6 +148,7 @@ otx2_ssogws_dual_deq_ ##name(void *port, struct rte_event *ev, \
> struct otx2_ssogws_dual *ws = port; \
> uint8_t gw; \
> \
> + rte_prefetch_non_temporal(ws); \
> RTE_SET_USED(timeout_ticks); \
> if (ws->swtag_req) { \
> otx2_ssogws_swtag_wait((struct otx2_ssogws *) \
> --
> 2.17.1
>
prev parent reply other threads:[~2019-10-31 10:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 16:07 pbhagavatula
2019-10-31 10:50 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1NxD+ZUUCX13H066adK8NhTy5hpyivLYQVdpst=sXyHwQ@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=pbhagavatula@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).