From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9DFB4A0C45; Thu, 16 Sep 2021 16:36:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 81DAC4069E; Thu, 16 Sep 2021 16:36:52 +0200 (CEST) Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) by mails.dpdk.org (Postfix) with ESMTP id 3A74840151 for ; Thu, 16 Sep 2021 16:36:51 +0200 (CEST) Received: by mail-io1-f52.google.com with SMTP id a15so8155692iot.2 for ; Thu, 16 Sep 2021 07:36:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9ZyWBDeWW2Uhp4CTo0H+VMHwAm6BAoJPq8YBk0qsizE=; b=nNry9yaoZ0vIZQoGROrLCgfkrrr/1RsFYPuVz79jhuBTpF0OHo8/Yvw6n7wyJ93K/j 3TTtZFtaw0d+0ehpxxJqTqat2upYMQbWKFN+F8ngYRvPxtdT4aODLLH8RZlQBm4/Y6t0 9i2wVEyZpOMDKiRsOWrgA47RdtvB+z78dvaJ5DYOX4E7WwreW8F1YvX6jKmz9M5CpZSw rfUkjWkJ3SzALCY+sV3pM+2Diw2q5pVr9SZ0GvMeimKYDpyXlvybAZlKqCjiHFfGvs9i Km8YvNVR6Ho3QsbTaIPdTGgA+BaLaoilj6e6UiNZ/ZUT4Qqd8S3nXgYelZ3NRjS4zLRj 3GEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9ZyWBDeWW2Uhp4CTo0H+VMHwAm6BAoJPq8YBk0qsizE=; b=LrOWjUcNE1p4V4elbKJaVYXQsRNYOxpWdzRtBzYgk0yf0NUpmNjoC0mup0UYpEYb6d tRjZ6Qiow+qNuoexre1FXBUppUOBt+MOc4N4f5nq8DCct8FWAlIEKWAwivD8lwikdMCg o/o/7adnmPMc6w+QJsD10rANjO+oNnlGE8VUP/zI26LYSp6tQhyn/QGHqX6UKWvsaeRa pCdg9Brl5L0zMIbrQu3pThWCpPO9pq1NMBBLylUg16Jqwc+FkRuG3EAidcnZRLKMiU0B 9werU7VS78TwagYx//Gz4EbfIFuO95Mb2W+0XgJx+kS7gIzUSDVZ7GRA++TOAMfQZDtJ 4cvg== X-Gm-Message-State: AOAM5311tFH2myj7HnjDtgqmcoiwe/WdfaNYzmKSsLS4Hr1FkB9fS9K0 dgVPYVmfsVxoFe1pwQKufrJ7FFeIw1ooMO5+ctQ= X-Google-Smtp-Source: ABdhPJxc0kqEtifX7j0d/wlOWl3RiSNWsBhdFUSk/Ps9KTl6XbiYZd+DY8L1y3nL2DaKpoG9l+qDLdy0wg4cb3KQoN4= X-Received: by 2002:a6b:e410:: with SMTP id u16mr4509918iog.38.1631803010591; Thu, 16 Sep 2021 07:36:50 -0700 (PDT) MIME-Version: 1.0 References: <20210830140819.2610366-1-asekhar@marvell.com> <20210830162903.2736191-1-asekhar@marvell.com> <20210830162903.2736191-2-asekhar@marvell.com> In-Reply-To: <20210830162903.2736191-2-asekhar@marvell.com> From: Jerin Jacob Date: Thu, 16 Sep 2021 20:06:24 +0530 Message-ID: To: Ashwin Sekhar T K Cc: dpdk-dev , Jerin Jacob , Sunil Kumar Kori , Satha Koteswara Rao Kottidi , Pavan Nikhilesh , Kiran Kumar K , Satheesh Paul , Nithin Dabilpuram , Akhil Goyal Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 2/2] common/cnxk: avoid using stashing option of stype X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Aug 30, 2021 at 10:00 PM Ashwin Sekhar T K wrote: > > Avoid using stashing option of stype in NPA in cn10k-a0 stepping. > > This is a workaround for a HW Errata due to which NPA stashing operations > will never result in writing the data into L2 cache. But instead, it will > be written into LLC. > > Signed-off-by: Ashwin Sekhar T K Acked-by: Jerin Jacob > --- > drivers/common/cnxk/roc_nix_queue.c | 4 ++++ > drivers/common/cnxk/roc_nix_tm_ops.c | 7 +++++++ > drivers/common/cnxk/roc_npa.h | 2 +- > 3 files changed, 12 insertions(+), 1 deletion(-) > > diff --git a/drivers/common/cnxk/roc_nix_queue.c b/drivers/common/cnxk/roc_nix_queue.c > index 7e2f86eca7..76e439e7a9 100644 > --- a/drivers/common/cnxk/roc_nix_queue.c > +++ b/drivers/common/cnxk/roc_nix_queue.c > @@ -585,6 +585,10 @@ sqb_pool_populate(struct roc_nix *roc_nix, struct roc_nix_sq *sq) > > memset(&aura, 0, sizeof(aura)); > aura.fc_ena = 1; > + if (roc_model_is_cn9k() || roc_model_is_cn10ka_a0()) > + aura.fc_stype = 0x0; /* STF */ > + else > + aura.fc_stype = 0x3; /* STSTP */ > aura.fc_addr = (uint64_t)sq->fc; > aura.fc_hyst_bits = 0; /* Store count on all updates */ > rc = roc_npa_pool_create(&sq->aura_handle, blk_sz, NIX_MAX_SQB, &aura, > diff --git a/drivers/common/cnxk/roc_nix_tm_ops.c b/drivers/common/cnxk/roc_nix_tm_ops.c > index ed244d4214..f2173c9a58 100644 > --- a/drivers/common/cnxk/roc_nix_tm_ops.c > +++ b/drivers/common/cnxk/roc_nix_tm_ops.c > @@ -38,6 +38,13 @@ roc_nix_tm_sq_aura_fc(struct roc_nix_sq *sq, bool enable) > > req->aura.fc_ena = enable; > req->aura_mask.fc_ena = 1; > + if (roc_model_is_cn9k() || roc_model_is_cn10ka_a0()) { > + req->aura.fc_stype = 0x0; /* STF */ > + req->aura_mask.fc_stype = 0x0; /* STF */ > + } else { > + req->aura.fc_stype = 0x3; /* STSTP */ > + req->aura_mask.fc_stype = 0x3; /* STSTP */ > + } > > rc = mbox_process(mbox); > if (rc) > diff --git a/drivers/common/cnxk/roc_npa.h b/drivers/common/cnxk/roc_npa.h > index 3fc6192e57..1cf50e5c4e 100644 > --- a/drivers/common/cnxk/roc_npa.h > +++ b/drivers/common/cnxk/roc_npa.h > @@ -214,7 +214,7 @@ roc_npa_aura_batch_alloc_issue(uint64_t aura_handle, uint64_t *buf, > cmp.u = 0; > cmp.compare_s.aura = roc_npa_aura_handle_to_aura(aura_handle); > cmp.compare_s.drop = drop; > - cmp.compare_s.stype = ALLOC_STYPE_STSTP; > + cmp.compare_s.stype = ALLOC_STYPE_STF; > cmp.compare_s.dis_wait = dis_wait; > cmp.compare_s.count = num; > > -- > 2.32.0 >