From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 301FAA04AF; Mon, 4 May 2020 13:52:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4E14F1D161; Mon, 4 May 2020 13:52:39 +0200 (CEST) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id 5EAEA1C211; Mon, 4 May 2020 13:52:37 +0200 (CEST) Received: by mail-io1-f67.google.com with SMTP id z2so11916865iol.11; Mon, 04 May 2020 04:52:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=gR2xTNONnhVeQ6232/KBHia9UDjmwkkjdrlrlC8E0Nk=; b=nvduE0EO9unyhrgRGulziuStaPFGEaKYfGkO3bmOeyLzDDWuq2BJsVxXD6e890xXry Us4ga42HT0S1YgImf1iz1wD9+AZoJSjCEy39og+AwMwa8cNUfc8hZf+IPEzWg4XJPUoV jQPtz1z/BI8cIKmKJbujQvO9c9+i2o2UemTVTthBIO9FPbcXHBLksS41Z+nPoFOWKMqp U1l2taWICwV99NB/sOzRT41BWRzo+/3NZ6nDYebL0D/b/yY3IPpgLNwLBP0Zaz3yz3g7 3UZScsANfissfahoAkhz1fQ2reaof9wXow/HN95kEBQP+zzihSGowG6JOqoBsMhl67Z8 um7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=gR2xTNONnhVeQ6232/KBHia9UDjmwkkjdrlrlC8E0Nk=; b=glt63In3c25/NbMylpGE1bNufrd+WG62uqbuiUScNpYVWz39/uGY/TmLz3RmZV+qo9 s0dgoimEk2Q5+ssSXMTTE+Ps9FpOFrFYpCl/4HNH1LaXlsM5SycTVEye4h4IXSnIYtj1 1CKrRjx+J5USVLwsaxQP7v5YoD+yKuVUzaqd86Ov7J1h10JfZVmuBMZG6JJNhwEbB0t8 z/l60JaySxzBkUokel5R3F8IbWFilh1qoIrMGbi/Wa47Qz4+zLr2375iqptuEilKnsUw n+FeR6S4fEXJ9bGBLBL0xvfNhTVdqnEjaHuIcBZFPHYybCIGeALsh5MD/v2yuBGX0M04 S4rQ== X-Gm-Message-State: AGi0PuaXYF7VpmgZjhRfq8fN9MxbxW4iG5DnwhHQFuLY05CnGwPvrRVv zXiDRVBzpSWVyfCiLTEkRedmok/pNWJdZx5vXJk= X-Google-Smtp-Source: APiQypJNKXRen/Hv1QCi2CZAZIJilZ3ejt4lR656HV2aWCbiohxc9nGsu4gld/LXA47IP0Vmwq1yXVGr0EHb1Z/Ttno= X-Received: by 2002:a02:9a0d:: with SMTP id b13mr14429922jal.60.1588593156605; Mon, 04 May 2020 04:52:36 -0700 (PDT) MIME-Version: 1.0 References: <20200504093059.12458-1-hofors@lysator.liu.se> In-Reply-To: <20200504093059.12458-1-hofors@lysator.liu.se> From: Jerin Jacob Date: Mon, 4 May 2020 17:22:20 +0530 Message-ID: To: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= Cc: Jerin Jacob , dpdk-dev , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , dpdk stable , Venky Venkatesh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2] event/dsw: avoid reusing previously recorded events X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, May 4, 2020 at 3:01 PM Mattias R=C3=B6nnblom wrote: > > From: Mattias R=C3=B6nnblom > > Avoid reusing recorded events when performing a migration, since this > may make the migration selection logic pick an already-moved flow. > > Fixes: f6257b22e767 ("event/dsw: add load balancing") > Cc: stable@dpdk.org > > Reported-by: Venky Venkatesh > Signed-off-by: Mattias R=C3=B6nnblom > --- > V2: rebase Fixed following checkpatch warnings and applied to dpdk-next-eventdev/master. Thanks. WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #26: FILE: drivers/event/dsw/dsw_event.c:824: + if (seen_events_len < DSW_MAX_EVENTS_RECORDED) + return; WARNING:TABSTOP: Statements should start on a tabstop #27: FILE: drivers/event/dsw/dsw_event.c:825: + return; > drivers/event/dsw/dsw_event.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/event/dsw/dsw_event.c b/drivers/event/dsw/dsw_event.= c > index 832390373..367cf8590 100644 > --- a/drivers/event/dsw/dsw_event.c > +++ b/drivers/event/dsw/dsw_event.c > @@ -821,6 +821,9 @@ dsw_port_consider_emigration(struct dsw_evdev *dsw, > if (dsw->num_ports =3D=3D 1) > return; > > + if (seen_events_len < DSW_MAX_EVENTS_RECORDED) > + return; > + > DSW_LOG_DP_PORT(DEBUG, source_port->id, "Considering emigration.\= n"); > > /* Randomize interval to avoid having all threads considering > -- > 2.20.1 >