From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 788FFA0A0C; Mon, 28 Jun 2021 16:23:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 60A8F4069F; Mon, 28 Jun 2021 16:23:40 +0200 (CEST) Received: from mail-il1-f179.google.com (mail-il1-f179.google.com [209.85.166.179]) by mails.dpdk.org (Postfix) with ESMTP id 73E5940692 for ; Mon, 28 Jun 2021 16:23:39 +0200 (CEST) Received: by mail-il1-f179.google.com with SMTP id h3so17608671ilc.9 for ; Mon, 28 Jun 2021 07:23:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UCuKXkUoAeyzJd1wifs5YuIQyHboz2zIwVc4GFZfeo4=; b=Dsqjt7dIBigXdJByjiAhreqWtIaboHl/IM9BDTkDgkkk8hqT77oEqqAIyWFwzSOMUC gjx5MHroWpMAIlwGIuihhduPk5hpn5pyf14tmu0lO/vz+H5HxgHPSG8aI8ftoj/8ieHE NoUGVu6g4TlZw0B1ghK1NU+OAVhq4XenpHGQ+9xkyBPoG5WyyrojnEgCe2kVvQCMUHAq GoOYF0dfrCD0OltrVl6B7RC01wcOIfDJOTiq1oIJdyOqUIMwRKivdgYa6cxZnVk9n/mZ 3rMw6p9WoQ9c51JViPZXmJ7kAezW7AAiZJAX07E/Lpj802L+xET7WA80NblAf37h8gwH HIsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UCuKXkUoAeyzJd1wifs5YuIQyHboz2zIwVc4GFZfeo4=; b=aUlykifw3kp8bI2tt5bxitk3711bhucUMjIIIR529oCeQ2hXzwqsK+rHTuYJDsNZYj t+nfElmRO/Yqy+1Xwr+qJcOQItKzqPdJqyHXG7STWLnArs8TIqYkovNVKBP5p2DBjj4+ nl8tKEDjs93b0lNQwgJ58XFZ0apM2yhYOUSPhDG90vi5VbspGchMCiT7cuxApZqh6bpT yrWLsXOk4F8HgcVV9O5b3YbJzKXGS7ORY2Hr8CNHsESYZ1x9OuzNwvmlKyjhZMCLGvbI ov9+96SWvAIIFMJUi2NVd7d0RmlacrQ4bl1+0oR4wGEimuGsW52vG1I8OUmlv4HIwpxn 69+A== X-Gm-Message-State: AOAM530UgnjDAGRHQslxpsOKVRa+WjdGjMJmpT7i8uPe9XNIZE2W9lf1 H2EqPoCOGQzBLhKivBXG1WlXbdX3gwhR7/z8s1s= X-Google-Smtp-Source: ABdhPJwkqrv2Tt4Qw1CVCyz1Znj8Xi2+rZGqYjprTG5GmttrEZ46c2fnQu1p1itkWSsdknrmF1LWoud/2Xs+w6cWUEA= X-Received: by 2002:a05:6e02:13b0:: with SMTP id h16mr3149918ilo.271.1624890218893; Mon, 28 Jun 2021 07:23:38 -0700 (PDT) MIME-Version: 1.0 References: <20210610051352.48493-1-zhihongx.peng@intel.com> <20210615081205.101071-1-zhihongx.peng@intel.com> <8af553e7-29e1-b46d-dc68-32efaa17c9c0@intel.com> In-Reply-To: <8af553e7-29e1-b46d-dc68-32efaa17c9c0@intel.com> From: Jerin Jacob Date: Mon, 28 Jun 2021 19:53:12 +0530 Message-ID: To: "Burakov, Anatoly" Cc: David Marchand , "Lin, Xueqin" , "Peng, ZhihongX" , "Ananyev, Konstantin" , Stephen Hemminger , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [RFC v2] porting AddressSanitizer feature to DPDK X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jun 28, 2021 at 7:52 PM Burakov, Anatoly wrote: > > On 18-Jun-21 10:04 AM, David Marchand wrote: > > On Fri, Jun 18, 2021 at 9:49 AM Lin, Xueqin wrote: > >>>> Suggest listing demo code and tool capture information for user to try if > >>> tool works, also add this part into doc. > >>>> > >>>>> > >>>>> # Also, Please update the release note for this feature. > >>>> Sure, we can update the release note if code merge. > >>> > >>> Probably you can send v1 version next i.e change the RFC status to get > >>> merged. > >> > >> Sure, we will send v1 patch if no obvious objection for that, hope patch could receive some ACKs and could success to merge, thanks. > > > > How did you test this work? > > > > UNH recently started testing with ASAN and it reveals leaks just in > > the unit test. > > > > Merging these annotations will help catch more issues. > > But users will hit the current issues that we must fix first. > > > > As far as i can tell, the regular build is not affected by this patch, > so no issues will be hit until someone actually runs the test. IMO it's > better to merge it early to catch more issues than to gate the feature > on the condition that we fix all bugs unrelated to this feature first. +1 > > -- > Thanks, > Anatoly