Re: [PATCH] net/cnxk: add threshold validation for RED config

[Jerin Jacob <jerinjacobk@gmail.com>]

On Mon, Jan 2, 2023 at 10:14 PM <skori@marvell.com> wrote:
>
> From: Sunil Kumar Kori <skori@marvell.com>
>
> Validation is added to check minimum and maximum RED
> threshold values, passed by user.
>
> Fixes: b7d3a0fe71eb ("net/cnxk: support congestion management operations")
>
> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>

Updated the git commit as follows and applied to
dpdk-next-net-mrvl/for-next-net. Thanks


    net/cnxk: validate RED threshold config

    Added vaalidation to check minimum and maximum RED threshold
    values, passed by user.

    Fixes: b7d3a0fe71eb ("net/cnxk: support congestion management operations")
    CC: stable@dpdk.org

    Signed-off-by: Sunil Kumar Kori <skori@marvell.com>

> ---
>  drivers/net/cnxk/cnxk_ethdev_cman.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/cnxk/cnxk_ethdev_cman.c b/drivers/net/cnxk/cnxk_ethdev_cman.c
> index d5e647c64d..a7ccdfb756 100644
> --- a/drivers/net/cnxk/cnxk_ethdev_cman.c
> +++ b/drivers/net/cnxk/cnxk_ethdev_cman.c
> @@ -68,6 +68,11 @@ nix_cman_config_validate(struct rte_eth_dev *eth_dev, const struct rte_eth_cman_
>                 return -EINVAL;
>         }
>
> +       if (config->mode_param.red.min_th > config->mode_param.red.max_th) {
> +               plt_err("RED minimum threshold must be less or equal to maximum threshold");
> +               return -EINVAL;
> +       }
> +
>         return 0;
>  }
>
> --
> 2.25.1
>