From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B33D423FB; Tue, 17 Jan 2023 13:06:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DA30C400EF; Tue, 17 Jan 2023 13:06:12 +0100 (CET) Received: from mail-vk1-f173.google.com (mail-vk1-f173.google.com [209.85.221.173]) by mails.dpdk.org (Postfix) with ESMTP id 4D4EB400D4 for ; Tue, 17 Jan 2023 13:06:11 +0100 (CET) Received: by mail-vk1-f173.google.com with SMTP id e132so4347432vke.11 for ; Tue, 17 Jan 2023 04:06:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=IWqI+9mpDZdghsH12HPwR+AMUR+q8bBNtZLFNj1tmjo=; b=fTHp923B8D92YCGNSnDU8Z+8gc4d4E2iBbWsT2cJtrNBh0aM7cixSZSMOCMytweXPo CgQVqKibpZsYB5suSXd9vFi7nvgUmyfZoYWtbYq3H+mFIbvdWsY44VKQ5zWqBdDJeX5G J9KJjT5hB5juu+pAuh7PPGHsfE6zWihBOPfyCW6db0VRn+bQwyB/Z0iL8oIzowHb17Vp 7U+eYdQtTkVrelrSQyeqOtihI0oVKVC2o8AGKMeAUD/bL5fShbwHbJwY8MKW3lzI7bDl 6DLNyhGIdCpz5gUVyQMyuH8aCcxv/3tsIpiPugTpFXfzjV6RfXtsiizwP94aGJ2tTgkR 7S0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IWqI+9mpDZdghsH12HPwR+AMUR+q8bBNtZLFNj1tmjo=; b=3LJgMYf/PZH8v+GuPSz/tYejBz28jKlQQzdXKe+CVO29XmHGnXRWupCSdRh+wCr8e9 gPqzU2WN/qRKt6j/Ca2gJHbGJ0SxtQmm+XM4VdG1nbrr8bXQG6byXkQR9H+eITXmUHXx wOEOpcZM966N5c1Hl1BA5TkaGZVA/P9e9uVe/vla9WOANMJ1H21NZ75XoEdwOEPQ2EN/ H5sjXe8tv1BzKyQUc3I5f2aydiNNmDtQDSiPf3F3uGY3TLwd8dg+a0d9FWZrauJGzW5v yDbtopHSrf/jYtdYSeDF1I/Cec19Y8WSCwKDMkdACMQl4zLzyr0cuwQKu+Da0ztvVJfY x+Yg== X-Gm-Message-State: AFqh2krDSpMmaJsbTPe5JQJRwqU3oysjGtsyr5ggwvZXRn0nuS67ZDb8 qVAP7RCIU6WDNu97j1jmlcWfRwsIOlbHCGxBGAY= X-Google-Smtp-Source: AMrXdXuH/FUfU3Neon423qyfUd8uP/6CTWlxx+AhmBZVtB8gC/E+8lho0R+v/GdZ93hnmQDpoUll8hCUhCp3ZqdeI7Y= X-Received: by 2002:a1f:9e0d:0:b0:3e1:9d4e:e7d7 with SMTP id h13-20020a1f9e0d000000b003e19d4ee7d7mr273998vke.20.1673957170565; Tue, 17 Jan 2023 04:06:10 -0800 (PST) MIME-Version: 1.0 References: <20230102164353.110683-1-skori@marvell.com> In-Reply-To: <20230102164353.110683-1-skori@marvell.com> From: Jerin Jacob Date: Tue, 17 Jan 2023 17:35:44 +0530 Message-ID: Subject: Re: [PATCH] net/cnxk: add threshold validation for RED config To: skori@marvell.com Cc: Nithin Dabilpuram , Kiran Kumar K , Satha Rao , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jan 2, 2023 at 10:14 PM wrote: > > From: Sunil Kumar Kori > > Validation is added to check minimum and maximum RED > threshold values, passed by user. > > Fixes: b7d3a0fe71eb ("net/cnxk: support congestion management operations") > > Signed-off-by: Sunil Kumar Kori Updated the git commit as follows and applied to dpdk-next-net-mrvl/for-next-net. Thanks net/cnxk: validate RED threshold config Added vaalidation to check minimum and maximum RED threshold values, passed by user. Fixes: b7d3a0fe71eb ("net/cnxk: support congestion management operations") CC: stable@dpdk.org Signed-off-by: Sunil Kumar Kori > --- > drivers/net/cnxk/cnxk_ethdev_cman.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/net/cnxk/cnxk_ethdev_cman.c b/drivers/net/cnxk/cnxk_ethdev_cman.c > index d5e647c64d..a7ccdfb756 100644 > --- a/drivers/net/cnxk/cnxk_ethdev_cman.c > +++ b/drivers/net/cnxk/cnxk_ethdev_cman.c > @@ -68,6 +68,11 @@ nix_cman_config_validate(struct rte_eth_dev *eth_dev, const struct rte_eth_cman_ > return -EINVAL; > } > > + if (config->mode_param.red.min_th > config->mode_param.red.max_th) { > + plt_err("RED minimum threshold must be less or equal to maximum threshold"); > + return -EINVAL; > + } > + > return 0; > } > > -- > 2.25.1 >