From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62F3AA0C4A; Thu, 8 Jul 2021 08:32:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E05904069C; Thu, 8 Jul 2021 08:32:33 +0200 (CEST) Received: from mail-il1-f173.google.com (mail-il1-f173.google.com [209.85.166.173]) by mails.dpdk.org (Postfix) with ESMTP id D201F40687 for ; Thu, 8 Jul 2021 08:32:32 +0200 (CEST) Received: by mail-il1-f173.google.com with SMTP id o8so5563516ilf.12 for ; Wed, 07 Jul 2021 23:32:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=REr1ftXxq4A7ZLsUEeJgSh1ouqwee10D9ZOrFiYOsmw=; b=PHKrkYbfVVVkgxe+/K8/f3aTFXZaBcenDBUv/aPVVRihSf0zGno3HuwPlm8zUEox0x FNTPgS8gPB1PIhERY7shuJxZZ4FIfmhv0XlQMpS/hliWaNiTjTy76Av3hUVpNSHktVxF ioXmAxriMnlYUpe+XTnQ6F3HrW6oeI+VuMLtIBbBKpC4BDsKR16dQejfQKn6YXGnyrZE 8vmVYzf/f1ju4BZm2btHR7TkN6Ou0rbp3aSteFhJQklxL+np2ZGm6T/4xUKQLAyKu/VR i3zQ9rL0wDloz9iRQ88KfX+jRZdc++FOzMETurelaMIzhnBbzWTAiTktqZJbdVqxXE7j EYwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=REr1ftXxq4A7ZLsUEeJgSh1ouqwee10D9ZOrFiYOsmw=; b=DN1yQUdicw58Kqi5YWBHZbTMkbfDmV1nlPlYBTpP+gg/Mz4c+N3ldqSCvTQ9nSsFfB jeafpQKq/5ThyJGwW98DXEAmLNW9uTXVNADXKhL07CIM2zjR2LvFDzQQImUzFSlrK1b3 EEm/sMg1CUifxl1UWM254ouUF1f2PhdxYTC10q1/632QGJlee2NWjZptVgn3aEQ3kyp9 M3mKSlIrJeTiXEXU2BzC916KXXTmNNKlBsgcjYWx1EMaRpP448h9PmtOk68Cct5smsAD AWpcrhGVWF4nt7o5nVmyli8Nc6gwDNgOtaXo5FCZuA5tcphPiybc0rVhVjj4843qnKbD nryg== X-Gm-Message-State: AOAM533LCJxuMa4he2DIYmKx70NKNAIerv4IUcT/UofYXgu5lzPds8LU nTQ1otL2MwWT0ZgvSzkNGO1c7a2i1wIP3LgLWVE= X-Google-Smtp-Source: ABdhPJzChrKFEHYZdncxPnCmRmmgcHhx+j/zh2ELU1G7GFu1eVJS4zkZPfMw/dck+EIwR2ThPBl91xj/eJwGE97Kh2w= X-Received: by 2002:a92:b00b:: with SMTP id x11mr21414784ilh.130.1625725952083; Wed, 07 Jul 2021 23:32:32 -0700 (PDT) MIME-Version: 1.0 References: <20200424070741.16619-1-gavin.hu@arm.com> <20210707054840.1608425-1-ruifeng.wang@arm.com> <20210707054840.1608425-4-ruifeng.wang@arm.com> <2428322.vDqkmRtzSv@thomas> In-Reply-To: From: Jerin Jacob Date: Thu, 8 Jul 2021 12:02:06 +0530 Message-ID: To: Ruifeng Wang Cc: Bruce Richardson , "thomas@monjalon.net" , Jan Viktorin , "jerinj@marvell.com" , "dev@dpdk.org" , "david.marchand@redhat.com" , nd , Honnappa Nagarahalli Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 3/3] build: add option to enable wait until equal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 8, 2021 at 11:55 AM Ruifeng Wang wrote: > > > -----Original Message----- > > From: Jerin Jacob > > Sent: Wednesday, July 7, 2021 8:37 PM > > To: Bruce Richardson > > Cc: Ruifeng Wang ; thomas@monjalon.net; Jan > > Viktorin ; jerinj@marvell.com; dev@dpdk.org; > > david.marchand@redhat.com; nd ; Honnappa Nagarahalli > > > > Subject: Re: [dpdk-dev] [PATCH v4 3/3] build: add option to enable wait until > > equal > > > > On Wed, Jul 7, 2021 at 5:57 PM Bruce Richardson > > wrote: > > > > > > On Wed, Jul 07, 2021 at 06:46:33AM +0000, Ruifeng Wang wrote: > > > > > -----Original Message----- > > > > > From: Thomas Monjalon > > > > > Sent: Wednesday, July 7, 2021 2:32 PM > > > > > To: Ruifeng Wang > > > > > Cc: Jan Viktorin ; jerinj@marvell.com; > > > > > Bruce Richardson ; dev@dpdk.org; > > > > > david.marchand@redhat.com; nd ; Honnappa > > Nagarahalli > > > > > > > > > > Subject: Re: [PATCH v4 3/3] build: add option to enable wait until > > > > > equal > > > > > > > > > > 07/07/2021 07:48, Ruifeng Wang: > > > > > > Introduce a meson option 'use_wfe' to select wait until equal method. > > > > > > The default is disable. Traditional polling loop is used. > > > > > > When enabled, architecture specific mechanism is relied on to do > > > > > > the wait. > > > > > > > > > > Why do we need an option? > > > > > Can it be automatic to enable it when supported? > > > > > > > > > The problem is inconsistency in performance on different Arm platforms. > > We had decided that each platform needs to enable it after some testing. > > > > > > > Can that not be done via variables in the cross-file for the builds, > > > or via automatic detection if it's a native build? Is it likely that > > > individual users of DPDK will be knowledgable enough to use this option > > correctly? > > > > +1 to add this in cross-file instead of the top of config option as > > scope if is only for arm64 builds. > > Currently this option is in config/arm/meson.build (flags_common). SoCs can build > with this option enabled/disabled. And the ability is available for both native build > and cross build as cross build also goes through meson.build. > If a SoC needs to enable the option by default, an entry and be added to the SoC flags. > > The key difference here is whether this option need to be exposed to the top level config. In the view of limiting top-level config options and it is specific to Arm, I think, it better to be a cross file only option.