From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8E47A0554; Tue, 18 Feb 2020 06:07:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 53FF81D8FF; Tue, 18 Feb 2020 06:07:42 +0100 (CET) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id EE07A1D552 for ; Tue, 18 Feb 2020 06:07:40 +0100 (CET) Received: by mail-io1-f67.google.com with SMTP id z193so20913077iof.1 for ; Mon, 17 Feb 2020 21:07:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=347OsUupfYYOdEuZguWY1YeiKGqqvX2stuf5VcMSAvg=; b=VHo7ExFdSh0GDyMB4IP2X9d9VV7Ai8to7Gm+0chLb26ERMLe2JtoDT6c5XVgE5pySy oxM/QvHW8cO7Zz4dTmlPvxxi0FYi/odCxJ8YEgqq1LXSejcEdHHRSBE/HrcmhNXkzPT3 ebGdmag7hDlEoCNJcDIf7yI7Ae3Z1STYCMMov01y9wgWiKQyazT294leHtgESDtWcii/ ZhsT9Nv8oCVcgvHdUO1q/vD0oE28nwoBtVDLayoX9KuPH53iPRVn3uV4LThJNcUYFVhQ eCcCmv8YwnqjVM5dgKZZQXHnLDIDThLRwSvyGRYsuRHOhcbB66CSwJdi7LaOb++SQRx6 //dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=347OsUupfYYOdEuZguWY1YeiKGqqvX2stuf5VcMSAvg=; b=jw5uZRhCg/XhNB2WkcNyY4kZ4ZYzDzMS/muKPDOVmtAozhJy4y3a5tnO4QY/qXfC1Y P4b9wCbKC1K64qohU7Ro7OjkIYK3i4EDkD8izH36jDwOOyu+6PekBny7w48BNmmdQ3Mh ta2NdHuSnzP0asaxO48sFuwf25G26KMVaUoefnMnuk2AF8bYFZCWFFIV3lOfvGCKUV9R mJ2a0Lhrbc7WcOPTn1jysq+HG4r0Waarv8uGYjitItVLd+fBdAWuIqt2Vdcb5SHV4rhz nFUGj4yVEdBMe783OcxF6cKZCcRodGuyKcFSto1Sc0/0X6HnwDDxq2QyPS98U/zPvReM spCA== X-Gm-Message-State: APjAAAVtuI5TYUCbcLhkjDi/xuz519kNLWG0Ch7C98zZkoy+50z0XEQC AgfHWo7clR4YoxMAPysspAgbIPzk15Vl9hP30vw= X-Google-Smtp-Source: APXvYqzjiO6uPqWGvut4WJ/ILQS/MOPgsttENW2xIi8szIeiEatE2cv4mPhStgAPvC7tpaDweWhy/ABwj2Z3jYetfnw= X-Received: by 2002:a5d:8cce:: with SMTP id k14mr15200253iot.294.1582002460154; Mon, 17 Feb 2020 21:07:40 -0800 (PST) MIME-Version: 1.0 References: <20200217153805.888130-1-ferruh.yigit@intel.com> In-Reply-To: <20200217153805.888130-1-ferruh.yigit@intel.com> From: Jerin Jacob Date: Tue, 18 Feb 2020 10:37:23 +0530 Message-ID: To: Ferruh Yigit Cc: Neil Horman , John McNamara , Marko Kovacevic , dpdk-dev , David Marchand , Thomas Monjalon , Andrew Rybchenko Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] doc: plan splitting the ethdev ops struct X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Feb 17, 2020 at 9:08 PM Ferruh Yigit wrote: > > For the ABI compatibility it is better to hide internal data structures > from the application as much as possible. But because of some inline > functions 'struct eth_dev_ops' can't be hidden completely. > > Plan is to split the 'struct eth_dev_ops' into two as ones used by > inline functions and ones not used, and hide the second part that not > used by inline functions completely to the application. It is a good improvement. IMO, If anything used in fast-path it should be in ``struct rte_eth_dev`` and rest can completely be moved to internal. In this case, if `rte_eth_tx_descriptor_status` not used on fastpath, Maybe we don't need to maintain the inline status and move completely to .c file. Those may be specifics of the work. In general, this change looks good to me. Acked-by: Jerin Jacob > > Signed-off-by: Ferruh Yigit > --- > Cc: David Marchand > Cc: Thomas Monjalon > Cc: Andrew Rybchenko > --- > doc/guides/rel_notes/deprecation.rst | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index dfcca87ab..2aa431028 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -72,6 +72,12 @@ Deprecation Notices > In 19.11 PMDs will still update the field even when the offload is not > enabled. > > +* ethdev: Split the ``struct eth_dev_ops`` struct to hide it as much as possible. > + Currently the ``struct eth_dev_ops`` struct is accessible by the application > + because some inline functions, like ``rte_eth_tx_descriptor_status()``, > + access the struct directly. The struct will be separate in two, the ops used > + by inline functions still will be accessible to user but rest will be hidden. > + > * cryptodev: support for using IV with all sizes is added, J0 still can > be used but only when IV length in following structs ``rte_crypto_auth_xform``, > ``rte_crypto_aead_xform`` is set to zero. When IV length is greater or equal > -- > 2.24.1 >