From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5817942A4D; Wed, 3 May 2023 11:53:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 29C164114B; Wed, 3 May 2023 11:53:54 +0200 (CEST) Received: from mail-vs1-f43.google.com (mail-vs1-f43.google.com [209.85.217.43]) by mails.dpdk.org (Postfix) with ESMTP id 68B1F41144 for ; Wed, 3 May 2023 11:53:53 +0200 (CEST) Received: by mail-vs1-f43.google.com with SMTP id ada2fe7eead31-43278f6d551so1555670137.1 for ; Wed, 03 May 2023 02:53:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683107633; x=1685699633; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ey/sQUmwgl8fZ5XHEZ+NwDhqWzdksXT++J1f/ScASH8=; b=MG5/cjYKmrhNuvIZS248Y5qcB7O5yts4aMonRxX0Cm9646msljvi82aj5IY4ahK9RG Yh5e/XyyxJePk3FN44RioZVhXwZtRB98yNY+qpey2CVIT967plpJFdqX3r7MH1MLdrvd wykYTZhMY5Rqs07CSIZXnINXsy6xT27BSk2kyJ3NCbwq1YcXjn53vlu80sLOhrDat3J0 UkWo/OaYy/pE35ViV50l3CfTRalwcfF/Gk/FvHim5C5YIj20W5xHAu5TAJ0uW4kjKYhK rAFHxuZk0zFWfXAdpyKb5lRfhP1c7IZYQ5rMidti4O0Ex5YiTG341QdInnawW3W5lxcb unlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683107633; x=1685699633; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ey/sQUmwgl8fZ5XHEZ+NwDhqWzdksXT++J1f/ScASH8=; b=Eh3OpoJmcIeV3nh9sx9aNjek+0QFBcw+daW2JodmJCeqHU/aKTEg3YJ2XABVyKhsb8 Ntm9qLBLGvgSTSo6t9q7CTHUzAh6nJ/GUD9iy6oD+wCYvfp2lBxsgBGNpnaiAvMKpKn2 LzIcw2b/+1wYVYJJ1M6oCLeCKvm+fy04FunkFzaCHXr8fxyMGnwNHoo+wFtL0WRvQDIF yejdbBdnkrB6GOQYgMt0CMxi2VcGhdiX7Yu0jixyOux3IiSJQeunffCZ5C6H3EYE8HvG GY0hxOmUJxKVpy/h6BCeujpCBJRlBhVgmEXBygkgZ23BRjtLRhuJjuFIu0kcJxO6ZGlV 97DQ== X-Gm-Message-State: AC+VfDyUPbv/ligfEwDwnfM2ap0y//JySDsZgNho3ADG3pBPZ8da8jQa cXSbefJ1npRCWVtwxZSnrTNkTgLjm8+lKT4S+JM= X-Google-Smtp-Source: ACHHUZ5Z/6eF9bn1Nxbe/3ga1D+IrqHNM1qVb+7bubG19RSB+0FInUdZqJbVmN7kXZLMqaWa7TQPkLjhtNdWnN12RlI= X-Received: by 2002:a05:6102:3662:b0:430:4b20:17c0 with SMTP id bg2-20020a056102366200b004304b2017c0mr976313vsb.20.1683107632639; Wed, 03 May 2023 02:53:52 -0700 (PDT) MIME-Version: 1.0 References: <20230411070129.870-1-pbhagavatula@marvell.com> In-Reply-To: <20230411070129.870-1-pbhagavatula@marvell.com> From: Jerin Jacob Date: Wed, 3 May 2023 15:23:26 +0530 Message-ID: Subject: Re: [PATCH 1/2] net/cnxk: optimize flow control hysteresis To: pbhagavatula@marvell.com Cc: jerinj@marvell.com, Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Apr 11, 2023 at 12:31=E2=80=AFPM wrote: > > From: Pavan Nikhilesh > > Set flow control hysteresis to ignore immediate sequence of > decrement-increment to avoid unnecessary LLC traffic. > Enable hysteresis when SQ length is more than 512 as it lower > queue lengths will require faster updates. > > Signed-off-by: Pavan Nikhilesh Series applied to dpdk-next-net-mrvl/for-next-net. Thanks > Signed-off-by: Satha Rao > --- > drivers/net/cnxk/cnxk_ethdev.c | 2 ++ > drivers/net/cnxk/cnxk_ethdev.h | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethde= v.c > index 1cae3084e1..42a52ed0ca 100644 > --- a/drivers/net/cnxk/cnxk_ethdev.c > +++ b/drivers/net/cnxk/cnxk_ethdev.c > @@ -487,6 +487,8 @@ cnxk_nix_tx_queue_setup(struct rte_eth_dev *eth_dev, = uint16_t qid, > sq->qid =3D qid; > sq->nb_desc =3D nb_desc; > sq->max_sqe_sz =3D nix_sq_max_sqe_sz(dev); > + if (sq->nb_desc >=3D CNXK_NIX_DEF_SQ_COUNT) > + sq->fc_hyst_bits =3D 0x1; > > if (nix->tx_compl_ena) { > sq->cqid =3D sq->qid + dev->nb_rxq; > diff --git a/drivers/net/cnxk/cnxk_ethdev.h b/drivers/net/cnxk/cnxk_ethde= v.h > index 62a06e5d03..97537de17a 100644 > --- a/drivers/net/cnxk/cnxk_ethdev.h > +++ b/drivers/net/cnxk/cnxk_ethdev.h > @@ -49,6 +49,8 @@ > /* LPB & SPB */ > #define CNXK_NIX_NUM_POOLS_MAX 2 > > +#define CNXK_NIX_DEF_SQ_COUNT 512 > + > #define CNXK_NIX_RSS_L3_L4_SRC_DST = \ > (RTE_ETH_RSS_L3_SRC_ONLY | RTE_ETH_RSS_L3_DST_ONLY | = \ > RTE_ETH_RSS_L4_SRC_ONLY | RTE_ETH_RSS_L4_DST_ONLY) > -- > 2.25.1 >