From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A9B8B42C4C; Wed, 7 Jun 2023 10:27:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 85E2740A84; Wed, 7 Jun 2023 10:27:45 +0200 (CEST) Received: from mail-ua1-f48.google.com (mail-ua1-f48.google.com [209.85.222.48]) by mails.dpdk.org (Postfix) with ESMTP id 4245A40698 for ; Wed, 7 Jun 2023 10:27:44 +0200 (CEST) Received: by mail-ua1-f48.google.com with SMTP id a1e0cc1a2514c-787465b8738so1688665241.1 for ; Wed, 07 Jun 2023 01:27:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686126463; x=1688718463; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8oqrHxjZM8Oyesv8J70yK1aqsbO+zgRiI03MYXBkJ68=; b=YSJQ36S1RGzV3/wPX57vMtQjZs53u0ua6rzRQujKJY7IIInSdCw8WdKzcaPKkUjFa2 4CCfCG2dQ2WElYWLVHzlLOc2xD3IpacDiEVPdzvmukMru85zLUZUXxa7iyYGbfOKyPZ8 aLIZjI44IjfFxfy6JrjDF9ti0aFnMHNnjCU/TpDQs4j/0UKUBOOrrcc1LbvJB+O1qzHY 2nEKHZHGQMjbQuq3AvnHQ9+6LqsrE1gE6fxp8pp6gW8Ih1SOq4Qog1UDprC4qrD/LRMy SKXCOItxWIMcdara0mKOMCksi360GrGFdi43DEzLly3Y2gG6a+eZXdWwwsSVe8f/pwoE aZpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686126463; x=1688718463; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8oqrHxjZM8Oyesv8J70yK1aqsbO+zgRiI03MYXBkJ68=; b=k5PHp7qofqLTwu+DGyKmv8GCpB1P+MxOXjAj12ckk+IsMHmpUZXbpKf+hl00gojr/Z PhfHcP3rlueeZ6MYjIl2ihXhFuI4g47v28KSrTSx+XfI5GDYH1nLTk1RAUwpojvyrGyT M3fbibxpDT8LHnU/7ecCN8ALw+cBQgrRqLqOpptNy36bCiism6+gt+UXPz1bFmMplfH/ Y7cGEN0/i5ePWUK+H1R9gspNtZuhYHfoJlRUW7Yp1UmDdU6ZMDb6Kmym6moxu5lpzI89 mpbTMg0D4iDi4ajxstRLoon7C9WeWGR99IT0rG4aFYp93+80VD/pJtoR5dNqHZRb1bZs N0Kg== X-Gm-Message-State: AC+VfDyyH9NK8TuQD9RP7bnTMv6SDWtEFnv3P6jqgrUThaHGNnpXwtjQ 6gShNIi2tTNIeJ4YdwnMFPyviGQJUd4Y4czMjDCc08NDrpgjig== X-Google-Smtp-Source: ACHHUZ6PAYu1/WNxAlhWI27nyvBHu9uZdZStC2RflTNP2TnIPNcgohPoodq+cCbXERcNtCC+1q07WgqDGzDeWfRsI6U= X-Received: by 2002:a67:db88:0:b0:43c:89d6:ef6 with SMTP id f8-20020a67db88000000b0043c89d60ef6mr748405vsk.8.1686126463432; Wed, 07 Jun 2023 01:27:43 -0700 (PDT) MIME-Version: 1.0 References: <20230606144746.708388-1-zhirun.yan@intel.com> <20230607035144.1214492-1-zhirun.yan@intel.com> <20230607035144.1214492-16-zhirun.yan@intel.com> In-Reply-To: <20230607035144.1214492-16-zhirun.yan@intel.com> From: Jerin Jacob Date: Wed, 7 Jun 2023 13:57:17 +0530 Message-ID: Subject: Re: [PATCH v9 15/17] examples/l3fwd-graph: introduce multicore dispatch worker model To: Zhirun Yan Cc: dev@dpdk.org, jerinj@marvell.com, kirankumark@marvell.com, ndabilpuram@marvell.com, stephen@networkplumber.org, pbhagavatula@marvell.com, cunming.liang@intel.com, haiyue.wang@intel.com, mattias.ronnblom@ericsson.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jun 7, 2023 at 9:30=E2=80=AFAM Zhirun Yan wr= ote: > > Add new parameter "model" to choose mcore dispatch or rtc model. > And in dispatch model, the node will affinity to worker core successively= . > > Note: > RTE_GRAPH_MODEL_SELECT is set to GRAPH_MODEL_RTC by default. Must set > model the same as RTE_GRAPH_MODEL_SELECT If set it as rtc or mcore > dispatch explicitly. GRAPH_MODEL_MCORE_RUNTIME_SELECT means it could > choose by model in runtime. Now no GRAPH_MODEL_MCORE_RUNTIME_SELECT. Right? it same as !RTE_GRAPH_MODEL_SELECT > Only support one RX node for mcore dispatch model in current > implementation. > > ./dpdk-l3fwd-graph -l 8,9,10,11 -n 4 -- -p 0x1 --config=3D"(0,0,9)" -P > --model=3D"dispatch" Please update doc/guides/sample_app_ug/l3_forward_graph.rst for new model option and example command line and relevant detail on RTE_GRAPH_MODEL_SELECT scheme. > Signed-off-by: Haiyue Wang > Signed-off-by: Cunming Liang > Signed-off-by: Zhirun Yan > --- > examples/l3fwd-graph/main.c | 231 ++++++++++++++++++++++++++++++------ > 1 file changed, 193 insertions(+), 38 deletions(-) > > diff --git a/examples/l3fwd-graph/main.c b/examples/l3fwd-graph/main.c > index 5feeab4f0f..77a5a98aec 100644 > --- a/examples/l3fwd-graph/main.c > +++ b/examples/l3fwd-graph/main.c > @@ -23,6 +23,12 @@ > #include > #include > #include > +#define GRAPH_MODEL_RTC 0 /* Run-to-completion model, set by default. */ > +#define GRAPH_MODEL_MCORE_DISPATCH 1 /* Dispatch model. */ > +#define GRAPH_MODEL_MCORE_RUNTIME_SELECT 2 /* Support to select model by= */ Duplication from public header file. Not needed. > + /* parsing model in cmdline. *= / > +#undef RTE_GRAPH_MODEL_SELECT