From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7FD1745813; Mon, 19 Aug 2024 13:37:48 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0FF654028A; Mon, 19 Aug 2024 13:37:48 +0200 (CEST) Received: from mail-oo1-f44.google.com (mail-oo1-f44.google.com [209.85.161.44]) by mails.dpdk.org (Postfix) with ESMTP id BAA9040267 for ; Mon, 19 Aug 2024 13:37:45 +0200 (CEST) Received: by mail-oo1-f44.google.com with SMTP id 006d021491bc7-5d5b22f97b7so3615575eaf.2 for ; Mon, 19 Aug 2024 04:37:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724067465; x=1724672265; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=br/o/pP8t11eznY5qnUUrg3VVasdMBPbDpvF2qzkPRk=; b=XHHAW07Nq4SK+t7xzEjBhbCltbzU37h5/5Jcy52vNi4OmOKo1sx5L4Bck+sbhWPXRt oOkeYl+iIqYdohuhO6pTMIffkx4GTMBOQbh/2s12jDz7E03VuEBoweR3g7efV2UzX8V4 Rk42Lpfivr1dwa6f+2I9d1Mevfe71IfmtzZQDwFyo9NvRcV6kXj25xG/qalC65BIEwW+ sBBM6gCtkDRAsulIF09DXqCVUA3pQ8B7ZBo3JJNM0z31IiHU76SgYf9yZzxRoNd+8IGa odV02Kx/M4K3lgk6WgnXeokl+3pVNswa66YXiQC5rsyLC34rzaL7kh3IpEmUjCnjHwbR gNQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724067465; x=1724672265; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=br/o/pP8t11eznY5qnUUrg3VVasdMBPbDpvF2qzkPRk=; b=X/U/SaVHDQzjayCHZzMOr7+dtOV6ObKl8R0ij1fm7NPdWuGsfYFI8GwqrCFWapois0 6CmG/NmxXWRgCrY4RHTwktSS+v9A4CFxNESS/yf2ubzc5TXzyBMzizkyKaa5afijQxhj trD/IotreDqpF5aQ7veMbD4LcomSAbi8KZKLA/YFJnbC6sBkeJlet8e7Tf0N4RBtIAZ/ JCUkY8ARUpSiHMiCqPdDq/zAPF7nXAQ+X4SE8PhOsfmHkiWUFI/iyvrPMM3KgqhjR7ZU VrbqYFsky0JwTBap5rxhfdOTP0RArss2XIFlAewwCYIdYVmqbkVxCti+vPQRAffVj4Hp 2gjQ== X-Forwarded-Encrypted: i=1; AJvYcCWGlJ4z+nAZVlG2YOBHh3YLw8+jY+4HrXM2dY3k3N4fqS9JzdS7NeEIG+o+fYVy3owK+ccMY4VZgv/YT3I= X-Gm-Message-State: AOJu0YzUo39OsLl8isF8YlC1TbswNu4Vf2fN6bQbYxq+QIez7FM9xrgV wC3kTrq2m50ijjcr770kDpOMvQibQxqZzdMTCxjVXol8sGPwQKCf3+/th41BKXWr+7vJWF4ZN5t onFgIek9rS1DSsGXFobwIxWzb2nU= X-Google-Smtp-Source: AGHT+IH7Y9VEHlsrU10H4VXnhedwpb7idRYu+nIlRlPSlnpCGu/y+nhVrjVkwHZnNkX0d1uWZBYZvlS4uP8ICHMLG0I= X-Received: by 2002:a05:6359:5a8a:b0:1ab:e07d:c945 with SMTP id e5c5f4694b2df-1b39316972amr1431117055d.1.1724067464380; Mon, 19 Aug 2024 04:37:44 -0700 (PDT) MIME-Version: 1.0 References: <0cb77372-83b3-49f0-89bb-5c641e0522a6@amd.com> In-Reply-To: <0cb77372-83b3-49f0-89bb-5c641e0522a6@amd.com> From: Jerin Jacob Date: Mon, 19 Aug 2024 17:07:18 +0530 Message-ID: Subject: Re: Ethdev tracepoints optimization To: Ferruh Yigit Cc: Adel Belkhiri , dev@dpdk.org, Bruce Richardson , Jerin Jacob Kollanukkaran Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Aug 19, 2024 at 4:13=E2=80=AFPM Ferruh Yigit = wrote: > > On 8/15/2024 8:32 PM, Adel Belkhiri wrote: > > Hi DPDK Community, > > > > I am currently working on developing performance analyses for > > applications using the ethdev library. These analyses are being > > implemented in Trace Compass, an open-source performance analyzer. One > > of the views I=E2=80=99ve implemented shows the rate of traffic receive= d or sent > > by an ethernet port, measured in packets per second. However, I've > > encountered an issue with the lib.ethdev.rx.burst event, which triggers > > even when no packets are polled, leading to a significant number of > > irrelevant events in the trace. This becomes problematic as these > > "empty" events can overwhelm the tracer buffer, potentially causing the > > loss of more critical events due to their high frequency. > > > > To address this, I've modified the DPDK code in lib/ethdev/rte_ethdev.h > > to add a conditional statement that only triggers the event when nb_rx = > > > 0. My question to the community is whether there are use cases where an > > "empty" lib.ethdev.rx.burst event could be useful. If not, would there > > be interest in submitting a patch with this modification? > > > > Tracepoint is good way to get frequency of the calls, so I believe there > can be value of getting empty burst calls too. > > But your usecase also a valid one. I wonder if it works to have separate > trace calls, for empty and non-empty ones, and how this additional > branching impacts the performance, at least branch should be wrapped > with 'RTE_ENABLE_TRACE_FP' macro to not impact non-tracing usage. CTF(Common trace format) post processing tools can check the value for each field and timestap. So it will easy to skip the ones with no packet for this case. >