From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6DC47A2EFC for ; Tue, 15 Oct 2019 16:16:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B31DA1EC6A; Tue, 15 Oct 2019 16:16:34 +0200 (CEST) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id E45FF1EC59 for ; Tue, 15 Oct 2019 16:16:33 +0200 (CEST) Received: by mail-io1-f67.google.com with SMTP id n197so46162439iod.9 for ; Tue, 15 Oct 2019 07:16:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EbbvSsdUIbxJoN+oTKxWQ/b4gQmdmFrO4Xf9PgRQgPo=; b=OUa6JAPVD3fDlEpqtQQyA1BvwZW/fL5OxzNnENX6o+rMz5LNmHxWzf107uhOehB/ck kLss0A1mXxSqhjf3Na3MN9XjWlxybg6P6saCux9SrgW7fveeEpZ3Pid7ZTAOh0GJNzMP q0ZdNbdrGFF5VZ2evCh2OMP8oRXhBOKHhCdpJiwS+/qStlDDWflYgcFaRKdfXidu7yX+ MrnVqyzaLHGOMrh6g6hEFv7ChAE4C1eUCBxSlirrGtstVES5/G+aC5JXDgHOZ9VLG3M6 j9Qq7QZxjnFrHv73/XkyUFVAFUrQVG3IAX8q4PI49G/G+D/jlsKYUDC62GcjVQqUsLd0 BQcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EbbvSsdUIbxJoN+oTKxWQ/b4gQmdmFrO4Xf9PgRQgPo=; b=sKUJVMESOup/ogE22U1o1QlDV7wrnsHAkQIUWT1J3rwb5NRCDOQbwnhBZkNXoYi0CC L2522SkTl1os7vAlWxsZynSwkEvNgRyfdnzR6uF9TyPs7EFijc13oVW9droeA3yysf8R lV26Z4RgDQCaoIHuUdOfTxXNiamw7xgEllNaDKnVva1qGtiqiqP+yY11r7MQueMbQMSY bNE/KaRWkIbbZm3jkRG8CkzATFWfapOWiB8Ss2U2kbNkJDmBuJz65mmdvkmsQ/Bn0LJF X0+UFiB/5EcvNIjv7ZckxxQrVD4QV1HYVde1ptl1iuv3a8ESF2uXegFLP+eLCZimkYhT HCxA== X-Gm-Message-State: APjAAAUV5kSNoeDG2mB2zEXsXYt+nVijX4Q2CfITDWuav7UwZYbR3CBS 35v5EWQlrjFR9l0zBUM755eWTtT612+Jsk7lotA= X-Google-Smtp-Source: APXvYqypnEjVtXFgH+5/VIb2QDmi0DxptwjX6MH1j8qq2tQdKlxAenT4A1/8tKc6w85idJMTjWtwu+ml2POkB6wAPU0= X-Received: by 2002:a6b:740b:: with SMTP id s11mr43010205iog.294.1571148992945; Tue, 15 Oct 2019 07:16:32 -0700 (PDT) MIME-Version: 1.0 References: <20190730155726.26450-1-thomas@monjalon.net> <8145f03d-0911-91a8-73ee-9febe0c1dbec@linux.intel.com> In-Reply-To: From: Jerin Jacob Date: Tue, 15 Oct 2019 19:46:21 +0530 Message-ID: To: Ferruh Yigit Cc: Andrew Rybchenko , "Yigit, Ferruh" , Thomas Monjalon , John McNamara , Marko Kovacevic , Ajit Khaparde , Somnath Kotur , John Daley , Hyong Youb Kim , Beilei Xing , Qi Zhang , Wenzhuo Lu , Rosen Xu , Konstantin Ananyev , Shahaf Shuler , Yongseok Koh , Viacheslav Ovsiienko , Rasesh Mody , Shahed Shaikh , dpdk-dev , David Marchand , Adrien Mazarguil Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] doc: remove deprecated ethdev features X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > >>> @@ -36,13 +36,6 @@ VMDq = > >>> SR-IOV = > >>> DCB = > >>> VLAN filter = > >>> -Ethertype filter = > >>> -N-tuple filter = > >>> -SYN filter = > >>> -Tunnel filter = > >>> -Flexible filter = > >>> -Hash filter = > >>> -Flow director = > >>> Flow control = > >>> Flow API = > >>> Rate limitation = > >> I suggest adding these features back! > >> > >> "Flow director" and other filters are features that device/driver supports. > >> > >> And "Flow API" and "filter_ctrl" are methods used to implement these features. > >> Indeed they are only different APIs to get input from application/user. > >> > >> It doesn't really mean much to say "Flow API" is supported? So what is really > >> supported? It matters more what feature is supported. > >> > >> Since we are saying old method is deprecated, we can update the feature list of > >> drivers which implements filtering features using old method as not supported. > >> And that is the case with this patch since old APIs are marked as deprecated, > >> users can't use them to enable a filtering feature. > >> > >> Indeed I am for removing the "Flow API" from feature list, first it is not a > >> feature, second if it is only method to enable a filtering, and if filtering is > >> enabled in a driver, what is the point of redundant "Flow API" listing? > >> > >> I can make a quick patch if there is no objection, thanks. > > > > As I understand it was a decision to avoid details about flow API support > > in features matrix. Mainly because matrix would be really huge in > > attempt to represent it. The question is why filters/patterns mentioned > > above are better than others and should be mentioned. > > I'm not against adding some details, just want to understand criteria. > > Flexible and hash are definitely not well defined. > > What is flow director and which features should be supported to say yes? > > > > The criteria I have is what users will be interested about a device/driver. > > Will it be really huge to list filtering capabilities of the devices? I believe > we can group them into a few groups like above. > Or at least keep existing one and improve it by time and +1 to clarify them more > but that is something else. > > A device can have capabilities but it is not easy to find if that capability has > been enabled via DPDK, this kind of feature matrix works for it, and all > features together makes it much easier than digging datasheets and code. > > Saying that "Flow API" is enabled for a driver doesn't really gives any > information to the user if they are interested what kind of filtering features > are supported by that device/driver. I agree. I think, we need to enumerate rte flow patterns and actions supported by the PMD. Since there was no single place such documentation, we added the same in PMD documentation See 39.8. RTE Flow Support at https://doc.dpdk.org/guides/nics/octeontx2.html And IMO, We should not add deprecated features in the features matrix as new PMDs are not planning to implement the deprecated APIs. That makes, matrix looks new PMDs do not implement a lot of features, but in reality, those are deprecated and never planning to implement if even though HW supports it.