From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94578A0C4C; Thu, 14 Oct 2021 11:28:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 18AE740E50; Thu, 14 Oct 2021 11:28:52 +0200 (CEST) Received: from mail-il1-f181.google.com (mail-il1-f181.google.com [209.85.166.181]) by mails.dpdk.org (Postfix) with ESMTP id 7D7EC40041 for ; Thu, 14 Oct 2021 11:28:50 +0200 (CEST) Received: by mail-il1-f181.google.com with SMTP id f15so2729271ilu.7 for ; Thu, 14 Oct 2021 02:28:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5dVPNzCOF2FzJOQCsBjLgC2YBPkhT2VUxjl/vCcy/1M=; b=RHkV3TRPcuOKot9VVVqSMO35UbsSic4L7zOQhk8WnwuYmoxo5OuYblLci8osiHl5xb FpQQyic16c0ArUGmgROARdkHpm0nuw9i2WUaAFJNarzHbrHm7xn+ZsvwdA9d2iaySX17 ZYqrKxyZfDCpU5SXh3paEyVmk27pVrnm14avY3/nHvQLSfI2P6phrYxr0Etb9b3WbK0M AHMDWJtnyM2ghB82Tue5oaIYp+/hFQgGFoIPkM9oYWLm3o7zy0aYZh9z/7WaDvBu4228 hQOLdQGlW3P5p+xkKx1O50e8ubD+/OjF5z9xwHyYt4uR1lpz0pZkIh3b9rEb9dCvX2n0 1DyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5dVPNzCOF2FzJOQCsBjLgC2YBPkhT2VUxjl/vCcy/1M=; b=Km9ZStIGZU3L71cf9ehVYBVHi3CvvARVAokyQ0Pn5fIIweyGC4PacGF3f28kImsxWq 4NXyLRVVNxi8NBuXlqYizuB5YkEfGXDkAxFiDNTz9PrKyzdRSCNA6xRT2A3LW+NdhUPY Bn66moWyx1zzryaEx9871FnmJYf2xLwbyyLERp2z762PPN32n2rEu9tyQMj+X7z4fvp0 dbjcYvyy+5J8CfCZLHgiKtdSAbvuZ73PxQmnJkUzYuF/gIncHnRxSPCk0aghmXzx56xe 0WZaoo6Az0vO2yU0WcIS+O/AmnStB7s2NuypfeWiZiApOM3b5Lo3otXjNTN1vdxzKlk9 VsCw== X-Gm-Message-State: AOAM5312CpyAR4Rv/VasCNG/PzFM6GyNhEPeh7tIlO1/uA5UGj5RlKUY dc0izy6LYp/qf5ptVOsfvRwOItE6xJ6ZiY8hUv4= X-Google-Smtp-Source: ABdhPJxAQWeqFMGQjN9U6qPADi/6iekPGRCgW0QBSF/llgryBNzNbfoPD7X5WEJUuS+w8E5ufpYVDOsidCtaOfVEcU4= X-Received: by 2002:a05:6e02:190a:: with SMTP id w10mr1596624ilu.243.1634203729805; Thu, 14 Oct 2021 02:28:49 -0700 (PDT) MIME-Version: 1.0 References: <20211003082710.8398-1-pbhagavatula@marvell.com> <20211006065012.16508-1-pbhagavatula@marvell.com> <20211006065012.16508-14-pbhagavatula@marvell.com> In-Reply-To: From: Jerin Jacob Date: Thu, 14 Oct 2021 14:58:23 +0530 Message-ID: To: David Marchand Cc: Pavan Nikhilesh , Ray Kinsella , Jerin Jacob Kollanukkaran , dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 14/14] eventdev: mark trace variables as internal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 6, 2021 at 12:41 PM David Marchand wrote: > > Hello Pavan, Ray, > > On Wed, Oct 6, 2021 at 8:52 AM wrote: > > > > From: Pavan Nikhilesh > > > > Mark rte_trace global variables as internal i.e. remove them > > from experimental section of version map. > > Some of them are used in inline APIs, mark those as global. > > > > Signed-off-by: Pavan Nikhilesh > > Acked-by: Ray Kinsella > > Please, sort those symbols. > I check with ./devtools/update-abi.sh $(cat ABI_VERSION) > > > > --- > > lib/eventdev/version.map | 77 ++++++++++++++++++---------------------- > > 1 file changed, 35 insertions(+), 42 deletions(-) > > > > diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map > > index 068d186c66..617fff0ae6 100644 > > --- a/lib/eventdev/version.map > > +++ b/lib/eventdev/version.map > > @@ -88,57 +88,19 @@ DPDK_22 { > > rte_event_vector_pool_create; > > rte_eventdevs; > > > > - #added in 21.11 > > - rte_event_fp_ops; > > - > > - local: *; > > -}; > > - > > -EXPERIMENTAL { > > - global: > > - > > # added in 20.05 > > At the next ABI bump, ./devtools/update-abi.sh will strip those > comments from the stable section. > You can notice this when you run ./devtools/update-abi.sh $CURRENT_ABI > as suggested above. Please do the David suggestion on sorting the map file. > I would strip the comments now that the symbols are going to stable. > Ray, do you have an opinion? > > > -- > David Marchand >