From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2F794308C; Thu, 17 Aug 2023 11:48:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E38CC410F9; Thu, 17 Aug 2023 11:48:45 +0200 (CEST) Received: from mail-vk1-f180.google.com (mail-vk1-f180.google.com [209.85.221.180]) by mails.dpdk.org (Postfix) with ESMTP id 0B4F340685 for ; Thu, 17 Aug 2023 11:48:45 +0200 (CEST) Received: by mail-vk1-f180.google.com with SMTP id 71dfb90a1353d-4882197e0ebso953314e0c.2 for ; Thu, 17 Aug 2023 02:48:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692265724; x=1692870524; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=p03opLoqcss+sQuQ2X7/zWY4HzCi9P/OAeyYVqcO9lE=; b=HTuqebE27p5QGtXjByoC7e0m+AF4dJQtN1Pbqm7DNqrT5PvahaqWL9OEN/4xCswy1s 0uUNHBDeFKWUdzwyEMZaNpMRT5NTakeNtSsJvcdYVwsvBpVIkreBmUGQagkKf45pJR+D ihaVByxU0NUAcfzIrgAyOEXCnTt3r8nFGRCvt3uuH+q4yDBmQTi0hZ04dVgcAnlgjPOq N2aT5oOKcef/RFJNMGJgsYKCbB6UH4yGHQUOYizf7V2aB3CQiJr3x7B82iF2VQLH0mkV +E7k4z0fy3FVuDAoaiJHBkIyerGxAU8loP5I4vq55Bo8dn8KPoxecVUMMyZhtRUkDLam Wp3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692265724; x=1692870524; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p03opLoqcss+sQuQ2X7/zWY4HzCi9P/OAeyYVqcO9lE=; b=MbfVsBvC/55k440Fl4RcjvP223Ua9Lfzww+WGIgploLPMhh4kR/gINvAt/tksUwBBE TWvwylF0X6e1xL13LEvAjVAoy52D+/+W1QsB7KhFh7hpCx5gMeLkiS1l3d1HiUdJtGIM 9cHRCPZDL7kJYr6CXbKbnMTAekcuWXS715Lf7Ute1YV5WWtqLj0igtPjrulnFpirQzJj c+5OPD7tAHN5VEMb8FBB+xESm+9iCtSYJ7CzNoSXhSctq7E4gR+oV9D/nbKAGxOIBmf1 qxHqdh0g5B2nLJ0/E/A5fWO89+1CwawC4ubsagWYpfW4gal3L+eFiBbj2LogOQbKt2Ez PKFQ== X-Gm-Message-State: AOJu0Yx13DjLrIFTeFbXHkXn5lNpGhGP/k0mD4ebPDbL/9AFw4ECMxwx tw0xESYPRSxhreS0VwOF1gUUYRMx0qVGsX6x+G0= X-Google-Smtp-Source: AGHT+IFc8W1PKmSMlK9FvrqsP3T9tiBb08hy6KibvtgAlMpTyqi2xbbqmm3kKqpTxaoYy0hCnHQm/4WPCdMBfMdsczQ= X-Received: by 2002:a67:e3aa:0:b0:446:bf73:771a with SMTP id j10-20020a67e3aa000000b00446bf73771amr5163965vsm.20.1692265724289; Thu, 17 Aug 2023 02:48:44 -0700 (PDT) MIME-Version: 1.0 References: <20230817053710.3985750-1-s.v.naga.harish.k@intel.com> <20230817060318.4101024-1-s.v.naga.harish.k@intel.com> In-Reply-To: From: Jerin Jacob Date: Thu, 17 Aug 2023 15:18:17 +0530 Message-ID: Subject: Re: [PATCH v2] eventdev/eth_rx: add new adapter create API To: "Naga Harish K, S V" Cc: "dev@dpdk.org" , "Jayatheerthan, Jay" , "Carrillo, Erik G" , "Gujjar, Abhinandan S" , "McDaniel, Timothy" , Pavan Nikhilesh , Shijith Thotton , Hemant Agrawal , Sachin Saxena , "Van Haaren, Harry" , "mattias.ronnblom" , Liang Ma , "Mccarthy, Peter" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Aug 17, 2023 at 3:06=E2=80=AFPM Naga Harish K, S V wrote: > > > > > -----Original Message----- > > From: Jerin Jacob > > Sent: Thursday, August 17, 2023 2:27 PM > > To: Naga Harish K, S V > > Cc: dev@dpdk.org; Jayatheerthan, Jay ; > > Carrillo, Erik G ; Gujjar, Abhinandan S > > ; McDaniel, Timothy > > ; Pavan Nikhilesh > > ; Shijith Thotton ; > > Hemant Agrawal ; Sachin Saxena > > ; Van Haaren, Harry > > ; mattias.ronnblom > > ; Liang Ma ; > > Mccarthy, Peter > > Subject: Re: [PATCH v2] eventdev/eth_rx: add new adapter create API > > > > On Thu, Aug 17, 2023 at 11:33=E2=80=AFAM Naga Harish K S V > > wrote: > > > > > > Add new API "rte_event_eth_rx_adapter_create_ext_with_params()" for > > > creating Rx adapter instance. This API is similar to > > > rte_event_eth_rx_adapter_create_ext() with an additional input > > > argument for adapter configuration parameters of type "struct > > > rte_event_eth_rx_adapter_params". > > > > > > Signed-off-by: Naga Harish K S V > > > > > + */ > > > +__rte_experimental > > > +int __rte_cold > > > > Is there any specific reason to keep __rte_cold here? None of the other > > libraries has this. > > __rte_cold is a hint function in the cold path. It is used for code optim= ization purposes > and many net PMDs are using this. I understand that, the question was more on what is the significance of that for this specific API ? There are a lot of slow path APIs in evendev and all other library none of them use it. It just put into different section of binary and optimize more for size. I think, there is no specific reason to add this ONLY for this API to make it standout. Also, The cold attribute is not implemented in GCC versions earlier than 4.= 3. > > > Rest looks good to me. > > > > For library changes, please keep all evendev maintainers in Cc. I have = added > > those now for this email. > > > > > > > +rte_event_eth_rx_adapter_create_ext_with_params(uint8_t id, uint8_t > > dev_id, > > > + rte_event_eth_rx_adapter_conf_cb conf_cb, > > > + void *conf_arg, > > > + struct rte_event_eth_rx_adapter_params > > > +*rxa_params);