From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35440A0C45; Sun, 11 Jul 2021 15:35:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E175B4067E; Sun, 11 Jul 2021 15:35:07 +0200 (CEST) Received: from mail-il1-f174.google.com (mail-il1-f174.google.com [209.85.166.174]) by mails.dpdk.org (Postfix) with ESMTP id A5BAA40040 for ; Sun, 11 Jul 2021 15:35:06 +0200 (CEST) Received: by mail-il1-f174.google.com with SMTP id e13so16341149ilc.1 for ; Sun, 11 Jul 2021 06:35:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=wPUDhHfUNuuKHTvjukOnYYiaArPqLqW1/K7wM5BYPuQ=; b=NY1IkI6Nkd1/mlux8Gxi5oyF1/7sUQQPXmHPxtKjutZMDXBtJaHxV5uCSMBpkAPDPf CAKF5hj4KIgItmB0a/jReeFTgW2XJ4AEmWRMCdnG2RWYtYUBCjmjoX8I7dhU+e9GrUA0 P772csLAAqIj0mRsbsh34cx9nGGeKl5HOV+BabweAYJs6a8X7WpQatWePpk9fMiJ5E57 WQO31f3sc4WQpuzA0LxpXKrFkXLoCgPGX9c7nEri+TZHYafhIrtA3juW0cYqdcjg3hZ7 0T/+JlaaWhsoP9JdLsRmpFCREb2HggP5246PyvrEtp1qjMkyrJGmiwmy1qoFznd+UaxB XlPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=wPUDhHfUNuuKHTvjukOnYYiaArPqLqW1/K7wM5BYPuQ=; b=cokwtBqcK1Ii4djNK+Uk+c6lcCxL46sO6Q0OSLfFHHaC/H+tAz5zdJVThSA45YMfHf ua0tzYdaI3+LtF1PdzQlKbjenBBTsZovyskzVSlPuA5HQs1diMEWiUL8tcc1+PAy7/AT i9cqE09F5HYNqF6aIneoqie/k2tJ6/iXroNNAsO6BIiilBjlUx9QVxz22+0MqIMo1hcg JvVJjk/dkJ+IZs5BrZX9tFCbXWA7UGKmbV0KaxEh5fM07Af+V5zUAax/WUctJOVevVax RZMMEgqpxTwwaZtjL85Wr8eNChXeCRtlYE3aAFjWSAWGezEtcmeFTMt7UQILYKhcIOxB 9zYg== X-Gm-Message-State: AOAM530sC/tyAgRmKSl/2/wGmw+6q/JeXZEsarmsb6KC1QF+CLXOa71t cl2mi7Z3ZQ4NMQ/t47xVkg6GHhiL0sxiiTctuxc= X-Google-Smtp-Source: ABdhPJyGS1BFSwd1F1fOTFVWTdVQat5+rdsAT3wItgVDbM6r3jwyQ6hK9nzOFtHHf0wR4+9T6nQzicYa6rqVnoJ2/9Y= X-Received: by 2002:a92:d946:: with SMTP id l6mr20336679ilq.162.1626010505941; Sun, 11 Jul 2021 06:35:05 -0700 (PDT) MIME-Version: 1.0 References: <1625231891-2963-1-git-send-email-fengchengwen@huawei.com> <1625995556-41473-1-git-send-email-fengchengwen@huawei.com> <71e9de4f-3c18-f75e-1c87-5e13d92cf53a@huawei.com> In-Reply-To: <71e9de4f-3c18-f75e-1c87-5e13d92cf53a@huawei.com> From: Jerin Jacob Date: Sun, 11 Jul 2021 19:04:39 +0530 Message-ID: To: fengchengwen Cc: Thomas Monjalon , Ferruh Yigit , "Richardson, Bruce" , Jerin Jacob , dpdk-dev , =?UTF-8?Q?Morten_Br=C3=B8rup?= , Nipun Gupta , Hemant Agrawal , Maxime Coquelin , Honnappa Nagarahalli , David Marchand , Satananda Burla , Prasun Kapoor , "Ananyev, Konstantin" , liangma@liangbit.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2] dmadev: introduce DMA device library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Jul 11, 2021 at 3:12 PM fengchengwen wrot= e: > > Note: > 1) This patch hold dmadev <> vchan layer, I think vchan can be very > conceptually separated from hw-channel. I would like to keep it as channel instead of virtual channel as it is implementation-specific. No strong opinion on this? @Richardson, Bruce @Morten Br=C3=B8rup thought= s > 2) I could not under struct dpi_dma_queue_ctx_s, so this patch I define > the rte_dma_slave_port_parameters refer to Kunpeng DMA implemention. > 3) This patch hasn't include doxy related file because failed to generate > a doc in my environment, could this upstream as a new patch or must > solved ? No IMO. The final version needs to be merged to should have split patch-lik= e, 1) Header file with doxygen comments 2) Multiple patches for implementation as needed 3) Programmer guide doc Other items, Typically we will have per new device class. 1) Skelton driver(can use memcpy in this case) 2) app/test-dmadev kind of application.(Can be used to measure performance and functionality) > > Feedback welcome, thanks > > On 2021/7/11 17:25, Chengwen Feng wrote: > > This patch introduce 'dmadevice' which is a generic type of DMA > > device. > > > > The APIs of dmadev library exposes some generic operations which can > > enable configuration and I/O with the DMA devices. > > > > Signed-off-by: Chengwen Feng > > --- >